458100 - [FIX]Blank iframe if nsPluginDocument gets OnStartRequest before its presshell is created

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Attachment: Flash file

See bug 388714 comment 41 through bug 388714 comment 47.  Minimal 100% reproducible testcase coming up.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: HTML file

Comment 2

[Boris Zbarsky [:bzbarsky]]

OK. So we don't instantiate the plug-in in OnStartRequest because there is no frame, as Evgeny found, and we don't instantiate it once a frame is created because nsObjectLoadingContent::HasNewFrame does nothing inside a plugin document.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: This seems to fix the issue for me

Evgeny, could you verify that this also fixes the blankness issues you were seeing?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Pushed changeset 9395c3a493b2.

I'm not sure what the best way to test this is.  karlt, would the stuff in bug 386144 be something I could use to write a test for this?

Comment 5

[Karl Tomlinson (:karlt)]

(In reply to comment #4)
> karlt, would the stuff in bug 386144 be something I could use to write
> a test for this?

It would be a step in the right direction at least.
Our reftests capture the output of plugins only when they are windowless.

The windowless plugins in bug 386144 follow the example of the Flash plugin and only become windowless when requested through a parameter.
I assume there is no way to pass such a parameter in this situation, so a test for this bug would need a plugin that is always windowless or maybe (I not sure) a plugin can be created that would choose windowless mode according to information in the src.

Comment 6

[Boris Zbarsky [:bzbarsky]]

roc, can our current test plugin be used to write a regression test for this bug?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Yes. It defaults to windowless.