[FIX]Blank iframe if nsPluginDocument gets OnStartRequest before its presshell is created

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
11 years ago
3 months ago

People

(Reporter: bzbarsky, Assigned: bzbarsky)

Tracking

Trunk
x86
macOS
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

Posted file Flash file
See bug 388714 comment 41 through bug 388714 comment 47.  Minimal 100% reproducible testcase coming up.
Posted file HTML file
Blocks: 355154
OK. So we don't instantiate the plug-in in OnStartRequest because there is no frame, as Evgeny found, and we don't instantiate it once a frame is created because nsObjectLoadingContent::HasNewFrame does nothing inside a plugin document.
Evgeny, could you verify that this also fixes the blankness issues you were seeing?
Attachment #341328 - Flags: superreview?(jst)
Attachment #341328 - Flags: review?(jst)
Summary: Blank iframe if nsPluginDocument gets OnStartRequest before its presshell is created → [FIX]Blank iframe if nsPluginDocument gets OnStartRequest before its presshell is created
QA Contact: content
Attachment #341328 - Flags: superreview?(jst)
Attachment #341328 - Flags: superreview+
Attachment #341328 - Flags: review?(jst)
Attachment #341328 - Flags: review+
Pushed changeset 9395c3a493b2.

I'm not sure what the best way to test this is.  karlt, would the stuff in bug 386144 be something I could use to write a test for this?
Status: NEW → RESOLVED
Closed: 11 years ago
Depends on: 386144
Flags: in-testsuite?
Resolution: --- → FIXED
(In reply to comment #4)
> karlt, would the stuff in bug 386144 be something I could use to write
> a test for this?

It would be a step in the right direction at least.
Our reftests capture the output of plugins only when they are windowless.

The windowless plugins in bug 386144 follow the example of the Flash plugin and only become windowless when requested through a parameter.
I assume there is no way to pass such a parameter in this situation, so a test for this bug would need a plugin that is always windowless or maybe (I not sure) a plugin can be created that would choose windowless mode according to information in the src.

Updated

10 years ago
Component: Content → DOM
QA Contact: content → general
roc, can our current test plugin be used to write a regression test for this bug?
Yes. It defaults to windowless.
No longer depends on: 572472
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.