Closed Bug 458152 Opened 12 years ago Closed 11 years ago

add compare-locales step to 1.9.0 release automation

Categories

(Release Engineering :: General, defect)

x86
Windows Vista
defect
Not set

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: armenzg, Unassigned)

References

Details

(Whiteboard: [l10n])

The l10n repackages in 1.9.0 release automation are not running compare-locales which is an important piece of information to see the sanity of a locale

Add whatever it was being used in the old way (tinderbox driven) until bug 400010 gets fixed by using the latest version of compare-locales
Blocks: 458153
Just by looking at this code:
http://mxr.mozilla.org/mozilla/source/tools/tinderbox/post-mozilla-rel.pl#988

988     for my $localetest (@Settings::CompareLocaleDirs) {
989       my $originaldir = "$srcdir/$localetest/locales/en-US";
990       my $localedir;
991       if ($Settings::CompareLocalesAviary) {
992         $localedir = "$srcdir/$localetest/locales/$locale";
993       }
994       else {
995         $localedir = "$srcdir/../l10n/$locale/$localetest";
996       }
997       $status = run_locale_shell_command "$^X $srcdir/toolkit/locales/compare-locales.pl $originaldir $localedir";
998       if ($tinderstatus eq 'success' && $status != 0) {
999         $tinderstatus = 'testfailed';
1000       }
1001     }

CompareLocaleDirs is defined in tinder-config.pl
175 nrthomas 1.1.2.9 
#@CompareLocaleDirs = (); 
# Run compare-locales test on these directories 
176 @CompareLocaleDirs = ( 
177 "netwerk", 
178 "browser", 
179 "dom", 
180 "toolkit", 
181 "security/manager", 
182 "other-licenses/branding/firefox", 
183 "extensions/reporter", 
184 ); 

This means that we should be fixing bug 400010 to use the right compare-locales

WONTFIX?
I don't see bug 4000010 being solved ad-hoc.
Depends on: 458938
I have filed bug 458938 to coordinate this bug and bug 400010
As per conversation with Axel this should not be blocking bug 458153
No longer blocks: 458153
Severity: blocker → normal
Component: Release Engineering → Release Engineering: Future
Whiteboard: [l10n]
I don't think we'll be doing anything new for 3.0 at this point. Let's file a new bug if we need something for 3.5 (or later).
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
Moving closed Future bugs into Release Engineering in preparation for removing the Future component.
Component: Release Engineering: Future → Release Engineering
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.