458211 - Proxy settings are ignored on N810/N900

Status: RESOLVED WORKSFORME

(Core :: Networking, defect)

Description

[Fabrice Desré]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b1pre) Gecko/20080909174204 Minefield/3.1b1pre
Build Identifier: 

When behind a proxy, you can configure the N810 to use a proxy. These settings are used by MicroB, but not Fennec even if network.http_proxy.type = 5

Reproducible: Always

Steps to Reproduce:
1. Set up a proxy in Maemo for you connection
2.
3.
Actual Results:  
No access to remote sites.

Expected Results:  
Fennec should use the Maemo proxy to access remote sites.

Comment 1

[Oleg Romashin (:romaxa)]

I think this should help:

https://garage.maemo.org/svn/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/not_sorted/maemo_hacks/GConfProxySettings.diff

Comment 2

[Antonio Gomes (tonikitoo)]

oleg, it could be checkin in at some point.

Comment 4

[Antonio Gomes (tonikitoo)]

romaxa, why is the following needed in the patch ?

 
-    prefBranch->UnlockPref(aPrefName);
+    prefBranch->LockPref(aPrefName);
(...) 
-    prefBranch->LockPref(aPrefName);
+    prefBranch->UnlockPref(aPrefName);

Comment 5

[Oleg Romashin (:romaxa)]

I'm not really sure, but originally I was using this patch on microb browser,and there are was some problems with that locks...

If it works without it, then I can remove it from patch...

Comment 6

[Oleg Romashin (:romaxa)]

Attachment: Patch for review

I have check this LockPref stuff and it still does not work without it.
Tested with fennec on latest mozilla trunk

Comment 7

[Oleg Romashin (:romaxa)]

doug do you have any comments about this patch?

Comment 8

[Doug Turner (:dougt)]

Comment on attachment 352392 [details] [diff] [review]
Patch for review

so, locking the pref make the preference service always return the default instead of the user-defined result.  So, it sounds like this patch isn't correct.

Is there a user define pref for network.proxy.autoconfig_url set that is messing up your testing?

Comment 9

[Jeremias Bosch (:jbos)]

Attachment: Patch to get proxysettings from maemo/diablo into fennec

This patch reads the proxysettings from the connection setup in maemo/diablo connection utilities and sets the correct preferences in fennec. Please note it depends on the patches in Bug 495674.

Comment 10

[Tobias Hunger]

Add dependency on #495674.

Comment 11

[Mark Finkle (:mfinkle) (use needinfo?)]

vote for not blocking1.0

Comment 12

[Doug Turner (:dougt)]

Comment on attachment 387841 [details] [diff] [review]
Patch to get proxysettings from maemo/diablo into fennec

I can review since I am also reviewing 495674

Comment 13

[Jeremias Bosch (:jbos)]

Attachment: ProxySettingsMaemo.diff

I updated the patch so that it apply to the patch in bug 495674

Comment 14

[Ben Combee (:bcombee)]

Looks like the N900 also supports these proxy settings -- it's in the Advanced section of configuring a connection.

Comment 15

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 407989 [details] [diff] [review]
ProxySettingsMaemo.diff

this patch works for me in that fennec picks up my connection settings now.

Comment 16

[Wolfgang Rosenauer [:wolfiR]]

Besides of this approach there are ideas to use the unixproxy component for proxy settings for maemo. It would pull the settings out of gconf if network.proxy.type is 5. I'm currently looking into it.

Comment 17

[Wolfgang Rosenauer [:wolfiR]]

In my testing so far it seems that it just works if the gconf module is built.
Bug 526451 contains a patch to allow gconf to be built in separately.

Comment 18

[Wolfgang Rosenauer [:wolfiR]]

Ok, let me explain the current status:
The patch in bug 526451 is NOT currently needed but related and an improvement.
Fennec/xulrunner is already built with gconf and unixproxy support.

I currently don't have a "working" proxy setup but was testing if Fennec would use the settings and for example fail for proxy settings where the server doesn't exist as in theory I would expect Fennec to just work in the current setup.

Here is my testcase:
- set a non-existant http proxy in the connection settings
- start Fennec and try to load a page

The interesting thing is that Fennec loaded pages for me while I was expecting it would fail.
So now modify the testcase and don't use Fennec to load a page but use for example TestPageLoad which is delivered in xulrunner:

This is what I get with an invalid proxy set:
/usr/local/xulrunner-1.9.2b3pre $ ./run-mozilla.sh ./TestPageLoad http://www.heise.de
Loading necko ... 
Starting clock ... 


--------------------
All done:
num found:0
num start:1


>>PageLoadTime>>258881>>


Now check what I get if no proxy is set:
/usr/local/xulrunner-1.9.2b3pre $ gconftool-2 -g /system/http_proxy/use_http_proxy
false
/usr/local/xulrunner-1.9.2b3pre $ ./run-mozilla.sh ./TestPageLoad http://www.heise.de
Loading necko ... 
Starting clock ... 
Getting: /support/lib/external.js
Getting: http://oas.heise.de/RealMedia/ads/Creatives/OasDefault/mjx/mjx.2009-11-17.0.js
Getting: /icons/ho/heise_online_logo.gif
Getting: /support/lib/login_ho.js
Getting: /imgs/02/4/4/4/3/8/8/Infrastruktur3-012809fa1d02be7d.png
Getting: /imgs/02/4/4/4/0/1/9/Gesundheitskarte5-c41333b49a5f7e62.png
Getting: /imgs/18/4/4/4/5/5/4/vampires.jpg-8e9ee54ec5caac3f.jpeg
Getting: /imgs/18/4/4/4/4/4/6/GoogleChrome3.jpg-373b2912bef83616.jpeg
Getting: /imgs/18/4/4/4/5/1/6/nrw_china.jpg-bf7af245f30f4c4f.jpeg
Getting: /imgs/18/4/4/4/4/3/5/obermann.jpg-bb460064e008ecc2.jpeg
Getting: /defeckerellyinesteetshygolingshetrica/
Getting: /ivw-bin/ivw/CP/
Getting: http://heise.ivwbox.de/cgi-bin/ivw/CP/homepage;/?r=';
Getting: /support/lib/mclient/mclient-1.0.js
Getting: http://heise.ivwbox.de/cgi-bin/ivw/CP/homepage;/?r=&d=
Getting: http://heise.ivwbox.de/2004/01/survey.js


--------------------
All done:
num found:16
num start:17


>>PageLoadTime>>1833924>>


My conclusion: xulrunner uses the proxy settings as expected but somehow in Fennec it doesn't work?

Comment 19

[Wolfgang Rosenauer [:wolfiR]]

Probably just call me stupid but after even more testing it seems all is working well but as soon as I use the predelivered bookmarks as addons.mozilla or support sites they got loaded. As I'm officially confused now from the different behaviour it would really good if others could share their testing experience.

NB: I'm using plain Fennec1.0b5 as provided from mozilla. No changes at all.

Comment 20

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 407989 [details] [diff] [review]
ProxySettingsMaemo.diff

Instead of setting the prefs like this, why not do this by implementing nsISystemProxySettings?

Comment 21

[Wolfgang Rosenauer [:wolfiR]]

Apparently there is still some misunderstanding. The patch in here is not needed. Everything already works through the toolkit/system/unixproxy component in my tests.

Comment 22

[Christian :Biesinger (don't email me, ping me on IRC)]

So this bug can be marked WORKSFORME?

Comment 23

[Wolfgang Rosenauer [:wolfiR]]

I'm waiting for testing feedback as it seems to work for me but probably not for others or in every case. That needs to be verified.

Comment 24

[Mark Finkle (:mfinkle) (use needinfo?)]

I tested this using a build _without_ the patch. I ran "nc -l -p 8080" on my
linux desktop and configured my N900 to use my desktop linux box as a proxy, on
port 8080.

When attempting to open a webpage in Fennec, I see a request appear in my
desktop linux terminal. I am assuming then, that the proxy detection is working
fine without this patch.

Comment 25

[Mark Finkle (:mfinkle) (use needinfo?)]

Marking WORKSFORME

Comment 26

[Jan Kratochvil]

fennec 7.0.1-2 armel still does not use the system proxy on N900 even with:
network.http_proxy.type = 5
Maintainer: Mobile Feedback <[e-mail]>