458623 - update comm-central l10n.ini's for l10n dashboard builds

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Axel Hecht [:Pike]]

Attachment: add toolkit and reporter detail info to l10n.ini for included l10n.inis

I have code in stock to get the buildbot details from l10n.ini. It doesn't require changes to compare-locales, just to the setup of the builds.

Comment 1

[Simon Paquet [:sipaq]]

Axel, someone with Calendar build experience (probably ause) should look over the calendar changes. Please ask him for review as well.

It would also helpful, to understand why these changes are actually necessary. Is there a corresponding bug report for mozilla-central that we could look into to get more background information?

Comment 2

[Axel Hecht [:Pike]]

It adds details about multi-repo builds to l10n.ini. I guess that gozer is really the guy to review this, as he set up an l10n buildbot for comm-central.

There is no example in mozilla-central, as that's only a single-repo build, so the whole problem doesn't exist.

Comment 3

[Philippe M. Chiasson (:gozer)]

Axel, can you show me the code changes to the l10n dashboard stuff that enabled this ? Also, I'd have to find a way to test this change before it goes in.

Comment 4

[Axel Hecht [:Pike]]

It's a chicken-and-egg problem. You can't test the dashboard without the changes to l10n.ini, and you can't test l10n.ini without the changes to the dashboard.

The remaining problem is that I'd rather not push more or less broken code to my public tooling repo.

Comment 5

[Robert Kaiser]

Comment on attachment 341842 [details] [diff] [review]
add toolkit and reporter detail info to l10n.ini for included l10n.inis

r=me, though I'd welcome if we could obsolete the [includes] section and replace it with this scheme.

And perhaps this scheme would even enable us to deal with optionally localized extensions in the future, by specifying the path to a locales list (all-locales) and only include checking, etc. if the given locale is listed there.

Both those ideas are followup fodder though.

Comment 6

[Philippe M. Chiasson (:gozer)]

Comment on attachment 341842 [details] [diff] [review]
add toolkit and reporter detail info to l10n.ini for included l10n.inis

I've been able to test that this change doesn't cause horrible build failures in my local builds, so it's probably safe enough for the tip. Once in, Axel, I'd like to see that tooling patches you are sitting on so I can test them out in our l10n dashboard setup.

Comment 7

[Axel Hecht [:Pike]]

Thanks for the reviews, http://hg.mozilla.org/comm-central/rev/21dfb8bb59fb is the landing on comm-central.

http://hg.mozilla.org/users/axel_mozilla.com/tooling/pushloghtml?fromchange=3c6a3cbe4f44&tochange=37f106027499 are the landings to the buildbot logic.

And http://l10n.mozilla.org/dashboard/ is showing Thunderbird results, and waiting for landings and forces to show seamonkey and calendar, too.

Hope you like that :-)

Comment 8

[Axel Hecht [:Pike]]

Marking FIXED. Not sure about the follow up fodder that KaiRo mentioned.

The current solution has the benefit that it doesn't need a change in compare-locales at all. I'd not aggressively remove the includes section for that reason.

Comment 9

[Robert Kaiser]

Axel, sure, I didn't want to suggest you're removing includes right now, I just think those things should probably filed as followups.

Comment 10

[Philippe M. Chiasson (:gozer)]

Attachment: backport defaultdict to python 2.4

Works great! I backed out my changes, updated, and it almost worked out of the box. I am still running python 2.4, so this includes a little backport of defaultdict. With it, all of it works fine in Python 2.4

Comment 11

[Martin Schröder [:mschroeder]]

Comment on attachment 342246 [details] [diff] [review]
backport defaultdict to python 2.4

gozer, who do you ask for review? ;-)

Comment 12

[Philippe M. Chiasson (:gozer)]

Comment on attachment 342246 [details] [diff] [review]
backport defaultdict to python 2.4

Oh, probably meant it to be Pike, unless you are interested in reviewing it ?

Comment 13

[Axel Hecht [:Pike]]

Comment on attachment 342246 [details] [diff] [review]
backport defaultdict to python 2.4

Is this still needed?

Comment 14

[Axel Hecht [:Pike]]

Comment on attachment 342246 [details] [diff] [review]
backport defaultdict to python 2.4

Doesn't sound like this is still needed, r-.