458655 - Position Mac About dialog somewhere better than 0:0

Status: RESOLVED FIXED

(Thunderbird :: General, defect, P3)

Description

[Phil Ringnalda (:philor)]

Since on OS X we do window.open rather than window.openDialog for the About window, we don't get to just use centerscreen for positioning, and since we don't do anything else, we currently open it jammed into the upper left corner. While we're stealing the Fx moveTo, we should take the opportunity to move the script out of the XUL (where I lose a minute or two every time, saying "wait, where's our aboutDialog.js?").

Comment 1

[Phil Ringnalda (:philor)]

Attachment: Fix v.1

A little copy, a little paste, a little whitespace cleanup...

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 341892 [details] [diff] [review]
Fix v.1

Oy.

Comment 3

[Phil Ringnalda (:philor)]

Not strictly a duplicate, but close enough.

Comment 4

[Phil Ringnalda (:philor)]

On second thought, if Magnus is stalled there, what better way to rub salt in his wounds than to bitrot him?

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 341892 [details] [diff] [review]
Fix v.1

*Now* I'm the only one in your queue with this same copy-paste!

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 341892 [details] [diff] [review]
Fix v.1

+  var iframe = document.getElementById("creditsIframe");
+  iframe.setAttribute("src", "");

I know this is just copy and paste, but I think whilst we're here, lets dump the intermediate variable.

+  var modes = document.getElementById("modes");
+  modes.setAttribute("selectedIndex", gSelectedPage);

ditto here.

Comment 7

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/723d31daabb3