Closed
Bug 458657
Opened 16 years ago
Closed 15 years ago
Remove Win16 reference from nsImapProtocol.cpp
Categories
(MailNews Core :: Networking: IMAP, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0b3
People
(Reporter: sgautherie, Assigned: Bienvenu)
References
(Blocks 1 open bug, )
Details
Attachments
(1 file)
|
4.77 KB,
patch
|
standard8
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
This code was added by http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/mailnews/imap/src/nsImapProtocol.cpp&mark=1.9#1.10
|
||
Updated•16 years ago
|
Product: Core → MailNews Core
|
||
Comment 1•15 years ago
|
||
To be exact. It was already added here: http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/imap/src&command=DIFF&root=/cvsroot&file=nsImapProtocol.cpp&rev1=1.8&rev2=1.9#9 David, do we still need (parts of) the code that was introduced 10 years ago (March 28 1999), especially the code snippet starting with http://hg.mozilla.org/comm-central/annotate/d2a8e9f48fa3/mailnews/imap/src/nsImapProtocol.cpp#l3722 ??
|
Assignee | |
Comment 2•15 years ago
|
||
I think the win16 comment is misleading, but no, we don't need this code anymore. I can take a whack at it since it'll be one less memory allocation.
Assignee: nobody → bienvenu
|
|
Assignee | |
Comment 3•15 years ago
|
||
this gets rid of the extra allocation, and moves duplicated code into a common routine.
Attachment #368785 -
Flags: superreview?(neil)
Attachment #368785 -
Flags: review?(bugzilla)
|
||
Updated•15 years ago
|
Attachment #368785 -
Flags: superreview?(neil) → superreview+
|
||
Updated•15 years ago
|
Attachment #368785 -
Flags: review?(bugzilla) → review+
|
|
Assignee | |
Comment 4•15 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b3
You need to log in
before you can comment on or make changes to this bug.
Description
•