438331 - (Win16Removal) [meta] Remove WIN16 (support) code everywhere

Status: NEW

(Core :: General, task)

Description

[Serge Gautherie (:sgautherie)]

+/- a revival of bug 211090,
but 5 years later, when even Win98 is unsupported (by Microsoft).

Comment 1

[David Bradley]

The WIN16 macro shouldn't really have anything to do with Win9x and they are 32 bit OS's even if they run on 16 bit DOS. WIN16 was for Windows 3.11 and before used segmented addresses. Other than the risk of inadvertently breaking something I'm not sure there's a reason to keep all the WIN16 specific code. If someone wants to run on Windows 3.x or earlier then they're going to be in the same boat as people wanting to run on PDP-11's and such.

Comment 2

[Serge Gautherie (:sgautherie)]

Sure, that's what I meant: Windows 3.x is outdated.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) </xpcom/*> ++ [Checkin: Comment 4]

(uncompiled, but trivial removals)

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 341873 [details] [diff] [review]
(Av1) </xpcom/*> ++
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/4c7ccb9f3e70

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Bv1-CommC) <configure.in> [Checkin: Comment 8]

(uncompiled, but trivial removals)

Comment 6

[Serge Gautherie (:sgautherie)]

Attachment: (Cv1-MozillaC) <configure.in> [Checkin: Comment 7]

(uncompiled, but trivial removals)

Comment 7

[Serge Gautherie (:sgautherie)]

Comment on attachment 342189 [details] [diff] [review]
(Cv1-MozillaC) <configure.in>
[Checkin: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/08c82bfcb50f

Comment 8

[Serge Gautherie (:sgautherie)]

Comment on attachment 342187 [details] [diff] [review]
(Bv1-CommC) <configure.in>
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/a4ef4b042748

Comment 9

[Serge Gautherie (:sgautherie)]

Attachment: (Dv1) </tools/> [Checkin: Comment 14]

(I'm not familiar with this file; please double-check.)

Comment 10

[Serge Gautherie (:sgautherie)]

Attachment: (Ev1) </sun-java/> [Superseded by bug 485984]

(uncompiled, but +/- trivial removals)

Comment 11

[Serge Gautherie (:sgautherie)]

Attachment: (Fv1) </parser/> [See comment 13]

(uncompiled, but trivial removals)

Comment 12

[Serge Gautherie (:sgautherie)]

Attachment: (Gv1) </config/mantomak.c>

(uncompiled, but trivial removals)

Comment 13

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 342255 [details] [diff] [review]
(Fv1) </parser/>
[See comment 13]

For consistency's sake, we should just leave the tests alone.

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 342245 [details] [diff] [review]
(Dv1) </tools/>
[Checkin: Comment 14]

http://hg.mozilla.org/mozilla-central/rev/c680133cfbae

Comment 15

[(not currently active) Ted Mielczarek]

Comment on attachment 342256 [details] [diff] [review]
(Gv1) </config/mantomak.c>

r=me to just remove config/mantomak.c. I don't know what it does, and it's not used anywhere.

Comment 16

[Serge Gautherie (:sgautherie)]

Attachment: (Gv1a) Remove </config/mantomak.*> [Checkin: Comment 17]

Gv1, with comment 15 suggestion(s),
plus the '.exe' file.

***

Unused in tree since at least mozilla1.7.

History:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mantomak.c
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mantomak.exe

Comment 17

[Serge Gautherie (:sgautherie)]

Comment on attachment 343945 [details] [diff] [review]
(Gv1a) Remove </config/mantomak.*>
[Checkin: Comment 17]

http://hg.mozilla.org/mozilla-central/rev/482d2613d1e0

Comment 18

[Jonathan Steele]

You want me to write a follow-up bugs for http://mxr.mozilla.org/mozilla-central/ident?i=SUPPORT_W16 ?

Comment 19

[Serge Gautherie (:sgautherie)]

(In reply to comment #18)

I filed bug 461363.

Comment 20

[Serge Gautherie (:sgautherie)]

Attachment: (Hv1) </security/*> (except nss) [Moved to bug 433791]

Comment 21

[Nelson Bolyard (seldom reads bugmail)]

Comment on attachment 366541 [details] [diff] [review]
(Hv1) </security/*> (except nss)
[Moved to bug 433791]

Although it's not part of the nss directory, coreconf is part of NSS.  No other code uses it.
So, please make this a CVS patch against the CVS trunk, and attach it to the NSS bug for eliminating Win16.

Comment 22

[Serge Gautherie (:sgautherie)]

Comment on attachment 366541 [details] [diff] [review]
(Hv1) </security/*> (except nss)
[Moved to bug 433791]


(In reply to comment #21)
> So, please make this a CVS patch against the CVS trunk,

I don't have a cvs checkout.

> and attach it to the NSS bug for eliminating Win16.

Done.

Comment 23

[Serge Gautherie (:sgautherie)]

Comment on attachment 342254 [details] [diff] [review]
(Ev1) </sun-java/>
[Superseded by bug 485984]


These files were removed today.

Comment 24

[Serge Gautherie (:sgautherie)]

Attachment: (Iv1) </embedding/> [Checkin: Comment 25]

Uncompiled, I hope this is simple enough...

Comment 25

[Serge Gautherie (:sgautherie)]

Comment on attachment 372020 [details] [diff] [review]
(Iv1) </embedding/>
[Checkin: Comment 25]


http://hg.mozilla.org/mozilla-central/rev/3b57ad0d0ed8

Comment 26

[Serge Gautherie (:sgautherie)]

Attachment: (Jv1) </modules/plugin/> [Checkin: Comment 30]

Uncompiled, but trivial.

Comment 27

[Serge Gautherie (:sgautherie)]

I assume
{
/modules/freetype2/builds/modules.mk
    * line 31 -- ifneq ($(findstring $(PLATFORM),dos win32 win16 os2),)
}
is an external project, not to be touched here, is it not?

Comment 28

[Serge Gautherie (:sgautherie)]

{
/js/src/liveconnect/jsj_hash.c
    * line 133 -- #endif /* WIN16 */
    * line 230 -- #endif /* WIN16 */
}
will be removed by bug 442399.

Comment 29

[Serge Gautherie (:sgautherie)]

Attachment: (Kv1) <makedep.cpp>

Fwiw, see
http://mxr.mozilla.org/mozilla-central/search?string=makedep%5B%5Ee%5D&regexp=on&case=on

Comment 30

[Serge Gautherie (:sgautherie)]

Comment on attachment 372269 [details] [diff] [review]
(Jv1) </modules/plugin/>
[Checkin: Comment 30]


http://hg.mozilla.org/mozilla-central/rev/58d7af53721f

Comment 31

[Benjamin Smedberg]

Comment on attachment 372269 [details] [diff] [review]
(Jv1) </modules/plugin/>
[Checkin: Comment 30]

Code cleanup doesn't need to land on branch.

Comment 32

[Serge Gautherie (:sgautherie)]

(In reply to comment #28)
> {
> /js/src/liveconnect/jsj_hash.c
>     * line 133 -- #endif /* WIN16 */
>     * line 230 -- #endif /* WIN16 */
> }
> will be removed by bug 442399.

Moved to bug 488824 which I filed.

Comment 33

[(not currently active) Ted Mielczarek]

Comment on attachment 372274 [details] [diff] [review]
(Kv1) <makedep.cpp>

I don't see the point in this comment. Either fix it the way your comment suggests, or don't bother adding the comment.

Comment 34

[Serge Gautherie (:sgautherie)]

Attachment: (Kv2) <makedep.cpp> [Checkin: Comment 35]

Kv1, with comment 33 suggestion(s).

Comment 35

[Serge Gautherie (:sgautherie)]

Comment on attachment 373980 [details] [diff] [review]
(Kv2) <makedep.cpp>
[Checkin: Comment 35]


http://hg.mozilla.org/mozilla-central/rev/43f2b453b68d

Comment 36

[Jonathan Steele]

I found these 

http://mxr.mozilla.org/mozilla-central/search?string=WINDOWS16&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

too, it should be removed too?

Comment 37

[Serge Gautherie (:sgautherie)]

(In reply to comment #36)

Probably yes, I filed bug 507897 ;-)

Comment 38

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:overholt, could you have a look please?
For more information, please visit auto_nag documentation.

Comment 39

[Andrew Overholt [:overholt]]

Do we need to do anything here?

Comment 40

[Sylvestre Ledru [:Sylvestre]]

TIL about this autonag rule, I love it :)
We still have some references to win16 in NSPR:
https://searchfox.org/mozilla-central/search?q=win16+&path=
Kai, can we remove them?
According to https://en.wikipedia.org/wiki/Comparison_of_Microsoft_Windows_versions, Windows Me was the last supported version

Comment 41

[Kai Engert (:KaiE:)]

I don't mind removing, but I also don't want to make this a priority, it seems harmless to have a little bit of old unused code.

Comment 42

[Sylvestre Ledru [:Sylvestre]]

agreed

Comment 43

[Richard Qian]

I think I could work on a task like this, despite being on Ubuntu GNU/Linux more often than Windows nowadays. I've been looking to see how complex it is to remove as much WIN16 code as possible without breaking anything significant, but going through all the files by myself is likely to make me get lost. I want to start off with something simple, before I decide to take on more complex tasks, and I'm not fully sure if this bug is it, despite that it's not high priority.

I may want to take assignment of this bug, but before that can happen and then I proceed, I think I may need some guidance on where I should look for unused WIN16 to be removed, so that I'm not wasting my time searching somewhere unnecessary.

Comment 44

[Andrew McCreight [:mccr8]]

A lot of patches have already been landed in this bug, so I don't think we should land any more using this bug number.

I'm not too familiar with this, but presumably the idea would be to look at the search link in the URL field, find some bit of code that should be removed, then file a new bug in the appropriate component and make it block this bug. You could then assign that blocking bug to yourself if you are working on it.

Comment 45

[Vijendra Pandey]

Hello, I am Vijendra Pandey. I am new to open-source and to Mozilla's interface too. I want to fix this bug but I don't any clue to how to clone this code on my side. Can anyone please help me out?

Comment 46

[Masatoshi Kimura [:emk]]

See comment #44.

Comment 47

[serval]

Attachment: WIP: Related Bug 438331, remove WIN16 in nsprpub/pr/tests/dll/Makefile.in

Comment 48

[Phabricator Automation]

Comment on attachment 9302254 [details]
WIP: Related Bug 438331, remove WIN16 in nsprpub/pr/tests/dll/Makefile.in

Revision D161428 was moved to bug 433790. Setting attachment 9302254 [details] to obsolete.