Bug 438331 (Win16Removal)

Remove WIN16 (support) code everywhere

ASSIGNED
Assigned to

Status

()

defect
--
trivial
ASSIGNED
11 years ago
9 years ago

People

(Reporter: sgautherie, Assigned: sgautherie)

Tracking

(Depends on 2 bugs, Blocks 1 bug, {helpwanted, meta})

Trunk
mozilla1.9.2a1
x86
Windows 95
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

()

Attachments

(8 attachments, 5 obsolete attachments)

2.92 KB, patch
benjamin
: review+
benjamin
: superreview+
Details | Diff | Splinter Review
1.79 KB, patch
kairo
: review+
Details | Diff | Splinter Review
1.79 KB, patch
ted
: review+
Details | Diff | Splinter Review
923 bytes, patch
gerv
: review+
Details | Diff | Splinter Review
22.88 KB, patch
ted
: review+
Details | Diff | Splinter Review
14.63 KB, patch
jaas
: review+
benjamin
: approval1.9.1-
Details | Diff | Splinter Review
3.61 KB, patch
jaas
: review+
benjamin
: approval1.9.1-
Details | Diff | Splinter Review
692 bytes, patch
ted
: review+
Details | Diff | Splinter Review
Assignee

Description

11 years ago
+/- a revival of bug 211090,
but 5 years later, when even Win98 is unsupported (by Microsoft).

Comment 1

11 years ago
The WIN16 macro shouldn't really have anything to do with Win9x and they are 32 bit OS's even if they run on 16 bit DOS. WIN16 was for Windows 3.11 and before used segmented addresses. Other than the risk of inadvertently breaking something I'm not sure there's a reason to keep all the WIN16 specific code. If someone wants to run on Windows 3.x or earlier then they're going to be in the same boat as people wanting to run on PDP-11's and such.
Assignee

Comment 2

11 years ago
Sure, that's what I meant: Windows 3.x is outdated.
Keywords: meta
OS: Windows 98 → Windows 95
Assignee

Updated

11 years ago
Depends on: 458657
Assignee

Comment 3

11 years ago
(uncompiled, but trivial removals)
Assignee: nobody → sgautherie.bz
Status: NEW → ASSIGNED
Attachment #341873 - Flags: superreview?(benjamin)
Attachment #341873 - Flags: review?(benjamin)
Assignee

Updated

11 years ago
Blocks: 458660

Updated

11 years ago
Attachment #341873 - Flags: superreview?(benjamin)
Attachment #341873 - Flags: superreview+
Attachment #341873 - Flags: review?(benjamin)
Attachment #341873 - Flags: review+
Assignee

Updated

11 years ago
Keywords: checkin-needed
Whiteboard: [c-n (when tree reopens): Av1]
Assignee

Comment 4

11 years ago
Comment on attachment 341873 [details] [diff] [review]
(Av1) </xpcom/*> ++
[Checkin: Comment 4]

http://hg.mozilla.org/mozilla-central/rev/4c7ccb9f3e70
Attachment #341873 - Attachment description: (Av1) </xpcom/*> ++ → (Av1) </xpcom/*> ++ [Checkin: Comment 4]
Assignee

Updated

11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Whiteboard: [c-n (when tree reopens): Av1]
Target Milestone: --- → mozilla1.9.1b2
Assignee

Updated

11 years ago
No longer blocks: 458660
Depends on: 458660
Assignee

Comment 5

11 years ago
(uncompiled, but trivial removals)
Attachment #342187 - Flags: review?(kairo)
Assignee

Comment 6

11 years ago
(uncompiled, but trivial removals)
Attachment #342189 - Flags: review?
Assignee

Updated

11 years ago
Attachment #342189 - Flags: review? → review?(ted.mielczarek)
Attachment #342189 - Flags: review?(ted.mielczarek) → review+
Assignee

Comment 7

11 years ago
Comment on attachment 342189 [details] [diff] [review]
(Cv1-MozillaC) <configure.in>
[Checkin: Comment 7]

http://hg.mozilla.org/mozilla-central/rev/08c82bfcb50f
Attachment #342189 - Attachment description: (Cv1-MozillaC) <configure.in> → (Cv1-MozillaC) <configure.in> [Checkin: Comment 7]

Updated

11 years ago
Attachment #342187 - Flags: review?(kairo) → review+
Assignee

Comment 8

11 years ago
Comment on attachment 342187 [details] [diff] [review]
(Bv1-CommC) <configure.in>
[Checkin: Comment 8]

http://hg.mozilla.org/comm-central/rev/a4ef4b042748
Attachment #342187 - Attachment description: (Bv1-CommC) <configure.in> → (Bv1-CommC) <configure.in> [Checkin: Comment 8]
Assignee

Comment 9

11 years ago
(I'm not familiar with this file; please double-check.)
Attachment #342245 - Flags: review?
Assignee

Updated

11 years ago
Attachment #342245 - Flags: review? → review?(gerv)
Assignee

Updated

11 years ago
Depends on: 459047
Assignee

Comment 10

11 years ago
(uncompiled, but +/- trivial removals)
Attachment #342254 - Flags: review?(alfred.peng)
Assignee

Comment 11

11 years ago
(uncompiled, but trivial removals)
Attachment #342255 - Flags: superreview?(mrbkap)
Attachment #342255 - Flags: review?(mrbkap)
Assignee

Comment 12

11 years ago
Posted patch (Gv1) </config/mantomak.c> (obsolete) — Splinter Review
(uncompiled, but trivial removals)
Attachment #342256 - Flags: review?(ted.mielczarek)
Comment on attachment 342255 [details] [diff] [review]
(Fv1) </parser/>
[See comment 13]

For consistency's sake, we should just leave the tests alone.
Attachment #342255 - Flags: superreview?(mrbkap)
Attachment #342255 - Flags: superreview-
Attachment #342255 - Flags: review?(mrbkap)
Attachment #342255 - Flags: review-
Assignee

Updated

11 years ago
Attachment #342255 - Attachment is obsolete: true
Attachment #342245 - Flags: review?(gerv) → review+
Assignee

Comment 14

11 years ago
Comment on attachment 342245 [details] [diff] [review]
(Dv1) </tools/>
[Checkin: Comment 14]

http://hg.mozilla.org/mozilla-central/rev/c680133cfbae
Attachment #342245 - Attachment description: (Dv1) </tools/> → (Dv1) </tools/> [Checkin: Comment 14]
Attachment #342256 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 342256 [details] [diff] [review]
(Gv1) </config/mantomak.c>

r=me to just remove config/mantomak.c. I don't know what it does, and it's not used anywhere.
Assignee

Comment 16

11 years ago
Gv1, with comment 15 suggestion(s),
plus the '.exe' file.

***

Unused in tree since at least mozilla1.7.

History:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mantomak.c
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/config/mantomak.exe
Attachment #342256 - Attachment is obsolete: true
Attachment #343945 - Flags: review?(ted.mielczarek)
Attachment #343945 - Flags: review?(ted.mielczarek) → review+
Assignee

Comment 17

11 years ago
Comment on attachment 343945 [details] [diff] [review]
(Gv1a) Remove </config/mantomak.*>
[Checkin: Comment 17]

http://hg.mozilla.org/mozilla-central/rev/482d2613d1e0
Attachment #343945 - Attachment description: (Gv1a) Remove </config/mantomak.*> → (Gv1a) Remove </config/mantomak.*> [Checkin: Comment 17]

Comment 18

11 years ago
You want me to write a follow-up bugs for http://mxr.mozilla.org/mozilla-central/ident?i=SUPPORT_W16 ?
Assignee

Updated

11 years ago
Depends on: 461363
Depends on: 479184
Assignee

Comment 19

10 years ago
(In reply to comment #18)

I filed bug 461363.
Comment on attachment 366541 [details] [diff] [review]
(Hv1) </security/*> (except nss)
[Moved to bug 433791]

Although it's not part of the nss directory, coreconf is part of NSS.  No other code uses it.
So, please make this a CVS patch against the CVS trunk, and attach it to the NSS bug for eliminating Win16.
Assignee

Comment 22

10 years ago
Comment on attachment 366541 [details] [diff] [review]
(Hv1) </security/*> (except nss)
[Moved to bug 433791]


(In reply to comment #21)
> So, please make this a CVS patch against the CVS trunk,

I don't have a cvs checkout.

> and attach it to the NSS bug for eliminating Win16.

Done.
Attachment #366541 - Attachment description: (Hv1) </security/*> (except nss) → (Hv1) </security/*> (except nss) [Moved to bug 433791]
Attachment #366541 - Attachment is obsolete: true
Attachment #366541 - Flags: review?(wtc)
Assignee

Updated

10 years ago
Attachment #342254 - Flags: review?(xiaobin.lu)
Assignee

Updated

10 years ago
Attachment #342254 - Attachment description: (Ev1) </sun-java/> → (Ev1) </sun-java/> [Superseded by bug 485984]
Attachment #342254 - Attachment is obsolete: true
Attachment #342254 - Flags: review?(xiaobin.lu)
Attachment #342254 - Flags: review?(alfred.peng)
Assignee

Comment 23

10 years ago
Comment on attachment 342254 [details] [diff] [review]
(Ev1) </sun-java/>
[Superseded by bug 485984]


These files were removed today.
Assignee

Updated

10 years ago
Depends on: 485984
Assignee

Updated

10 years ago
Target Milestone: mozilla1.9.1b2 → mozilla1.9.2a1
Assignee

Updated

10 years ago
Depends on: 487757
Assignee

Updated

10 years ago
Keywords: helpwanted
Assignee

Updated

10 years ago
Attachment #342255 - Attachment description: (Fv1) </parser/> → (Fv1) </parser/> [See comment 13]
Assignee

Comment 24

10 years ago
Uncompiled, I hope this is simple enough...
Attachment #372020 - Flags: superreview?(jst)
Attachment #372020 - Flags: review?(joshmoz)

Updated

10 years ago
Attachment #372020 - Flags: review?(joshmoz) → review+
Attachment #372020 - Flags: superreview?(jst) → superreview+
Assignee

Updated

10 years ago
Attachment #372020 - Attachment description: (Iv1) </embedding/> → (Iv1) </embedding/> [Checkin: Comment 25]
Attachment #372020 - Flags: approval1.9.1?
Assignee

Comment 26

10 years ago
Uncompiled, but trivial.
Attachment #372269 - Flags: superreview?(jst)
Attachment #372269 - Flags: review?(joshmoz)
Assignee

Comment 27

10 years ago
I assume
{
/modules/freetype2/builds/modules.mk
    * line 31 -- ifneq ($(findstring $(PLATFORM),dos win32 win16 os2),)
}
is an external project, not to be touched here, is it not?
Assignee

Comment 28

10 years ago
{
/js/src/liveconnect/jsj_hash.c
    * line 133 -- #endif /* WIN16 */
    * line 230 -- #endif /* WIN16 */
}
will be removed by bug 442399.
Depends on: 442399
Assignee

Updated

10 years ago
Attachment #372274 - Flags: superreview?(jst)
Attachment #372274 - Flags: superreview?
Attachment #372274 - Flags: review?(ted.mielczarek)
Attachment #372274 - Flags: review?

Updated

10 years ago
Attachment #372269 - Flags: review?(joshmoz) → review+
Attachment #372269 - Flags: superreview?(jst) → superreview+
Attachment #372274 - Flags: superreview?(jst) → superreview+
Assignee

Comment 30

10 years ago
Comment on attachment 372269 [details] [diff] [review]
(Jv1) </modules/plugin/>
[Checkin: Comment 30]


http://hg.mozilla.org/mozilla-central/rev/58d7af53721f
Attachment #372269 - Attachment description: (Jv1) </modules/plugin/> → (Jv1) </modules/plugin/> [Checkin: Comment 30]
Assignee

Updated

10 years ago
Attachment #372269 - Flags: approval1.9.1?

Updated

10 years ago
Attachment #372269 - Flags: approval1.9.1? → approval1.9.1-

Comment 31

10 years ago
Comment on attachment 372269 [details] [diff] [review]
(Jv1) </modules/plugin/>
[Checkin: Comment 30]

Code cleanup doesn't need to land on branch.

Updated

10 years ago
Attachment #372020 - Flags: approval1.9.1? → approval1.9.1-
Assignee

Updated

10 years ago
Depends on: 488824
Assignee

Comment 32

10 years ago
(In reply to comment #28)
> {
> /js/src/liveconnect/jsj_hash.c
>     * line 133 -- #endif /* WIN16 */
>     * line 230 -- #endif /* WIN16 */
> }
> will be removed by bug 442399.

Moved to bug 488824 which I filed.
No longer depends on: 442399
Comment on attachment 372274 [details] [diff] [review]
(Kv1) <makedep.cpp>

I don't see the point in this comment. Either fix it the way your comment suggests, or don't bother adding the comment.
Attachment #372274 - Flags: review?(ted.mielczarek) → review-
Assignee

Comment 34

10 years ago
Kv1, with comment 33 suggestion(s).
Attachment #372274 - Attachment is obsolete: true
Attachment #373980 - Flags: superreview?(jst)
Attachment #373980 - Flags: review?(ted.mielczarek)
Attachment #373980 - Flags: review?(ted.mielczarek) → review+
Assignee

Updated

10 years ago
Blocks: Win9xRemoval
Assignee

Updated

10 years ago
Attachment #373980 - Attachment description: (Kv2) <makedep.cpp> → (Kv2) <makedep.cpp> [Checkin: Comment 35]
Attachment #373980 - Flags: superreview?(jst)
Assignee

Updated

10 years ago
Depends on: 506621
Assignee

Updated

10 years ago
Depends on: 507897
Assignee

Comment 37

10 years ago
(In reply to comment #36)

Probably yes, I filed bug 507897 ;-)
Assignee

Updated

9 years ago
Alias: Win16Removal
You need to log in before you can comment on or make changes to this bug.