459086 - Lots of assertions from nsTextBoxFrame::DoLayout [###!!! ASSERTION: cannot call GetUsedPadding on a dirty frame not currently being reflowed: 'nsLayoutUtils::sDisableGetUsedXAssertions || !NS_SUBTREE_DIRTY(this) || (GetStateBits() & NS_FRAME_IN_REFLOW)',]

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Boris Zbarsky [:bzbarsky]]

nsTextBoxFrame::DoLayout calls CalcTextRect.  But that uses GetUsedPadding, and we hit this wonderful assertion:

###!!! ASSERTION: cannot call GetUsedPadding on a dirty frame not currently being reflowed: 'nsLayoutUtils::sDisableGetUsedXAssertions || !NS_SUBTREE_DIRTY(this) || (GetStateBits() & NS_FRAME_IN_REFLOW)', file /Users/bzbarsky/mozilla/debug/mozilla/layout/generic/nsFrame.cpp, line 615

I assume that the frame should have NS_FRAME_IN_REFLOW set (and presumably have the offsets correctly computed!) by now, no?

This codepath was introduced in bug 438517.

Comment 1

[OOO until Apr 20; Dan Mosedale (:dmosedale, :dmose)]

I see lots of these in one of my Thunderbird builds as well.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Beside bug 419289 this is the other assertion which occurs dozen of times. It would be great to have it fixed.

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1223598746.1223600228.18688.gz&fulltext=1

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Rob, are you working on this or was it wrongly assigned to you?

Comment 4

[Rob Arnold [:robarnold]]

I thought I wrote a comment in this bug already. When I wrote the text-shadow patch, I saw the assertions too, but roc told me that they were ok. Hopefully when he gets back he'll have some ideas about how to solve it. Still, you should only be seeing them when there is text-shadow applied to an nsTextBoxFrame which as far as I know is only with Ctrl-Tab on Vista.

Comment 5

[Boris Zbarsky [:bzbarsky]]

I see them all the time on Mac, multiple times per reflow of the URL bar.  Dozens of assertions per window open.

Comment 6

[Justin Dolske [:Dolske]]

I'm also seeing a flood of these on OS X -- makes monitoring the console in debug builds painful. :(

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Now this also happens by simply hovering over links.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: fix

UL sucks and doesn't call WillReflow during its layout. Fortunately it provides a GetBorderAndPadding method which avoids the assertion (by not supporting percentage padding, I guess, but whatever).

Comment 9

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Comment on attachment 343862 [details] [diff] [review]
fix

r+sr=dbaron

Comment 10

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Pushed dac237f37585

Comment 11

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Extreme clean console again. Only some warnings left. Thanks Roc!

Verified with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081021 Minefield/3.1b2pre ID:20081021200750

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1b2pre) Gecko/20081021 Minefield/3.1b2pre ID:20081021195400