Closed
Bug 459284
Opened 17 years ago
Closed 17 years ago
in shell/shell_toplevel.as File exists has wrong type
Categories
(Tamarin Graveyard :: Virtual Machine, defect)
Tracking
(Not tracked)
VERIFIED
FIXED
Future
People
(Reporter: dschaffe, Assigned: dschaffe)
References
Details
Attachments
(1 file)
|
9.33 KB,
patch
|
tierney
:
review+
|
Details | Diff | Splinter Review |
The File.exists implementation in FileClass.cpp returns a bool so in shell_toplevel.as the exists function should have a return type of Boolean not String.
After changing exists to return Boolean and rebuilding the shell exists works correctly.
Flags: wanted-flashplayer10+
Flags: in-testsuite+
Flags: flashplayer-triage+
Flags: flashplayer-qrb?
|
||
Comment 1•17 years ago
|
||
please add patch and get it reviewed
Assignee: nobody → dschaffe
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Target Milestone: --- → Future
|
|
Assignee | |
Comment 2•17 years ago
|
||
patch changes shell_toplevel.as File.exists return type to Boolean. rebuild shell_toplevel files. add a testcase for File.
Attachment #342902 -
Flags: review?(tierney)
|
|
||
Updated•17 years ago
|
Attachment #342902 -
Flags: review?(tierney) → review+
|
|
Assignee | |
Comment 3•17 years ago
|
||
submitted patch:
details: http://hg.mozilla.org/tamarin-central/?rev/07fa3fa55d42
changeset: 691:07fa3fa55d42
added a testcase in acceptance tests.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
|
|
||
Updated•17 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•