Wrap favicon work in a transaction

RESOLVED FIXED in mozilla1.9.1b2

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sdwilsh, Assigned: sdwilsh)

Tracking

Trunk
mozilla1.9.1b2
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

10 years ago
We do a fair amount of writes in FaviconLoadListener::OnStopRequest.  The problem is that we don't batch them in a transaction, which can reduce some fsyncs which will help us run faster.
(Assignee)

Comment 1

10 years ago
Created attachment 342518 [details] [diff] [review]
v1.0
Attachment #342518 - Flags: review?(dietrich)
Comment on attachment 342518 [details] [diff] [review]
v1.0

r=me
Attachment #342518 - Flags: review?(dietrich) → review+
(Assignee)

Comment 3

10 years ago
Created attachment 342637 [details] [diff] [review]
v1.1

I actually meant to get SetFaviconData in the transaction too...
Attachment #342518 - Attachment is obsolete: true
Attachment #342637 - Flags: review?(dietrich)
Attachment #342637 - Flags: review?(dietrich) → review+
(Assignee)

Updated

10 years ago
Whiteboard: [has patch][has review]
(Assignee)

Updated

10 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]
You need to log in before you can comment on or make changes to this bug.