Closed Bug 459315 Opened 16 years ago Closed 16 years ago

Wrap favicon work in a transaction

Categories

(Toolkit :: Places, defect)

Product:
Toolkit
Component:
Places
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b2

People

(Reporter: sdwilsh, Assigned: sdwilsh)

References

Details

Attachments

(1 file, 1 obsolete file)

v1.1
1.83 KB, patch
dietrich
: review+
Details | Diff | Splinter Review 
We do a fair amount of writes in FaviconLoadListener::OnStopRequest.  The problem is that we don't batch them in a transaction, which can reduce some fsyncs which will help us run faster.
Attached patch v1.0 (obsolete) — — Splinter Review 

        Attachment #342518 -
        Flags: review?(dietrich)

    
    

    
  
Comment on attachment 342518 [details] [diff] [review]
v1.0

r=me

        Attachment #342518 -
        Flags: review?(dietrich) → review+

    
    

    
  

      
      
      
      

        Attached patch
          
          
        v1.1
        — 
          — Splinter Review
      

    


  
I actually meant to get SetFaviconData in the transaction too...

        Attachment #342518 -
        Attachment is obsolete: true

        Attachment #342637 -
        Flags: review?(dietrich)

        Attachment #342637 -
        Flags: review?(dietrich) → review+

    
  
Whiteboard: [has patch][has review]

    
  
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Whiteboard: [has patch][has review]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: