459357 - Support accessible name computation for SVG

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

I believe we will need to support the title attribute for SVG. Not sure if there are any other attributes that could influence the name (other than ARIA ones).

Comment 1

[Robert Longson [:longsonr]]

title attribute? SVG has a title element which is bug 329212.

Comment 2

[Aaron Leventhal]

Robert, thanks. Anything else where a text equivalent might be specified?

Comment 3

[Robert Longson [:longsonr]]

http://www.w3.org/TR/SVG-access/#Links mentions the xlink:title attribute on links and title and desc elements

Comment 5

[alexander :surkov (:asurkov)]

from bug 633983:

A request from the wild, and should be easy enough. The idea is to map a child element <title> to the accessible name, and the <desc> to accessible description.

btw, there's a test case there.

Comment 6

[alexander :surkov (:asurkov)]

Attachment: patch

Comment 7

[Trevor Saunders (:tbsaunde)]

Comment on attachment 693786 [details] [diff] [review]
patch

>+function testDescr(aAccOrElmOrID, aDescr)
>+{
>+  var acc = getAccessible(aAccOrElmOrID);
>+  if (!acc)
>+   return;

I'd rather we didn't just return if the element doesn't have an accessible.

>+    {
>+      testName("svg1", "A name");
>+      testDescr("svg1", "A description");
>+      testName("svg2", "A tooltip");

test svg2 has no description?  maybe not because its important, but would be nice to know if we change it unintentionally

Comment 8

[alexander :surkov (:asurkov)]

(In reply to Trevor Saunders (:tbsaunde) from comment #7)
> Comment on attachment 693786 [details] [diff] [review]
> patch
> 
> >+function testDescr(aAccOrElmOrID, aDescr)
> >+{
> >+  var acc = getAccessible(aAccOrElmOrID);
> >+  if (!acc)
> >+   return;
> 
> I'd rather we didn't just return if the element doesn't have an accessible.

getAccessible() reports an error if the given ID is not accessible so returning seems to be a right thing.

> >+      testName("svg1", "A name");
> >+      testDescr("svg1", "A description");
> >+      testName("svg2", "A tooltip");
> 
> test svg2 has no description?  maybe not because its important, but would be
> nice to know if we change it unintentionally

ok, good point

Comment 9

[alexander :surkov (:asurkov)]

Btw, I think it'd be nice to keep name and description in the same place (not separately) since they are closely related. But keeping description stuff under name might be not nice. Alternatives: "textequivalent", "textequiv" or "namedescr". Which one do you think suites better?

Comment 10

[alexander :surkov (:asurkov)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/18e5579588b5

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/18e5579588b5