459435 - Sync suite/locales/Makefile.in with Firefox' version

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect)

Description

[Robert Kaiser]

There have been a number of updates to the mozilla/browser/locales/Makefile.in we should port to SeaMonkey's version.

Comment 1

[Robert Kaiser]

The following patches have parts to be ported here:

http://hg.mozilla.org/mozilla-central/rev/1d31da26a09dd27914da85e6f3075b4a2f167962
Bug 399665 - Support replacing BrandShortName and BrandFullName in the installer. r=sspitzer

http://hg.mozilla.org/mozilla-central/rev/ccce859a94aa7b827c4eb7c92013714e7319d5e8
Bug 451461 - make target that prepares l10n repackages to upload to ftp; r=ted.mielczarek
(using variables as requested with bug 456351)

http://hg.mozilla.org/mozilla-central/rev/e96a238b497b2140b48cbeabf4ddbe140b51f0bb
bug 453840: make it possible to create files in the final place for releases - follow-up to MOZ_PKG_PRETTYNAMES patch to support win32

Comment 2

[Robert Kaiser]

Attachment: patch v1

Here's the patch that brings our locales/Makefile.in up to par with the one Firefox is using.

Comment 3

[Robert Kaiser]

Comment on attachment 342667 [details] [diff] [review]
patch v1

>diff --git a/suite/locales/Makefile.in b/suite/locales/Makefile.in
>--- a/suite/locales/Makefile.in
>+++ b/suite/locales/Makefile.in
>+prepare-repackages-%: AB_CD=$*

Sorry, this needs another line immediately after that one to build. The line is as following:
+prepare-repackages-%:

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 342667 [details] [diff] [review]
patch v1

Bug 453840 got backed out, I think we may want to hold off on some of these changes at least.

Comment 5

[Robert Kaiser]

Comment on attachment 342667 [details] [diff] [review]
patch v1

Actually, only the smaller patch for dealing with filenames with spaces has been backed out regarding bug 453840, the rest is still in. This means the first two hunks of this patch (those just adding quotes) can probably be disregarded until that followup issue has been fully dealt with, but the rest of the patch is still valid.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 342667 [details] [diff] [review]
patch v1

r=me without the first two hunks as previously discussed.

Comment 7

[Robert Kaiser]

Thanks, pushed as http://hg.mozilla.org/comm-central/rev/0e391b0e5160