390344 - avoid the second UAC prompt for helper.exe on software update by launching it directly from the elevated updater.exe process

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Robert Strong (they/them - no direct email)]

Spinoff of bug 368587 for Seamonky. Bug 390214 for Thunderbird has a smaller patch that demonstrates what needs to be done.

Comment 1

[Robert Kaiser]

Thanks for notifying us of this - we don't support AUS/updater.exe right now, but we want to look into it soon, so good to know what we need to fix along with that ;-)

Comment 2

[Robert Strong (they/them - no direct email)]

Currently nsPostUpdateWin.js launches the helper.exe to update the registry and the uninstall log. Bug 397964 will remove that file so adding dependency.

Comment 4

[Robert Kaiser]

Bug 446527 has introduced some changes that actually updated the locales Makefile to where it should be after the patch and causes a "No such file or directory" error for the additional updater_append.ini.

Comment 5

[Robert Kaiser]

Attachment: add updater_append.ini

This patch adds the missing updater_append.ini - we apparently don't have any mention of uninstall.log in uninstaller.nsi, so I didn't look into those parts. Frank, do we have a bug to get all that added?

Comment 6

[Frank Wein [:mcsmurf]]

(In reply to comment #5)
> Created an attachment (id=342654) [details]
> add updater_append.ini
> 
> This patch adds the missing updater_append.ini - we apparently don't have any
> mention of uninstall.log in uninstaller.nsi, so I didn't look into those parts.
> Frank, do we have a bug to get all that added?

We have, see for example http://mxr.mozilla.org/comm-central/source/suite/installer/windows/nsis/uninstaller.nsi#264.

Comment 7

[Robert Strong (they/them - no direct email)]

The uninstaller needs to be updated so the log file from software update is used to update the uninstall.log via UninstallOnInitCommon which calls UpdateUninstallLog
http://mxr.mozilla.org/mozilla-central/source/toolkit/mozapps/installer/windows/nsis/common.nsh#3508

This would likely be added as part of bug 449423 which I believe is the SeaMonkey bug for updating the installer to reflect the current changes in Firefox's installer though the name doesn't reflect that... also of note is bug 404609

Comment 8

[Frank Wein [:mcsmurf]]

My plan was to attach a patch to Bug 453797 for some changes, need to see how far it makes sense to port single patches to SeaMonkey installer (compared to just looking at all changes together from a few month ago up to now and creating a patch based on that).

Comment 9

[Robert Kaiser]

Attachment: patch v2: port Thunderbird patch

I finally found the places where we reference uninstall.log, no idea why I missed that earlier. I ported the Thunderbird patch to our file, the locales/Makefile.in part has been done already.

Comment 10

[Frank Wein [:mcsmurf]]

Comment on attachment 343256 [details] [diff] [review]
patch v2: port Thunderbird patch

Actually now updating the installer is no longer necessary, sorry for that (installer is covered by Bug 453797). r+ on the updater_append.ini part of the patch.

Comment 11

[Robert Kaiser]

OK, pushed updater_append.ini as http://hg.mozilla.org/comm-central/rev/883aa9c8df11, marking this bug fixed, I'll leave everything else to your installer patches then!