459682 - S/MIME signing messes HTML messages when using UTF-8

Status: RESOLVED DUPLICATE of bug 307023

(Thunderbird :: General, defect)

Description

[h.goebel]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.17) Gecko/20080703 Mandriva/2.0.0.17-1.1mdv2008.1 (2008.1) Firefox/2.0.0.17
Build Identifier: Thunderbird 2.0.0.17 (20080926)

If S/MIME "sign message" is set when saving a HTML message as template, the template gets messed. HTML attributes are cut of the first character, Image-links are destroied, and to on. In short: such a template is unusable.

Reproducible: Always

Steps to Reproduce:
Preparation: Make sure you have a valid certificate for signing.

1. Create a simple HTML message containing some image.
2. Make sure S/MIME "sign message" is OFF.
3. Save the message as template.
4. Change th subject, just so you may distinguish the messages later.
5. Now switch on S/MIME "sign message" and save again as template.
Actual Results:  
6. Go to the Templates folder
7. Open the first template: the image is shown.
8. Open the second template: the image is _not_ shown.

Expected Results:  
Both templates should be the same. In this example: the image should be shown in both  cases.

You may use some add-on like "stationary" or "EditHTML" to view the HTML source of both messages. You'll see, there are messed attributes, in this example the src-Attribute of the image tag is trashed.

Comment 1

[h.goebel]

Attachment: unsigned message as described

Comment 2

[h.goebel]

Attachment: signed message as described

Comment 3

[h.goebel]

Attachment: python script for extracting the text/html part

Comment 4

[h.goebel]

The python script may be used for extracting the content (text/html-part) of the message. The output shows the message is wrong when stroing it as signed template

Comment 5

[h.goebel]

It is even worse: this happens every time when saving a message. This is even when sending a message.

Comment 6

[h.goebel]

I tracked this down further: This problem depends on the charakter-set encoding used and the Transfer-Encoding.

ISO-8859-1  -> Transfer-Encoding: 7bit             -> okay
ISO-8859-15 -> Transfer-Encoding: quoted-printable -> BUGGY
UTF-8       -> Transfer-Encoding: quoted-printable -> BUGGY

This was tested with a small message containing some iso-8869-1 umlauts, but not Euro sign (which would be iso-8859-15).

So it looks like zo be a problem of Transfer-Encoding: quoted-printable

Comment 7

[Magnus Melin [:mkmelin]]

wanted‑thunderbird3-; would take a patch though.

Comment 8

[h.goebel]

Magnus, you are a joker! What about at least pointing out where to find the code instead of just rebuffing. This is not suited to encourage further volunteer work.

Comment 9

[Magnus Melin [:mkmelin]]

If I knew exactly where in the source code the problem is I'd tell you. The biggest problem is usually finding out where it goes wrong. I'd start looking at one of these: <http://mxr.mozilla.org/comm-central/search?string=quoted-printable&filter=^[^\0]*$>

Looking more closely at this, I think this it's not the special edge case I thought it was, but bug 307023. Mark as dupe?

For smime messages we use q-p or base64 encoding (per the spec, not to invalidate the message in case a server isn't working well with non-ascii.)

Comment 10

[h.goebel]

Magnus, I did some more tests and it looks as if this one is a problem with multipart/related messages. Thus I mark this one as a dupe for bug 307023 and put more stuff there.

A simple HTML-message did not show the bug, put as soon as adding a image to the message, it was trashed after saving.

Comment 11

[h.goebel]

Magnus, please mark as dupe, I'm not allowed to.