459764 - Failing to connect to memcache isn't an error if memcache isn't configured

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Wil Clouser [:clouserw]]

Attachment: fix error

Our current code fills up the error log even if memcache_config isn't an array.  I don't think it should.

Comment 1

[Fred Wenzel [:wenzel]]

Comment on attachment 342965 [details] [diff] [review]
fix error

Yup, that should work -- though I wonder why you would switch on QUERY_CACHE if you don't mean it ;)

Comment 2

[Wil Clouser [:clouserw]]

QUERY_CACHE is true by default.

Also, am I the only one that thinks we have a ridiculous amount of config files?  I can't tell you how many times I've opened the wrong files looking to change the current database name...gah.

Thanks, r19043.

Comment 3

[Fred Wenzel [:wenzel]]

(In reply to comment #2)
> Also, am I the only one that thinks we have a ridiculous amount of config
> files?

What, a project's quality is not measured by the amount of config files it has? ;)

It's true though: I, for example, don't know why we have config-local *and* config.php -- but that's a different bug.