Failing to connect to memcache isn't an error if memcache isn't configured

RESOLVED FIXED

Status

RESOLVED FIXED
10 years ago
3 years ago

People

(Reporter: clouserw, Assigned: clouserw)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
Created attachment 342965 [details] [diff] [review]
fix error

Our current code fills up the error log even if memcache_config isn't an array.  I don't think it should.
Attachment #342965 - Flags: review?(fwenzel)

Comment 1

10 years ago
Comment on attachment 342965 [details] [diff] [review]
fix error

Yup, that should work -- though I wonder why you would switch on QUERY_CACHE if you don't mean it ;)
Attachment #342965 - Flags: review?(fwenzel) → review+
(Assignee)

Comment 2

10 years ago
QUERY_CACHE is true by default.

Also, am I the only one that thinks we have a ridiculous amount of config files?  I can't tell you how many times I've opened the wrong files looking to change the current database name...gah.

Thanks, r19043.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Comment 3

10 years ago
(In reply to comment #2)
> Also, am I the only one that thinks we have a ridiculous amount of config
> files?

What, a project's quality is not measured by the amount of config files it has? ;)

It's true though: I, for example, don't know why we have config-local *and* config.php -- but that's a different bug.
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.