460568 - removeAttribute('contenteditable') doesn't work fine

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: testcase

removeAttribute('contenteditable') doesn't work fine.

The editable element should be changed to normal contents, however, the inner elements are not reset the editable state.

See the attached testcase, you cannot focus to the anchor even if the contenteditable attribute was removed.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.0

ChangeEditableState should not be called before nsGenericHTMLElementBase::UnsetAttr. Because it's looking the attr value for its result. But it will be updated by nsGenericHTMLElementBase::UnsetAttr.

Comment 2

[Peter Van der Beken [:peterv]]

Comment on attachment 343704 [details] [diff] [review]
Patch v1.0

I'd do:

  PRBool contentEditable = PR_FALSE;
  PRInt32 contentEditableChange;

  // Check for event handlers
  if (aNameSpaceID == kNameSpaceID_None) {
    if (aAttribute == nsGkAtoms::contenteditable) {
      contentEditable = PR_TRUE;
      contentEditableChange = GetContentEditableValue() == eTrue ? -1 : 0;
    }
    else if (nsContentUtils::IsEventAttributeName(aAttribute,
                                                  EventNameType_HTML)) {
      nsCOMPtr<nsIEventListenerManager> manager;
      GetListenerManager(PR_FALSE, getter_AddRefs(manager));

      if (manager) {
        manager->RemoveScriptEventListener(aAttribute);
      }
    }
  }

  nsresult rv = nsGenericHTMLElementBase::UnsetAttr(aNameSpaceID, aAttribute,
                                                    aNotify);
  NS_ENSURE_SUCCESS(rv, rv);

  if (contentEditable) {
    ChangeEditableState(contentEditableChange);
  }

  return NS_OK;

With that, r/sr=me.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Patch v1.1

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

checked-in.