Closed Bug 502273 Opened 16 years ago Closed 16 years ago

contentEditable is disabled if an attribute is removed from the node

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.2a1
Tracking Flags:
Tracking Status
status1.9.1 --- .2-fixed

People

(Reporter: liucougar, Assigned: masayuki)

References

Details

(Keywords: regression, testcase, verified1.9.1)

Attachments

(2 files)

test case for this bug
338 bytes, text/html
Details
Patch v1.0
5.97 KB, patch
peterv
: review+
peterv
: superreview+
beltzner
: approval1.9.1.2+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1) Gecko/20090624 Firefox/3.5 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.1) Gecko/20090624 Firefox/3.5 contentEditable=true is ignored if an attribute is removed from the contentEditable node Reproducible: Always Steps to Reproduce: 1. open the test case attached 2. click the button at the top 3. click into the red area, and starts to type Actual Results: nothing happens Expected Results: it should be possible to continue edit the red area after clicking the button, contentEditable=true is still present on the div, but it does nothing this is a regression from Firefox 3.0.11
Attached file test case for this bug —
Confirmed on Windows Vista. Regression range is: http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=531db9fe7e20&tochange=5aedf4e6479b
Blocks: 460568
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression, testcase
Version: unspecified → Trunk
Wow, I checked-in the wrong patch at bug 502273. I'll post a correct patch shortly.
Assignee: nobody → masayuki
Flags: wanted1.9.1.x?
(In reply to comment #3) > Wow, I checked-in the wrong patch at bug 502273. I'll post a correct patch > shortly. oops, I meant bug 460568.
Attached patch Patch v1.0 — — Splinter Review
peterv: I'm sorry. I failed to import your comment's code (bug 460568 comment 2) before check-in because I misread your code at that time. This patch should success to import your code.
Attachment #386797 - Flags: superreview?(peterv)
Attachment #386797 - Flags: review?(peterv)
Component: Editor → DOM
QA Contact: editor → general
Status: NEW → ASSIGNED
Attachment #386797 - Flags: superreview?(peterv)
Attachment #386797 - Flags: superreview+
Attachment #386797 - Flags: review?(peterv)
Attachment #386797 - Flags: review+
Comment on attachment 386797 [details] [diff] [review] Patch v1.0 Ugh. Should try to fix that regression in 1.9.1 too.
http://hg.mozilla.org/mozilla-central/rev/faed63e342fd
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 386797 [details] [diff] [review] Patch v1.0 ok, let's take this. this bug is a regression of gecko1.9.1. the logic is broken by my mistake. this patch corrects it.
Attachment #386797 - Flags: approval1.9.1.2?
Comment on attachment 386797 [details] [diff] [review] Patch v1.0 a1912=beltzner
Attachment #386797 - Flags: approval1.9.1.2? → approval1.9.1.2+
Flags: wanted1.9.1.x?
Verified with testcase in comment #1 using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2 In 3.5 you can't type in the red area. In 3.5.2 you can.
Keywords: verified1.9.1
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: