Disabled link toolbar buttons need more three-dimensional appearance

RESOLVED FIXED

Status

SeaMonkey
Themes
--
trivial
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: neil@parkwaycc.co.uk, Assigned: neil@parkwaycc.co.uk)

Tracking

({polish})

Trunk
x86
Windows 2000
polish

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

9 years ago
Bug 69710 introduced a three-dimensional disabled appearance for toolbarbuttons when using the Windows Classic skin. However, the rules for the bookmarks and link toolbar buttons conflict with this, resulting in disabled link toolbar buttons being drawn using incorrect system colours.
(Assignee)

Comment 1

9 years ago
Created attachment 343833 [details] [diff] [review]
Proposed patch

This patch resolves the problem by not changing the appropriate CSS styles on disabled bookmarks thus avoiding having to override them with the wrong values.

As the underlying CSS is OS-specific I'd like cross-platform testing :-)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #343833 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 2

9 years ago
Comment on attachment 343833 [details] [diff] [review]
Proposed patch

See previous comment, because I don't know your unique username, assuming you have one...
Attachment #343833 - Flags: review?(stefanh)

Comment 3

9 years ago
Comment on attachment 343833 [details] [diff] [review]
Proposed patch

This seems to work fine on mac. That is, it doesn't change anything.
Attachment #343833 - Flags: review?(stefanh) → review+

Comment 4

9 years ago
Comment on attachment 343833 [details] [diff] [review]
Proposed patch

Works fine on Linux, i.e. no change, and the change seems fairly subtle on windows, hard to tell if it is my eyes or there is a change.
Attachment #343833 - Flags: review?(iann_bugzilla) → review+
(Assignee)

Comment 5

9 years ago
Pushed changeset 90692f79a317 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.