Closed
Bug 69710
Opened 24 years ago
Closed 16 years ago
Disabled menu items need more three-dimensional appearance
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.9.1b2
People
(Reporter: bugzilla, Assigned: neil)
References
Details
(Keywords: polish)
Attachments
(3 files, 3 obsolete files)
6.19 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
20.95 KB,
image/gif
|
Details | |
1.65 KB,
patch
|
dao
:
review+
beltzner
:
approval1.9.1b2+
|
Details | Diff | Splinter Review |
Disabled menuitems need a more three-dimensional appearance, like they have on Windows; they're currently just gray, which isn't quite enough visual feedback. Giving this to Ben, since he said he once had a stack binding that achieved a similar effect.
Comment 1•24 years ago
|
||
Blake, I assume you mean that std Windows disabled items are essentially painted twice (once with COLOR_3DHILIGHT and once with COLOR_3DSHADOW, with a slight offset)?
Updated•24 years ago
|
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Comment 2•23 years ago
|
||
Please see comments in Bug 137350. I believe this relates to the implementation of the CSS value GrayText. Windows only.
Comment 4•21 years ago
|
||
Mass reassign of my non-Firefox bugs to ben_seamonkey@hotmail.com
Assignee: bugs → ben_seamonkey
Status: ASSIGNED → NEW
Updated•20 years ago
|
Product: Core → Mozilla Application Suite
Updated•18 years ago
|
Assignee: ben_seamonkey → guifeatures
QA Contact: bugzilla
Updated•17 years ago
|
Assignee: guifeatures → nobody
Component: XP Apps: GUI Features → XUL Widgets
Depends on: text-shadow
Product: Mozilla Application Suite → Toolkit
QA Contact: xul.widgets
Updated•17 years ago
|
Assignee | ||
Comment 7•16 years ago
|
||
As per groupboxes this isn't enabled for Luna/Aero but is enabled on W2k.
Comment 8•16 years ago
|
||
Comment on attachment 341264 [details] [diff] [review] Proposed patch >:not(:-moz-system-metric(windows-default-theme)) { :-moz-system-metric(windows-classic) >+ text-shadow: 1px 1px ThreeDHighlight; Is ThreeDHighlight what native apps actually use? >+checkbox[disabled="true"]:not(:-moz-system-metric(windows-default-theme)) { >+ text-shadow: 1px 1px ThreeDHighlight !important; Why !important?
Attachment #341264 -
Flags: review?(dao) → review-
Comment 9•16 years ago
|
||
(In reply to comment #8) > >+ text-shadow: 1px 1px ThreeDHighlight; > > Is ThreeDHighlight what native apps actually use? This probably needs to be tested with different color schemes, esp. high contrast ones.
Assignee | ||
Comment 10•16 years ago
|
||
* Replaced :not(:-moz-system-metric(windows-default-theme)) with :-moz-system-metric(windows-classic) (including some existing rules) * Removed !important (including some existing rules) * Added color: ThreeDShadow; after verifying against high contrast themes
Attachment #341264 -
Attachment is obsolete: true
Attachment #341284 -
Flags: review?(dao)
Comment 11•16 years ago
|
||
Comment on attachment 341284 [details] [diff] [review] Updated for review comments It might be a good idea to update the same files in gnomestripe for consistency (except the windows-specific stuff). >diff -r 8f53fcb8bde5 toolkit/themes/winstripe/global/menu.css >+menulist > menupopup > menuitem[disabled="true"]:not([_moz-menuactive="true"]):-moz-system-metric(windows-classic) { >+ text-shadow: none; >+} Shouldn't the color be reset to GrayText here as well?
Attachment #341284 -
Flags: review?(dao) → review+
Assignee | ||
Comment 12•16 years ago
|
||
(In reply to comment #11) >(From update of attachment 341284 [details] [diff] [review]) >It might be a good idea to update the same files in gnomestripe for consistency >(except the windows-specific stuff). Sorry, I'm not following you here... do you mean that all those widgets should have shadows in gnomestripe at all times? >>diff -r 8f53fcb8bde5 toolkit/themes/winstripe/global/menu.css >>+menulist > menupopup > menuitem[disabled="true"]:not([_moz-menuactive="true"]):-moz-system-metric(windows-classic) { >>+ text-shadow: none; >>+} >Shouldn't the color be reset to GrayText here as well? I thought that the previous rule had a higher weight, but I was wrong.
Comment 13•16 years ago
|
||
(In reply to comment #12) > Sorry, I'm not following you here... do you mean that all those widgets should > have shadows in gnomestripe at all times? No, I was referring to the !important flags cleanup.
Assignee | ||
Comment 14•16 years ago
|
||
I duplicated the style rules in gnomestripe to stop the hover rule overriding the disabled rule (winstripe has no hover text colour).
Attachment #341284 -
Attachment is obsolete: true
Attachment #341424 -
Flags: review?(dao)
Comment 15•16 years ago
|
||
Comment on attachment 341424 [details] [diff] [review] Fixed patch I think this would be more straightforward: radio:not([disabled="true"]):hover { color: -moz-buttonhovertext; }
Attachment #341424 -
Flags: review?(dao) → review+
Updated•16 years ago
|
Component: XUL Widgets → Themes
QA Contact: xul.widgets → themes
Assignee | ||
Comment 16•16 years ago
|
||
Pushed changeset 6251e69516c9 to mozilla-central.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Comment 17•16 years ago
|
||
change width and height of xul:button, xul:checkbox, xul:menulist, xul:radio... This is very strange.
Assignee | ||
Comment 18•16 years ago
|
||
That's not quite true; only checkboxes and radio buttons are affected. (Bug 458231 if you're interested.) dao, as a workaround I could add transparent shadows to all classic checkboxes and radios so that they don't change size when disabled, if you like?
Comment 19•16 years ago
|
||
(In reply to comment #18) > That's not quite true; only checkboxes and radio buttons are affected. > (Bug 458231 if you're interested.) Ok, It was my misunderstanding. Thank you.
Comment 20•16 years ago
|
||
(In reply to comment #18) > dao, as a workaround I could add transparent shadows to all classic checkboxes > and radios so that they don't change size when disabled, if you like? Depends on if you think bug 458231 makes 1.9.1...
Updated•16 years ago
|
Attachment #347524 -
Flags: review?(dao)
Comment 22•16 years ago
|
||
Comment on attachment 347524 [details] [diff] [review] Work around bug 458213 Why -2px? Wouldn't -1 compensate the shadow correctly? 458213 is the wrong bug number...
Assignee | ||
Comment 23•16 years ago
|
||
Confirmed by screen capture, the appearance with a transparent shadow and bottom margin of -2px matches the appearance without either styles. The disabled appearance with this patch matches the disabled appearance with bug 458231. (Of course, combining both patches results in an incorrect appearance!) I had a look in layout code but I couldn't work out why it was -2 and not -1.
Attachment #347524 -
Attachment is obsolete: true
Attachment #347530 -
Flags: review?(dao)
Updated•16 years ago
|
Attachment #347530 -
Flags: review?(dao) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #347530 -
Flags: approval1.9.1b2?
Assignee | ||
Updated•16 years ago
|
Target Milestone: Future → mozilla1.9.1b2
Comment 24•16 years ago
|
||
Comment on attachment 347530 [details] [diff] [review] Work around bug 458231 a=beltzner
Attachment #347530 -
Flags: approval1.9.1b2? → approval1.9.1b2+
You need to log in
before you can comment on or make changes to this bug.
Description
•