The JS code into diff-header.html.tmpl doesn't need to be generated on the fly, depending on the data passed to the template, so we can move it into js/attachment.js.
Created attachment 343906 [details] [diff] [review] patch, v1
(In reply to comment #2) > This removal caused a test warning: Ah yes, you're right. I removed it on checkin. Thanks! Checking in js/attachment.js; /cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v <-- attachment.js new revision: 1.4; previous revision: 1.3 done Checking in template/en/default/filterexceptions.pl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v <--filterexceptions.pl new revision: 1.118; previous revision: 1.117 done Checking in template/en/default/attachment/diff-header.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v <-- diff-header.html.tmpl new revision: 1.21; previous revision: 1.20 done