460754 - Move JS code out of attachment/diff-header.html.tmpl

Status: RESOLVED FIXED

(Bugzilla :: Attachments & Requests, enhancement)

Description

[Frédéric Buclin]

The JS code into diff-header.html.tmpl doesn't need to be generated on the fly, depending on the data passed to the template, so we can move it into js/attachment.js.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Teemu Mannermaa (:wicked)]

Comment on attachment 343906 [details] [diff] [review]
patch, v1

>Index: template/en/default/attachment/diff-header.html.tmpl
>===================================================================

This file certainly has many validation failures, especially in non-header mode that doesn't even have a DOCTYPE declaration. Header mode has script blocks within tbody tags, which is not allowed. These are not new for this patch so this is only a note keeping bug 273847 in mind.

>-  [% javascript %]

This removal caused a test warning:

t/008filter..........NOK 126#   Failed test '(en/default) template/en/default/attachment/diff-header.html.tmpl - filterexceptions.pl has extra members:
#   javascript

Remove that line and this patch is good to go.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> This removal caused a test warning:

Ah yes, you're right. I removed it on checkin. Thanks!

Checking in js/attachment.js;
/cvsroot/mozilla/webtools/bugzilla/js/attachment.js,v  <--  attachment.js
new revision: 1.4; previous revision: 1.3
done
Checking in template/en/default/filterexceptions.pl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/filterexceptions.pl,v  <--filterexceptions.pl
new revision: 1.118; previous revision: 1.117
done
Checking in template/en/default/attachment/diff-header.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/diff-header.html.tmpl,v  <--  diff-header.html.tmpl
new revision: 1.21; previous revision: 1.20
done