461167 - Bookmark groups are not showing in bookmarks menu

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Misak Khachatryan]

Attachment: screenshot

Mozilla/5.0 (X11; U; Linux i686; rv:1.9.1b2pre) Gecko/20081022 SeaMonkey/2.0a2pre ID:20081022184547

Adblock Plus 0.7.5.5
Adblock Plus: Element Hiding Helper 1.0.5
ChatZilla 0.9.83
DOM Inspector 2.0.1
DownThemAll! 1.0.3
Expiry Canary 0.3
FlashGot 1.1.2
Flat Bookmark Editing 0.8.1
Image Zoom 0.3
InspectorWidget 2.11.20080214
JavaScript Debugger 0.9.87.4
keywordManager 0.6.4
MessageFaces 1.1
Nightly Tester Tools 2.0.2
Quote Colors 0.2.8
SeaMonkey Debug and QA UI 1.0pre
Storage Inspector 0.5
Tab Clicking Options 0.6.9
Tabs Open Relative 0.3
Tinderstatus 0.2.11
Update Channel Selector 1.0.3
User Agent Switcher 0.6.10
xSidebar 1.0.4

Starting from today i've noticed that groupmarks are not showing in bookmarks menu. When i open bookmarks menu, my groupmarks are replaced by half-line height empty lines, but tool tip showing names of groupmark. Screenshot is available.

Regression window is maximum from 20 oct, i'm using this groupmark almost every day.

Comment 1

[Stefan [:stefanh]]

I see this too on my trunk build. Occurs on both themes. One funny thing is that I can see the groupmark (icon+label) in my native menu, but not in the xul toolbar menu.

Comment 2

[[e-mail]]

Someone is generating a menupopup child of a menuitem... naturally the template specifies no such thing!

Comment 3

[doctor__j]

After checking the nightly builds, the bug happened at "2008-10-21-00-comm-central" build.  Everything is OK at "2008-10-20-07-comm-central" build.  

May someone find out what checkins broke that.

Comment 4

[[e-mail]]

Verified regression from bug 450990 by local backout.

Comment 5

[Neil Deakin]

I don't understand what this bug is about.

Comment 8

[[e-mail]]

(In reply to comment #5)
> I don't understand what this bug is about.
The bug is that the following template rule

    <rule nc:FolderGroup="true" iscontainer="true">
      <menupopup>
        <menuitem class="menuitem-iconic bookmark-group"
                  label="rdf:http://home.netscape.com/NC-rdf#Name"
                  group="true"
                  uri="rdf:*"
                  xulcontentsgenerated="true"/>
      </menupopup>
    </rule>

generates incorrect content, currently:

      <menupopup>
        <!-- other bookmarks in the same folder go here -->
        <menuitem id="rdf:#$lrvih2"
                  container="true"
                  class="menuitem-iconic bookmark-group"
                  label="Bookmark Group Name Here"
                  group="true"
                  xulcontentsgenerated="true">
          <menupopup/> <!-- this is erroneous causing bug as reported -->
        </menuitem>
        <!-- now generates menuitems for each individual tab - new bug ? -->
      </menupopup>

Comment 9

[[e-mail]]

Perhaps the old code used to honour xulcontentsgenerated="true" which faked it out into not trying to create child menuitems for each tab in the group?

Comment 10

[[e-mail]]

Attachment: Proposed patch

OK, so the fix is to add another rule to stop the template builder trying to build children for menuitems. The rest of the patch is just cleanup ;-)

Comment 11

[Neil Deakin]

I didn't intend to remove support for xulcontentsgenerated="true", but if this is patch is ok then perhaps we can just leave it that way, as that confusingly-named attribute isn't particularly documented.

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Why is this in Core/XUL rather than SeaMonkey/Bookmarks?

Comment 13

[[e-mail]]

I originally treated it as a regression in the template behaviour, as it turned out of the undocumented xulcontentsgenerated attribute.

However as I have subsequently discovered the workaround this makes it possible to move the bug in the manner you have described.

Comment 14

[[e-mail]]

Pushed changeset cc76d0f40126 to comm-central.

Comment 15

[[e-mail]]

D'oh, that's twice today, I'm going senile :-(

Comment 16

[Cris Mooney]

Looks like this is already resolved for the next release following 2.0a2.

However, since I already wrote it up, here is yet another account to clarify testing in 2.0a2.

Issue: Bookmark this group of tabs not showing tab set name in menu following browser start

Saved bookmark "tab groups" are not showing their name in the "Bookmarks" menu (both window menu and using icon in the "personal toolbar". Newly added bookmarks are showing the menu immediately after being added, however they are also lost if you quit and restart the browser. Tab group bookmarks loaded on startup do reserve a row in the menu, and work, and show the name on flyover in the menu, but the menu row is blank.

Steps:

1. Open multiple tabs and "Bookmark this group of tabs".
2. Note that the bookmarks menu shows the new "name" of the tabset.
3. Quit SeaMonkey, then start it back up.
4. Note that the bookmarks menu shows empty (blank) for the name of the tabset.

Comment 18

[Serge Gautherie (:sgautherie)]

(In reply to comment #16)
> Issue: Bookmark this group of tabs not showing tab set name in menu following
> browser start

Please, file a followup bug.