513275 - New bookmark folders show "(Empty)" item until SeaMonkey restarted, take 2

Status: VERIFIED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1.1pre) Gecko/20090717 SeaMonkey/2.0b1] (release) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20090819 SeaMonkey/2.1a1pre] (home, optim default) (W2Ksp4)
(http://hg.mozilla.org/mozilla-central/rev/aef07655f47f
 +http://hg.mozilla.org/comm-central/rev/140d79e50cc7 + bug 510717 patch A)

1. Create a new folder. (Any way you like.)
2. Drag and drop from the location bar to the new folder.
   (Drop on folder name, '(Empty)' is not dropppable :-/)
3. Reopen folder.
3r. Both '(Empty)' and the bookmark are there :-(

Workaround:
4. Open Bookmark Manager.
4r. Check that B.M. doesn't show '(Empty)', only the P.T. does.
5. Move the folder.
5r. P.T. doesn't display '(Empty)' anymore.

I assume this is a regression, as bug 79411 was R.Fixed.

Comment 1

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/20070515 SeaMonkey/1.5a] (nightly) (W2Ksp4)

SM 1.5a had bug 262231 but not this one.

Comment 2

[Robert Kaiser]

When dropping on '(Empty)', I get the following in the error console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult: "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame :: chrome://communicator/content/bookmarks/bookmarksMenu.js :: anonymous :: line 129"  data: no]

Not sure if that's something else or related to this.

Comment 3

[Serge Gautherie (:sgautherie)]

(In reply to comment #2)
> When dropping on '(Empty)', I get the following in the error console:

Ah, thanks for noticing!
I confirm with both 2.0b1 and lastest 2.0b2 nightly.

> Not sure if that's something else or related to this.

I would guess it is related, as in possibly the cause.

Comment 4

[Serge Gautherie (:sgautherie)]

(In reply to comment #1)
> SM 1.5a had bug 262231 but not this one.

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a5pre) Gecko/2007052914 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

Too.

Comment 5

[Serge Gautherie (:sgautherie)]

New behavior appeared between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081202 SeaMonkey/2.0a2] (release) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20090223 SeaMonkey/2.0a3] (release) (W2Ksp4)

Comment 6

[Serge Gautherie (:sgautherie)]

New behavior appeared between
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081213 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4)
and
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b3pre) Gecko/20081214 SeaMonkey/2.0a3pre] (nightly) (W2Ksp4)

http://hg.mozilla.org/comm-central/pushloghtml?startdate=2008-12-12+23&enddate=2008-12-14+01
Most probably bug 461167.

Comment 8

[[e-mail]]

(In reply to comment #6)
> Most probably bug 461167.
Yeah, well if you back that out you don't get any "(Empty)" items at all...

Comment 9

[Serge Gautherie (:sgautherie)]

Yeah, I didn't mean to back it out: just finding out where/what to look at.

Comment 10

[[e-mail]]

Attachment: Proposed patch

Using CSS instead as isempty doesn't seem to be reliable in a template.

Comment 11

[Ian Neal]

(In reply to comment #2)
> When dropping on '(Empty)', I get the following in the error console:
> 
> Error: uncaught exception: [Exception... "Component returned failure code:
> 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIRDFService.GetResource]"  nsresult:
> "0x80070057 (NS_ERROR_ILLEGAL_VALUE)"  location: "JS frame ::
> chrome://communicator/content/bookmarks/bookmarksMenu.js :: anonymous :: line
> 129"  data: no]
> 
> Not sure if that's something else or related to this.
That isn't fixed by the current patch on this bug.

Comment 12

[[e-mail]]

No, that's a separate bug.

Comment 13

[[e-mail]]

[Note to fixer of drop bug: drop on (Empty) should work like drop on parent.]

Comment 14

[[e-mail]]

Pushed changeset 0dc6f51f3cc3 to comm-central.

Comment 15

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.3a1pre) Gecko/20090921 SeaMonkey/2.1a1pre] (nightly) (W2Ksp4)

V.Fixed


(In reply to comment #2)
> When dropping on '(Empty)', I get the following in the error console:

I filed bug 518060.