461215 - Dev CP fails to load for authors with many add-ons

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Fred Wenzel [:wenzel]]

The user with ID 37347 can't access the Dev CP (when he clicks on the link, the browser waits, then brings up a white page).

I found out he is listed as the author of 16 add-ons. A quick look at the source code for the index action of the developer controller shows that it pulls in a lot of data:

1341         //Bind necessary models
1342         $this->User->bindFully();
1343         $this->Addontype->bindFully();
1344         $this->Version->bindFully();
1345         $this->Addon->bindFully(); 

My guess is we're hitting the memory limit here, which goes quite easy with the numerous associations these models have.

Comment 1

[Fred Wenzel [:wenzel]]

morgamic writes:

"I recommend:

   * Only fully binding Addons
   * Doing a manual query to pull addon_ids prior to the Addons query"

Comment 2

[Wil Clouser [:clouserw]]

I've had 25 add-ons in my Dev CP for a long time with minimal delay.  23 are search engines though so maybe they are pulling less data.

Comment 3

[Fred Wenzel [:wenzel]]

I will try to reproduce the error locally and I am just importing a fresh DB dump for that purpose (which, obviously, takes a long time). I should hopefully be able to get an error message off the logs then.

Comment 4

[Fred Wenzel [:wenzel]]

It's also possible that these add-ons have a lot of versions and files or something -- keep in mind, *all* associations are pulled here.

Comment 5

[Justin Scott [:fligtar]]

It is weird that we're getting these complaints all of the sudden. I'm not sure it's connected with how many add-ons an author has. One of the emails amo-editors got yesterday said that someone just created an account and then created an add-on and couldn't access the Dev Tools index after that.

Comment 6

[Wil Clouser [:clouserw]]

Logging in as user id 37347 on my staging copy says it's an execution time issue.  Bumping the time from 30 -> 60 fixes it.  comment #1 is a good move.

Comment 7

[Justin Scott [:fligtar]]

I will have time to look at this tomorrow, but have a big project I'm working on tonight... based on the number of reports of this on IRC and email, we may need to fix and push it ASAP.

Comment 8

[Justin Scott [:fligtar]]

Attachment: patch, v1

Copied some code from the new dev cp index (dashboard()) and morphed it a bit to format the array the same way the old stuff did.

This fixes the execution time problems for me.

Comment 9

[Fred Wenzel [:wenzel]]

Comment on attachment 345010 [details] [diff] [review]
patch, v1

That solves it for me as well. I tried the user account from comment 0.

Comment 10

[Justin Scott [:fligtar]]

r19378.

Is there a push scheduled for this week? If not, I think this is important enough to push ASAP. I personally have seen about 15-20 complaints from people experiencing this, and probably many more who haven't reported it or assume it's a problem on their end.

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Jason, is this now working for you?