461542 - consolidate the (unix) start scripts for our applications

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Marco Perez [:mpk]]

While discussing bug 363173 on IRC this week we discovered that some of our
start scripts (the ones usually generated from mozilla.in) are actually a
bit out of date.

The ones for XULRunner and Sunbird are quite affected, but the ones for
SeaMonkey, Firefox and Thunderbird could also benefit from small tweaks,
which found their way into one or several of the others.

I'll attach the patches shortly. They were inspired by the fixes for the
following bugs:
- bug 280725
- bug 384714
- bug 386582
- bug 389673

Comment 1

[Marco Perez [:mpk]]

Attachment: consolidation patches for firefox and xulrunner (mozilla-central)

Does this patch require sr as well, since it touches several files?
If so, who would be a good requestee?

Comment 2

[Marco Perez [:mpk]]

Attachment: consolidation patches for suite, mail and calendar (comm-central)

Comment 3

[Benjamin Smedberg]

Comment on attachment 344639 [details] [diff] [review]
consolidation patches for firefox and xulrunner (mozilla-central)

Is there any difference at all between browser/app/mozilla.in and xulrunner/app/mozilla.in? If not, can we just share the file rather than having two copies of it?

Please re-request review if this is won't work for some reason.

Comment 4

[Marco Perez [:mpk]]

Yeah, that might actually work. No, mozilla.in would be absolutely identical
across all applications. Not only for browser and xulrunner, but for suite,
mail and calendar as well. Now I just have to find out how to achieve this
without breaking anything else... ;-) I'll post some new patches as soon as
I find a clean solution.

Comment 5

[Marco Perez [:mpk]]

Attachment: mozilla-central patch, with one central mozilla.in file

Comment 6

[Marco Perez [:mpk]]

Attachment: comm-central patch (needs the m-c patch checked in first!) [Checkin: Comment 15]

Comment 7

[Mark Banner (:standard8)]

Comment on attachment 346956 [details] [diff] [review]
comm-central patch (needs the m-c patch checked in first!)
[Checkin: Comment 15]

Looks good. Just for the record, the big set of differences between Sunbird's mozilla.in and the others are mainly due to bug 280725 not being applied there.

r=me.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346739 [details] [diff] [review]
mozilla-central patch, with one central mozilla.in file

Let's wait until after the beta.

Comment 9

[Marco Perez [:mpk]]

Attachment: mozilla-central patch v3 [Checkin: Comment 11 & 14]

The introduction of GLOBAL_DEPS last week (see bug 463824) broke my m-c patch,
impacting Firefox, XULRunner and Fennec (on *nix).

This updated version fixes this and also removes the execute flag from the
mozilla.in since it gets set on the actual startup script upon its' creation
anyway (through the Makefile).

Please note that this patch still is a prerequisite for my c-c patch.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

a191=beltzner

Comment 11

[Serge Gautherie (:sgautherie)]

Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

http://hg.mozilla.org/mozilla-central/rev/72a4c2b4e160

Comment 12

[Dietrich Ayala (:dietrich)]

there was a significant Ts hit on Linux around the time this was checked in:

http://graphs.mozilla.org/graph.html#show=1431030,395123,395133,395164&sel=1228763058,1229025120

could this have been responsible?

Comment 13

[Dietrich Ayala (:dietrich)]

never mind, it's this:

https://bugzilla.mozilla.org/show_bug.cgi?id=464995#c20

Comment 14

[Serge Gautherie (:sgautherie)]

Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/09ea61756b7a

Comment 15

[Serge Gautherie (:sgautherie)]

Comment on attachment 346956 [details] [diff] [review]
comm-central patch (needs the m-c patch checked in first!)
[Checkin: Comment 15]

http://hg.mozilla.org/comm-central/rev/1818c8fa024f