Closed Bug 461542 Opened 11 years ago Closed 11 years ago

consolidate the (unix) start scripts for our applications

Categories

(Toolkit :: Startup and Profile System, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla1.9.1b3

People

(Reporter: mpk, Assigned: mpk)

References

Details

(Keywords: fixed1.9.1)

Attachments

(2 files, 3 obsolete files)

While discussing bug 363173 on IRC this week we discovered that some of our
start scripts (the ones usually generated from mozilla.in) are actually a
bit out of date.

The ones for XULRunner and Sunbird are quite affected, but the ones for
SeaMonkey, Firefox and Thunderbird could also benefit from small tweaks,
which found their way into one or several of the others.

I'll attach the patches shortly. They were inspired by the fixes for the
following bugs:
- bug 280725
- bug 384714
- bug 386582
- bug 389673
Does this patch require sr as well, since it touches several files?
If so, who would be a good requestee?
Attachment #344639 - Flags: review?(benjamin)
Attachment #344641 - Flags: review?(benjamin)
Attachment #344639 - Flags: review?(benjamin)
Comment on attachment 344639 [details] [diff] [review]
consolidation patches for firefox and xulrunner (mozilla-central)

Is there any difference at all between browser/app/mozilla.in and xulrunner/app/mozilla.in? If not, can we just share the file rather than having two copies of it?

Please re-request review if this is won't work for some reason.
Yeah, that might actually work. No, mozilla.in would be absolutely identical
across all applications. Not only for browser and xulrunner, but for suite,
mail and calendar as well. Now I just have to find out how to achieve this
without breaking anything else... ;-) I'll post some new patches as soon as
I find a clean solution.
Attachment #344639 - Attachment is obsolete: true
Attachment #346739 - Flags: review?
Attachment #346739 - Flags: review? → review?(benjamin)
Attachment #346739 - Flags: review?(benjamin) → review+
Attachment #344641 - Flags: review?(benjamin)
Keywords: checkin-needed
Attachment #344641 - Attachment is obsolete: true
Attachment #346956 - Flags: review?(bugzilla)
Attachment #346739 - Flags: approval1.9.1b2?
Keywords: checkin-needed
Comment on attachment 346956 [details] [diff] [review]
comm-central patch (needs the m-c patch checked in first!)
[Checkin: Comment 15]

Looks good. Just for the record, the big set of differences between Sunbird's mozilla.in and the others are mainly due to bug 280725 not being applied there.

r=me.
Attachment #346956 - Flags: review?(bugzilla) → review+
Comment on attachment 346739 [details] [diff] [review]
mozilla-central patch, with one central mozilla.in file

Let's wait until after the beta.
Attachment #346739 - Flags: approval1.9.1b2?
Attachment #346739 - Flags: approval1.9.1b2-
Attachment #346739 - Flags: approval1.9.1+
The introduction of GLOBAL_DEPS last week (see bug 463824) broke my m-c patch,
impacting Firefox, XULRunner and Fennec (on *nix).

This updated version fixes this and also removes the execute flag from the
mozilla.in since it gets set on the actual startup script upon its' creation
anyway (through the Makefile).

Please note that this patch still is a prerequisite for my c-c patch.
Attachment #346739 - Attachment is obsolete: true
Attachment #350755 - Flags: review?(benjamin)
Attachment #350755 - Flags: approval1.9.1?
Attachment #346739 - Flags: review+
Attachment #346739 - Flags: approval1.9.1b2-
Attachment #346739 - Flags: approval1.9.1+
Attachment #350755 - Flags: review?(benjamin) → review+
Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

a191=beltzner
Attachment #350755 - Flags: approval1.9.1? → approval1.9.1+
Keywords: checkin-needed
Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

http://hg.mozilla.org/mozilla-central/rev/72a4c2b4e160
Attachment #350755 - Attachment description: mozilla-central patch v3 → mozilla-central patch v3 [Checkin: Comment 11]
Flags: in-testsuite-
Whiteboard: [c-n: m-c is baking for 1.9.1, c-c depends on it]
there was a significant Ts hit on Linux around the time this was checked in:

http://graphs.mozilla.org/graph.html#show=1431030,395123,395133,395164&sel=1228763058,1229025120

could this have been responsible?
Comment on attachment 350755 [details] [diff] [review]
mozilla-central patch v3
[Checkin: Comment 11 & 14]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/09ea61756b7a
Attachment #350755 - Attachment description: mozilla-central patch v3 [Checkin: Comment 11] → mozilla-central patch v3 [Checkin: Comment 11 & 14]
Keywords: fixed1.9.1
Whiteboard: [c-n: m-c is baking for 1.9.1, c-c depends on it] → [c-n: m-c part is baking on 1.9.1, before c-c part]
Target Milestone: --- → mozilla1.9.1b3
Comment on attachment 346956 [details] [diff] [review]
comm-central patch (needs the m-c patch checked in first!)
[Checkin: Comment 15]

http://hg.mozilla.org/comm-central/rev/1818c8fa024f
Attachment #346956 - Attachment description: comm-central patch (needs the m-c patch checked in first!) → comm-central patch (needs the m-c patch checked in first!) [Checkin: Comment 15]
Status: NEW → RESOLVED
Closed: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [c-n: m-c part is baking on 1.9.1, before c-c part]
You need to log in before you can comment on or make changes to this bug.