Closed Bug 463824 Opened 13 years ago Closed 13 years ago

Introduce GLOBAL_DEPS to build system


(Firefox Build System :: General, defect)

Not set


(Not tracked)



(Reporter: Callek, Assigned: Callek)



(Keywords: fixed1.9.1)


(1 file, 2 obsolete files)

Attached patch Introduce GLOBAL_DEPS (obsolete) — Splinter Review
We should introduce GLOBAL_DEPS to our build system, in order to have a consistent method to globally depend on files that should cause our entire source to rebuild.

This patch also introduces into the global deps.

Should we add $(topsrcdir)/config/ to the list as well?

This blocks SeaMonkey as we need to be able to globally depend on (we use a DEFINE there). Should we globally add (when it exists) or have each app that wants it simply add to GLOBAL_DEPS in itself?

* Did not touch gfx/cairo as it appears that is all from upstream and I'd rather not poke code I'm not too sure the rules on
* Did not touch js/ its my understanding that area of code is still fairly well regulated and even has its own independant config (due to tamarin). If you prefer I fix that up as well, I'll add it into either an iteration of this patch, or a new bug at your choice.
* Comm-central I'll do in its own bug.
Attachment #347072 - Flags: review?(ted.mielczarek)
Flags: wanted1.9.1?
ted any ETA on this review, it does block easy landing of a SM2 Blocker
Comment on attachment 347072 [details] [diff] [review]

+# Global Depends
+GLOBAL_DEPS += Makefile $(DEPTH)/config/

Could you make this comment slightly more informative?

Patch looks ok to me, sorry for the wait.
Attachment #347072 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 347072 [details] [diff] [review]

Probably worth waiting until after b2 to push this...

Ted, any suggestions as to a better comment? (feel free to ping the answer in IRC)
Attachment #347072 - Flags: approval1.9.1?
Attachment #347072 - Flags: approval1.9.1? → approval1.9.1+
Comment on attachment 347072 [details] [diff] [review]

Address comment as best as I can come up with, my c#0 Q's were not answered so I'll just file followup bugs on all them... (they should not block this anyway)
Attachment #347072 - Attachment is obsolete: true
Attachment #350335 - Flags: review+
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b3
I had to back this out.  The files in js/config need to be updated as well. (complete with wrong bug number in comment!)
Resolution: FIXED → ---
Actual patch for checkin, updated js/config/ did not touch anything else there.
Attachment #350335 - Attachment is obsolete: true
Attachment #350393 - Flags: review+
Comment on attachment 350393 [details] [diff] [review]
Introduce GLOBAL_DEPS [for checkin] [include js/]

Ok, I stupidly refreshed with -s (which doesn't look for new changed files)

Which turned tree orange again... so I just pushed the fix:

$ hg outgoing -v
running "ssh "hg -R mozilla-central/ serve --stdio""
comparing with ssh://
searching for changes
changeset:   22062:0e1de1e5e5b1
tag:         tip
user:        Justin Wood <>
date:        Thu Nov 27 21:58:44 2008 -0500
files:       js/src/config/
Bug 463824, Introduce GLOBAL_DEPS to build system
r=ted, a1.9.1=beltzner [js bits rs=sdwilsh]
(really include js bits this time, forgot to *not* use |hg qref -s|)

$ hg push
pushing to ssh://
searching for changes
remote: adding changesets
remote: adding manifests
remote: adding file changes
remote: added 1 changesets with 1 changes to 1 files
Closed: 13 years ago13 years ago
Resolution: --- → FIXED
Blocks: 467050
Blocks: 467051
Blocks: 467052
Comment on attachment 350393 [details] [diff] [review]
Introduce GLOBAL_DEPS [for checkin] [include js/]

>diff --git a/config/ b/config/
>+# Dependancies which, if modified, should cause everything to rebuild
>+GLOBAL_DEPS += Makefile $(DEPTH)/config/

Erm, isn't the word "Dependencies", with an "e" instead of an "a"?
Blocks: 474732
...patch landed before branch, removing wanted?
Flags: wanted1.9.1?
Keywords: fixed1.9.1
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.