461736 - Fix geolocation prompt in Fennec

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Doug Turner (:dougt)]

Recently 459893 change the way geolocation prompts worked.  We need to update the geolocation prompt work in fennec.

Comment 2

[Madhava Enros [:madhava]]

Attachment: interaction flow

Interaction flow for two cases -- when the device (mobile device, laptop, desktop computer) has some ability to know its location (whether by gps, cell-tower association, or known wifi locations), and one where the device just can't know (most likely in the case of a wired-ethernet desktop PC.  The latter case assumes that there's still a network connection, which seems reasonable, given that the user is doing something with the web.  We need the network connection so that fennec/firefox can turn the user-entered info into coordinates.

Comment 3

[Doug Turner (:dougt)]

madhava, do you have any new mockups based on our last discussion?

Comment 4

[Doug Turner (:dougt)]

Attachment: basic geolocation prompt (similar to FF)

Comment 5

[Doug Turner (:dougt)]

Attachment: patch v.1

actual patch to mobile-browser

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 362952 [details] [diff] [review]
patch v.1

>diff --git a/components/Makefile.in b/components/Makefile.in

> EXTRA_COMPONENTS = \
>     aboutFirstrun.js \
>+    geolocation-prompt.js \

Can we rename the file to geolocationPrompt.js (yes, I'm anal)

>diff --git a/components/geolocation-prompt.js b/components/geolocation-prompt.js

>+        label: browserBundle.GetStringFromName("geolocation.exactLocation"),
>+        accessKey: browserBundle.GetStringFromName("geolocation.exactLocationKey"),
>+        callback: function() request.allow() ,

Remove trailing comma

>+        label: browserBundle.GetStringFromName("geolocation.nothingLocation"),
>+        accessKey: browserBundle.GetStringFromName("geolocation.nothingLocationKey"),
>+        callback: function() request.cancel() ,

Remove trailing comma

>+      notificationBox.appendNotification(message,
>+                                         "geolocation",
>+                                         "chrome://browser/skin/Info.png",
>+                                         notificationBox.PRIORITY_INFO_HIGH,
>+                                         buttons);
>+    }
>+  },

Remove trailing comma

Comment 7

[Doug Turner (:dougt)]

patch v.1 was checked in:  a9713858b4ec

This provides us with a simple UI - similar to firefox - to manage geolocation requests.

Comment 8

[Doug Turner (:dougt)]

this is fixed.  new design of this prompt should be done in bug 463235 per madhava.

Comment 9

[Doug Turner (:dougt)]

Comment on attachment 362951 [details]
basic geolocation prompt (similar to FF)

clearing review flag

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

verified with beta3

Comment 11

[Aakash Desai [:aakashd]]

We have these testcases located in litmus. Ids are: 7651-7654