46175 - [SKINS] Mac Classic Skin: Icons in drop down/popup menus don't have enough space to the left

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect, P3)

Description

[Andrew Thompson]

Mozilla Build 2000072113

Drop down the Bookmarks menu in the personal toolbar.
The folder and shortcut icons do not have enough "white"space to the left of them

For comparison purposes, look at the Apple Menu's spacing, which is standard.

(for anyone wondering the gap exists so you can put a checkmark in the menu)

Comment 1

[Andrew Thompson]

Here's a patch to menu.css in the Classic Mac skin that fixes this problem, and 
also moves the menutext closer to the menu item. If you look at the bookmarks 
menu in the personal toolbar an compare the apple menu you'll see the icon and 
text are currently far to far apart. This corrects that problem as well as the 
original bug.

Apologies for the MPW Compare format of this patch. If you know a better tool for 
generating diffs on the Mac let me know!

File #1: menu.css
File #2: Macintosh HD:Desktop Folder:mozilla-mac-jul22-
M17:Chrome:skins:classic:global:skin:menu.css

Nonmatching lines (File "menu.css"; Line 105; File "Macintosh HD:Desktop 
Folder:mozilla-mac-jul22-M17:Chrome:skins:classic:global:skin:menu.css"; Line 
105)
 105	    margin                : 0px 9px 0px 1px;

 105	    margin                : 0px 4px 0px 1px;


Extra lines in 2nd before 109 in 1st (File "menu.css"; Line *109; File "Macintosh 
HD:Desktop Folder:mozilla-mac-jul22-
M17:Chrome:skins:classic:global:skin:menu.css"; Line 109)
 109	    padding-left: 20px;

Comment 2

[Andrew Thompson]

Attachment: Correct spacing for menuitems with icons

Comment 3

[Andrew Thompson]

Did some further tuning. Menu spacing in bookmark menu is now pixel perfect,
according to the Apple menu's spacing.

Attached menu.css

Comment 4

[Andrew Thompson]

Ugh - NAV4 refuses to show the file because I set the mimetype to text/css.

Use IE or download to disk. Apologies for spam...

Comment 5

[Andrew Thompson]

Please see also bug:
http://bugzilla.mozilla.org/show_bug.cgi?id=46231

The fix attached causes the checkboxes in the Sidebar->Add menu to become 
indented, which is wrong. I believe this is because of the issue I discuss in the 
above bug.

Comment 6

[Nikhil Bhatla (gone)]

assigning to me

Comment 7

[Nikhil Bhatla (gone)]

This bug cannot be fully resolved until XUL is fixed to allow images and 
checkmarks on a single menuitem.  Marking dependent on 46231.

Comment 8

[Andrew Thompson]

I added a workaround to menu.css that special cases menuitem type="checkbox" and 
menuitem type="radio" to not have the extra indent. The results look pretty good.

This is purely a workaround - as we know a proper fix needs 46231 to be fixed.

Improved fix is attached.

Comment 9

[Andrew Thompson]

Attachment: Improced fix for popup menu indenting on Mac. Works around checkboxes problem.

Comment 10

[Nikhil Bhatla (gone)]

That patch looked real good.  Thanks.

Comment 11

[Andrew Thompson]

Please see bug 39332.
The bookmarks on the personal toolbar is gone. Good. It was unnecessary.
However this patch still corrects issues with any XPToolkit generated popup menu 
in Mozilla on the Mac, so its still useful, so I changed the summary. 

(The menus in the menubar currently aren't effected but who knows what will 
happen on MacOS X?)

Comment 12

[Nikhil Bhatla (gone)]

Finally checked in the patch.

Comment 13

[Nikhil Bhatla (gone)]

Since bug #46231 has been futured, I'm resolving this bug to "remind", so 
that after #46231 is fixed the patch can be removed.

Comment 14

[Paul Wyskoczka]

Updated QA contact

Comment 15

[Patty Mac]

Hi lordpixel,

Mac (Build: 2000-09-05-08-M18):
I don't see the Bookmarks menu in the personal toolbar when the 
folder and shortcut icons do not have enough "white"space to the left of them.
Can you explain a little bit details on this bug so that I could verify it?
However, I do see the folder and shortcut icons on the Linux and windows.

                                                                               
                                                                             

Comment 16

[Andrew Thompson]

Please don't verify this. Its left as Resolve Remind to remind us to remove the 
patch we implemented to workaround bug 46231. When that's fixed, we should remove 
the patch that is currently making this look acceptable.

BTW - to see the bookmarks menu in the sidebar, go to the Navigator preferences 
and select the bookmarks checkbox from the scrolling list. Or, just add a folder 
with some bookmarks in it to your personal toolbar. The spacing should now look 
correct. Before, there basically was almost no spacing on the left at all.

Comment 17

[Patty Mac]

marking verified

Comment 18

[Patty Mac]

Just accidently enter to the wrong bug report.

Comment 19

[Patty Mac]

Just change the resolution to "Remind".

Comment 20

[Christopher Hoess (gone)]

REMIND is deprecated per bug 35839. Please find another solution, such as
setting milestone to future.

Comment 21

[Andrew Thompson]

Well, I just looked at 2003031217 and the gap is still too small.
So I guess this should be open

Comment 22

[Samuel Sidler (old account; do not CC)]

Is this really still a problem? We don't use icons in the drop down menus as 
far as I can tell (on OS X).

If it is still a problem, can the attached fix be used?

Comment 23

[Stefan [:stefanh]]

(In reply to comment #22)
> Is this really still a problem? We don't use icons in the drop down menus as 
> far as I can tell (on OS X).

It's still a problem, just open the bookmarks menupopup at the personal toolbar
and you'll see it.
> 
> If it is still a problem, can the attached fix be used?

The attached fix seems to depend on another bug, unfortunately.

Comment 24

[Stefan [:stefanh]]

I will probably fix this in bug 301105.

Comment 25

[Stefan [:stefanh]]

I'm resolving this as fixed - the patch in bug 301105 took care of this. Icons in menupopups now have correct amount of space to the left (except for icons in menulists)