Error console should be cleared when leaving the private browsing mode

VERIFIED FIXED in Firefox 3.1b2

Status

()

Firefox
Private Browsing
VERIFIED FIXED
9 years ago
9 years ago

People

(Reporter: Away for a while, Assigned: Away for a while)

Tracking

({privacy})

Trunk
Firefox 3.1b2
privacy
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
Based on email conversation with mconnor, we need to clear the error console when leaving the private browsing mode.

Patch forthcoming.
(Assignee)

Comment 1

9 years ago
Created attachment 344970 [details] [diff] [review]
Patch (v1)

Patch plus a browser chrome test.
Attachment #344970 - Flags: review?(mconnor)
Comment on attachment 344970 [details] [diff] [review]
Patch (v1)

this is the wrong place to call this.  This would get called once for every window that's open, which doesn't make a lot of sense to me...

you should just call it in  _onPrivateBrowsingModeChanged right before we restore the previous session
Attachment #344970 - Flags: review?(mconnor) → review-
(Assignee)

Comment 3

9 years ago
Created attachment 345460 [details] [diff] [review]
Patch (v1.1)

You're right.  I moved the code to the private browsing service, and updated the unit test to use the pref in this patch.
Attachment #344970 - Attachment is obsolete: true
Attachment #345460 - Flags: review?(mconnor)

Updated

9 years ago
Attachment #345460 - Flags: review?(mconnor) → review+
Comment on attachment 345460 [details] [diff] [review]
Patch (v1.1)

Please use an nsITimer, not a setTimeout, for unit tests.  setTimeout is... flaky, see sdwilsh since he's the de facto "guy to talk to about not using setTimeout"
(Assignee)

Comment 5

9 years ago
Created attachment 345800 [details] [diff] [review]
Patch (v1.2)

Updated the patch to use nsITimer inside the unit test.
Attachment #345460 - Attachment is obsolete: true
Attachment #345800 - Flags: review+
Flags: in-litmus?
(Assignee)

Comment 6

9 years ago
Marcia: please note that the patch includes an automated test.  I'm not sure how useful a Litmus test can be here, because what this bug tries to cover is relatively a small issue which is easy to test automatically...

Anyway, I'm not clearing in-litmus? for now...
Flags: in-testsuite?
(Assignee)

Updated

9 years ago
Whiteboard: [pb-ready-for-landing]
(Assignee)

Comment 7

9 years ago
http://hg.mozilla.org/mozilla-central/rev/45a3004bee68
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite? → in-testsuite+
Resolution: --- → FIXED
Whiteboard: [pb-ready-for-landing]
Target Milestone: --- → Firefox 3.1b2
Ehsan: I am noticing when testing today's build that the error console does not clear when I switch out of Private Browsing mode. My STR are:

1. Have a regular session going. Console errors appear.
2. Switch to PB mode. Console errors still there.
3. Switch out of PB mode. Console error still there.

I am not sure if you intend to clear the whole console or just any errors that are logged in the PB session.
(Assignee)

Comment 9

9 years ago
(In reply to comment #8)
> Ehsan: I am noticing when testing today's build that the error console does not
> clear when I switch out of Private Browsing mode. My STR are:
> 
> 1. Have a regular session going. Console errors appear.
> 2. Switch to PB mode. Console errors still there.
> 3. Switch out of PB mode. Console error still there.

Oh, that's weird.  Can I ask what platform are you on?  Also, what happens if you close and re-open the console?  What if you manually clear the console?

> I am not sure if you intend to clear the whole console or just any errors that
> are logged in the PB session.

No, the whole console should be cleared (including errors logged both during and before the PB mode).
https://litmus.mozilla.org/show_test.cgi?id=7396 added to Litmus FFT. Even though we have an automated test for this, I have been seeing a little flakiness here (see Comment 8), so it won't hurt to have a manual test for this as well.
Flags: in-litmus? → in-litmus+
(Assignee)

Updated

9 years ago
Depends on: 464918
verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre and  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre
Status: RESOLVED → VERIFIED
(Assignee)

Comment 12

9 years ago
Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.
Component: General → Private Browsing
(Assignee)

Updated

9 years ago
QA Contact: general → private.browsing
You need to log in before you can comment on or make changes to this bug.