461755 - Error console should be cleared when leaving the private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

Based on email conversation with mconnor, we need to clear the error console when leaving the private browsing mode.

Patch forthcoming.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

Patch plus a browser chrome test.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 344970 [details] [diff] [review]
Patch (v1)

this is the wrong place to call this.  This would get called once for every window that's open, which doesn't make a lot of sense to me...

you should just call it in  _onPrivateBrowsingModeChanged right before we restore the previous session

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

You're right.  I moved the code to the private browsing service, and updated the unit test to use the pref in this patch.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 345460 [details] [diff] [review]
Patch (v1.1)

Please use an nsITimer, not a setTimeout, for unit tests.  setTimeout is... flaky, see sdwilsh since he's the de facto "guy to talk to about not using setTimeout"

Comment 5

[(no longer active)]

Attachment: Patch (v1.2)

Updated the patch to use nsITimer inside the unit test.

Comment 6

[(no longer active)]

Marcia: please note that the patch includes an automated test.  I'm not sure how useful a Litmus test can be here, because what this bug tries to cover is relatively a small issue which is easy to test automatically...

Anyway, I'm not clearing in-litmus? for now...

Comment 7

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/45a3004bee68

Comment 8

[Marcia Knous [:marcia]]

Ehsan: I am noticing when testing today's build that the error console does not clear when I switch out of Private Browsing mode. My STR are:

1. Have a regular session going. Console errors appear.
2. Switch to PB mode. Console errors still there.
3. Switch out of PB mode. Console error still there.

I am not sure if you intend to clear the whole console or just any errors that are logged in the PB session.

Comment 9

[(no longer active)]

(In reply to comment #8)
> Ehsan: I am noticing when testing today's build that the error console does not
> clear when I switch out of Private Browsing mode. My STR are:
> 
> 1. Have a regular session going. Console errors appear.
> 2. Switch to PB mode. Console errors still there.
> 3. Switch out of PB mode. Console error still there.

Oh, that's weird.  Can I ask what platform are you on?  Also, what happens if you close and re-open the console?  What if you manually clear the console?

> I am not sure if you intend to clear the whole console or just any errors that
> are logged in the PB session.

No, the whole console should be cleared (including errors logged both during and before the PB mode).

Comment 10

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=7396 added to Litmus FFT. Even though we have an automated test for this, I have been seeing a little flakiness here (see Comment 8), so it won't hurt to have a manual test for this as well.

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre and  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081118 Minefield/3.1b2pre

Comment 12

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.