464918 - Console clearing test for private browsing should not use a timeout

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

We can do better in the console clearing test for the private browsing service, and make it not use a timeout.  The reason we needed the timeout previously was that console listeners are async proxy objects, so the listener object was not notified on time for us to test this serially.

My solution here is to log a special "exit" message on the console at the end of the test, so that the listener can pick it up and do the final checks then and finish the test.

This will hopefully help the test suite to run a tiny bit faster.  :-)

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 348185 [details] [diff] [review]
Patch (v1)

a191=beltzner

Comment 2

[(no longer active)]

Attachment: mq patch for check-in

Comment 3

[(no longer active)]

Attachment: mq patch for check-in

Comment 4

[Shawn Wilsher :sdwilsh]

http://hg.mozilla.org/mozilla-central/rev/b6f450bbbcd8

Comment 5

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.