Console clearing test for private browsing should not use a timeout

RESOLVED FIXED in Firefox 3.1b3

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

({fixed1.9.1})

Trunk
Firefox 3.1b3
fixed1.9.1
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

10 years ago
Created attachment 348185 [details] [diff] [review]
Patch (v1)

We can do better in the console clearing test for the private browsing service, and make it not use a timeout.  The reason we needed the timeout previously was that console listeners are async proxy objects, so the listener object was not notified on time for us to test this serially.

My solution here is to log a special "exit" message on the console at the end of the test, so that the listener can pick it up and do the final checks then and finish the test.

This will hopefully help the test suite to run a tiny bit faster.  :-)
Attachment #348185 - Flags: review?(mconnor)

Updated

10 years ago
Attachment #348185 - Flags: review?(mconnor) → review+
(Assignee)

Updated

10 years ago
Attachment #348185 - Flags: approval1.9.1?
Comment on attachment 348185 [details] [diff] [review]
Patch (v1)

a191=beltzner
Attachment #348185 - Flags: approval1.9.1? → approval1.9.1+
(Assignee)

Comment 2

10 years ago
Created attachment 350513 [details] [diff] [review]
mq patch for check-in
(Assignee)

Comment 3

10 years ago
Created attachment 350516 [details] [diff] [review]
mq patch for check-in
Attachment #350513 - Attachment is obsolete: true
http://hg.mozilla.org/mozilla-central/rev/b6f450bbbcd8
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3
(Assignee)

Comment 5

10 years ago
Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.
Component: General → Private Browsing
(Assignee)

Updated

10 years ago
QA Contact: general → private.browsing

Updated

10 years ago
Keywords: fixed1.9.1
You need to log in before you can comment on or make changes to this bug.