Created attachment 348185 [details] [diff] [review] Patch (v1) We can do better in the console clearing test for the private browsing service, and make it not use a timeout. The reason we needed the timeout previously was that console listeners are async proxy objects, so the listener object was not notified on time for us to test this serially. My solution here is to log a special "exit" message on the console at the end of the test, so that the listener can pick it up and do the final checks then and finish the test. This will hopefully help the test suite to run a tiny bit faster. :-)
Attachment #348185 - Flags: review?(mconnor)
Attachment #348185 - Flags: review?(mconnor) → review+
Comment on attachment 348185 [details] [diff] [review] Patch (v1) a191=beltzner
Attachment #348185 - Flags: approval1.9.1? → approval1.9.1+
Created attachment 350516 [details] [diff] [review] mq patch for check-in
Attachment #350513 - Attachment is obsolete: true
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.1b3
Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.
Component: General → Private Browsing
You need to log in before you can comment on or make changes to this bug.