461826 - .ics attachments from Thunderbird/Lightning not compatible with iCal

Status: VERIFIED FIXED

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Description

[berto]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.3) Gecko/2008092414 Firefox/3.0.3
Build Identifier: Unsure

When I receive an .ics file from someone using Thunderbird/Lightning, the attachment is not imported by iCal.  I've determined the problem has to do with the first line in .ics file being blank.  Once the blank line is removed, iCal is able to use the file without problems.

Is this blank line at the top of the .ics file erroneous?

Thanks!

Reproducible: Always

Steps to Reproduce:
1. Receive an email with a .ics file from a Thunderbird/Lightning client
2. Click on it in Mail.app (OS X 10.5.5)
3. Watch iCal tell you this file is corrupt.
4. Save the file to the desktop
5. With an editor open up the file and remove the first line, which is blank
6. Click on the file and watch iCal happily use it.
Actual Results:  
.ics file needs manual editing before iCal can use it.

Expected Results:  
.ics file should be usable with no manual editing.  My guess is that this blank line is erroneous and should not be there to begin with.

Comment 1

[Daniel Boelzle [:dbo]]

WFM. There is no LF at the beginning and iCal correctly import the invitation (invite.ics); tested on Leopard's Mail.app/iCal.

Comment 2

[berto]

Thanks for the update.  Here is some more information.  Here's the software in question on my end:

Thunderbird: 2.0.0.17
Lightning: 0.9

I'm also going to add an attachment with the raw mail message.  You can see that there are two blank lines between the mail headers and the .ics body.

Daniel, is your Thunderbird sending an inline attachment, or is it encoding it; as you can see, it's inline over here.  Maybe there is a setting in Thunderbird for this?

Thanks.

Comment 3

[berto]

Attachment: email with blank line in .ics attachment.

Here is a mail message with a calendar invitation.  It contains two blank lines between the mail headers and the .ics body.  The second of these new lines is being interpreted as the first line of the .ics file.

Comment 4

[Daniel Boelzle [:dbo]]

Ok, I see you are sending with Outlook 200 compat mode. I can reproduce it now, taking the bug.

Comment 5

[Daniel Boelzle [:dbo]]

Attachment: fix

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 345163 [details] [diff] [review]
fix

r=philipp

Comment 7

[Daniel Boelzle [:dbo]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/b057a77bb9e3>

-> FIXED

Comment 9

[Andreas Treumann]

Checked with lightning build 20081030062620 -> VERIFIED.