Closed Bug 462438 Opened 15 years ago Closed 15 years ago

kill MOZ_PROFILESHARING and MOZ_IPCD

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.1b3

People

(Reporter: Swatinem, Assigned: Swatinem)

References

(
URL
)

Details

(Keywords: fixed1.9.1)

Attachments

(6 files, 4 obsolete files)

toolkit cleanup [Checkin: Comment 19 & 25]
819 bytes, patch
benjamin
: review+
benjamin
: superreview+
Details | Diff | Splinter Review
profile cleanup [Checkin: Comment 20 & 26]
2.32 KB, patch
benjamin
: review+
benjamin
: superreview+
Details | Diff | Splinter Review
comm-central cleanup [Checkin: Comment 18]
2.32 KB, patch
kairo
: review+
Details | Diff | Splinter Review
embedding cleanup, v2 [Checkin: Comment 21 & 27]
1.08 KB, patch
Swatinem
: review+
Swatinem
: superreview+
Details | Diff | Splinter Review
libpref cleanup, v3 [Checkin: Comment 22 & 28]
8.88 KB, patch
benjamin
: review+
benjamin
: superreview+
Details | Diff | Splinter Review
build system cleanup + removes, v2 [Checkin: Comment 24 & 29]
639.48 KB, patch
Swatinem
: review+
Swatinem
: superreview+
beltzner
: approval1.9.1+
beltzner
: approval1.9.1b2-
Details | Diff | Splinter Review 
I came across MOZ_PROFILESHARING when working on killing MOZ_XUL_APP. It seems that it has been dead for a long time.
As per irc:
<bsmedberg>	moz_profilesharing is now a defunct variable, I'm pretty sure
<bsmedberg>	in any case, profile sharing should now never be one
<bsmedberg>	on
<Swatinem>	so moz_profilesharing is dead now?
<bsmedberg>	I hope so
MOZ_IPCD is only enabled when MOZ_PROFILESHARING is. So that flag can go too. http://mxr.mozilla.org/comm-central/search?string=MOZ_IPCD&case=on
Summary: kill MOZ_PROFILESHARING → kill MOZ_PROFILESHARING and MOZ_IPCD

        Attachment #345690 -
        Flags: superreview?(benjamin)

        Attachment #345690 -
        Flags: review?(benjamin)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        embedding cleanup (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #345691 -
        Flags: superreview?(benjamin)

        Attachment #345691 -
        Flags: review?(benjamin)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        libpref cleanup (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #345692 -
        Flags: superreview?(benjamin)

        Attachment #345692 -
        Flags: review?(benjamin)

    
    

    
  


  
Sorry for the review spam benjamin :/
I should have checked first that you are the peer for most of those modules.

        Attachment #345693 -
        Flags: superreview?(benjamin)

        Attachment #345693 -
        Flags: review?(benjamin)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        build system cleanup + removes (obsolete)
        — 
          — Splinter Review
      

    


  
This patch also includes the removes for now unused files/directories.

        Attachment #345694 -
        Flags: superreview?(ted.mielczarek)

        Attachment #345694 -
        Flags: review?(ted.mielczarek)

    
    

    
  


  
This patch removes the flags from comm-centrals configure system.

        Attachment #345695 -
        Flags: superreview?(kairo)

        Attachment #345695 -
        Flags: review?(kairo)

    
  

        Attachment #345695 -
        Flags: superreview?(kairo)

        Attachment #345695 -
        Flags: review?(kairo)

        Attachment #345695 -
        Flags: review+

    
  

        Attachment #345690 -
        Flags: superreview?(benjamin)

        Attachment #345690 -
        Flags: superreview+

        Attachment #345690 -
        Flags: review?(benjamin)

        Attachment #345690 -
        Flags: review+

    
    

    
  
Comment on attachment 345691 [details] [diff] [review]
embedding cleanup

Please skip the .pkg changes, they are obsolete files going to be removed anyway.

        Attachment #345691 -
        Flags: superreview?(benjamin)

        Attachment #345691 -
        Flags: superreview+

        Attachment #345691 -
        Flags: review?(benjamin)

        Attachment #345691 -
        Flags: review+

    
    

    
  
Comment on attachment 345692 [details] [diff] [review]
libpref cleanup

Please remove the related code: nsIProfileSharingSetup.idl and nsSharedPrefHandler.{h,cpp}

        Attachment #345692 -
        Flags: superreview?(benjamin)

        Attachment #345692 -
        Flags: review?(benjamin)

        Attachment #345692 -
        Flags: review-

    
  

        Attachment #345693 -
        Flags: superreview?(benjamin)

        Attachment #345693 -
        Flags: superreview+

        Attachment #345693 -
        Flags: review?(benjamin)

        Attachment #345693 -
        Flags: review+

    
  

        Attachment #345694 -
        Flags: superreview?(ted.mielczarek)

        Attachment #345694 -
        Flags: superreview+

        Attachment #345694 -
        Flags: review?(ted.mielczarek)

        Attachment #345694 -
        Flags: review+

    
  
Depends on: 461888

    
    

    
  


  
(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

done. r/sr+ as per comment #8.

        Attachment #345691 -
        Attachment is obsolete: true

        Attachment #346101 -
        Flags: superreview+

        Attachment #346101 -
        Flags: review+

    
    

    
  
(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

Do we have a bug for that removal? I think it would be a good idea to finally go ahead and really do it ;-)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        libpref cleanup, v2 (obsolete)
        — 
          — Splinter Review
      

    


  
(In reply to comment #9)
> (From update of attachment 345692 [details] [diff] [review])
> Please remove the related code: nsIProfileSharingSetup.idl and
> nsSharedPrefHandler.{h,cpp}

Those files are removed in the "build system + removals" patch.
I fixed a "friend" declaration I missed the first time.

        Attachment #345692 -
        Attachment is obsolete: true

        Attachment #346105 -
        Flags: superreview?(benjamin)

        Attachment #346105 -
        Flags: review?(benjamin)

    
    

    
  
(In reply to comment #11)
> (In reply to comment #8)
> > (From update of attachment 345691 [details] [diff] [review] [details])
> > Please skip the .pkg changes, they are obsolete files going to be removed
> > anyway.
> 
> Do we have a bug for that removal? I think it would be a good idea to finally
> go ahead and really do it ;-)

Thats bug #461888, I've added it to the dependencies. The patch there got review just today.

    
    

    
  


  
updated to tip. This patch also included a .pkg file change.

        Attachment #346105 -
        Attachment is obsolete: true

        Attachment #346219 -
        Flags: superreview?(benjamin)

        Attachment #346219 -
        Flags: review?(benjamin)

        Attachment #346105 -
        Flags: superreview?(benjamin)

        Attachment #346105 -
        Flags: review?(benjamin)

    
    

    
  


  
updated to tip. r/sr+ as per attachment #345694 [details] [diff] [review].

        Attachment #345694 -
        Attachment is obsolete: true

        Attachment #346221 -
        Flags: superreview+

        Attachment #346221 -
        Flags: review+

    
  

        Attachment #346219 -
        Flags: superreview?(benjamin)

        Attachment #346219 -
        Flags: superreview+

        Attachment #346219 -
        Flags: review?(benjamin)

        Attachment #346219 -
        Flags: review+

    
  
Keywords: checkin-needed

    
  

        Attachment #346221 -
        Flags: approval1.9.1b2?

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

This can wait until after beta to go in.

        Attachment #346221 -
        Flags: approval1.9.1b2? → approval1.9.1b2-

    
    

    
  
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

a191=beltzner

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 345695 [details] [diff] [review]
comm-central cleanup
[Checkin: Comment 18]

http://hg.mozilla.org/comm-central/rev/c1438af8484b

        Attachment #345695 -
        Attachment description: comm-central cleanup → comm-central cleanup
[Checkin: Comment 18]

    
    

    
  
Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/mozilla-central/rev/6d544c7476dd

        Attachment #345690 -
        Attachment description: toolkit cleanup → toolkit cleanup
[Checkin: Comment 19]

    
    

    
  
Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/mozilla-central/rev/2f6c27da8df3

        Attachment #345693 -
        Attachment description: profile cleanup → profile cleanup
[Checkin: Comment 20]

        Attachment #346101 -
        Attachment description: embedding cleanup, v2 → embedding cleanup, v2
[Checkin: Comment 21]

    
    

    
  
Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/mozilla-central/rev/e6091173285a

        Attachment #346219 -
        Attachment description: libpref cleanup, v3 → libpref cleanup, v3
[Checkin: Comment 22]

    
    

    
  
(In reply to comment #22)
> http://hg.mozilla.org/mozilla-central/rev/e6091173285a

Ftr, this was after fixing "new context" for
{
patching file modules/libpref/src/prefapi.cpp
Hunk #3 FAILED at 760
1 out of 3 hunks FAILED
}

    
    

    
  
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/mozilla-central/rev/d8759394226c

        Attachment #346221 -
        Attachment description: build system cleanup + removes, v2 → build system cleanup + removes, v2
[Checkin: Comment 24]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [c-n: baking for m-c 1.9.1 (except c-c patch)]
Target Milestone: --- → mozilla1.9.2a1

    
    

    
  
Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/53f16cb8dc6d

        Attachment #345690 -
        Attachment description: toolkit cleanup
[Checkin: Comment 19] → toolkit cleanup
[Checkin: Comment 19 & 25]

    
    

    
  
Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f86913603e25

        Attachment #345693 -
        Attachment description: profile cleanup
[Checkin: Comment 20] → profile cleanup
[Checkin: Comment 20 & 26]

    
    

    
  
Comment on attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9db51756ca48

        Attachment #346101 -
        Attachment description: embedding cleanup, v2
[Checkin: Comment 21] → embedding cleanup, v2
[Checkin: Comment 21 & 27]

    
    

    
  
Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/56aa85cdead5

        Attachment #346219 -
        Attachment description: libpref cleanup, v3
[Checkin: Comment 22] → libpref cleanup, v3
[Checkin: Comment 22 & 28]

    
    

    
  
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/264c64559092

        Attachment #346221 -
        Attachment description: build system cleanup + removes, v2
[Checkin: Comment 24] → build system cleanup + removes, v2
[Checkin: Comment 24 & 29]
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [c-n: baking for m-c 1.9.1 (except c-c patch)]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3

          You need to log in
          before you can comment on or make changes to this bug.