kill MOZ_PROFILESHARING and MOZ_IPCD

RESOLVED FIXED in mozilla1.9.1b3

Status

()

Core
General
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Swatinem, Assigned: Swatinem)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.1b3
x86
Linux
fixed1.9.1
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(6 attachments, 4 obsolete attachments)

819 bytes, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: superreview+
Details | Diff | Splinter Review
2.32 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: superreview+
Details | Diff | Splinter Review
2.32 KB, patch
Robert Kaiser
: review+
Details | Diff | Splinter Review
1.08 KB, patch
Swatinem
: review+
Swatinem
: superreview+
Details | Diff | Splinter Review
8.88 KB, patch
Benjamin Smedberg
: review+
Benjamin Smedberg
: superreview+
Details | Diff | Splinter Review
639.48 KB, patch
Swatinem
: review+
Swatinem
: superreview+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review
(Assignee)

Description

9 years ago
I came across MOZ_PROFILESHARING when working on killing MOZ_XUL_APP. It seems that it has been dead for a long time.
As per irc:
<bsmedberg>	moz_profilesharing is now a defunct variable, I'm pretty sure
<bsmedberg>	in any case, profile sharing should now never be one
<bsmedberg>	on
<Swatinem>	so moz_profilesharing is dead now?
<bsmedberg>	I hope so
(Assignee)

Updated

9 years ago
(Assignee)

Comment 1

9 years ago
MOZ_IPCD is only enabled when MOZ_PROFILESHARING is. So that flag can go too. http://mxr.mozilla.org/comm-central/search?string=MOZ_IPCD&case=on
Summary: kill MOZ_PROFILESHARING → kill MOZ_PROFILESHARING and MOZ_IPCD
(Assignee)

Comment 2

9 years ago
Created attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]
Attachment #345690 - Flags: superreview?(benjamin)
Attachment #345690 - Flags: review?(benjamin)
(Assignee)

Comment 3

9 years ago
Created attachment 345691 [details] [diff] [review]
embedding cleanup
Attachment #345691 - Flags: superreview?(benjamin)
Attachment #345691 - Flags: review?(benjamin)
(Assignee)

Comment 4

9 years ago
Created attachment 345692 [details] [diff] [review]
libpref cleanup
Attachment #345692 - Flags: superreview?(benjamin)
Attachment #345692 - Flags: review?(benjamin)
(Assignee)

Comment 5

9 years ago
Created attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

Sorry for the review spam benjamin :/
I should have checked first that you are the peer for most of those modules.
Attachment #345693 - Flags: superreview?(benjamin)
Attachment #345693 - Flags: review?(benjamin)
(Assignee)

Comment 6

9 years ago
Created attachment 345694 [details] [diff] [review]
build system cleanup + removes

This patch also includes the removes for now unused files/directories.
Attachment #345694 - Flags: superreview?(ted.mielczarek)
Attachment #345694 - Flags: review?(ted.mielczarek)
(Assignee)

Comment 7

9 years ago
Created attachment 345695 [details] [diff] [review]
comm-central cleanup
[Checkin: Comment 18]

This patch removes the flags from comm-centrals configure system.
Attachment #345695 - Flags: superreview?(kairo)
Attachment #345695 - Flags: review?(kairo)

Updated

9 years ago
Attachment #345695 - Flags: superreview?(kairo)
Attachment #345695 - Flags: review?(kairo)
Attachment #345695 - Flags: review+

Updated

9 years ago
Attachment #345690 - Flags: superreview?(benjamin)
Attachment #345690 - Flags: superreview+
Attachment #345690 - Flags: review?(benjamin)
Attachment #345690 - Flags: review+

Comment 8

9 years ago
Comment on attachment 345691 [details] [diff] [review]
embedding cleanup

Please skip the .pkg changes, they are obsolete files going to be removed anyway.
Attachment #345691 - Flags: superreview?(benjamin)
Attachment #345691 - Flags: superreview+
Attachment #345691 - Flags: review?(benjamin)
Attachment #345691 - Flags: review+

Comment 9

9 years ago
Comment on attachment 345692 [details] [diff] [review]
libpref cleanup

Please remove the related code: nsIProfileSharingSetup.idl and nsSharedPrefHandler.{h,cpp}
Attachment #345692 - Flags: superreview?(benjamin)
Attachment #345692 - Flags: review?(benjamin)
Attachment #345692 - Flags: review-

Updated

9 years ago
Attachment #345693 - Flags: superreview?(benjamin)
Attachment #345693 - Flags: superreview+
Attachment #345693 - Flags: review?(benjamin)
Attachment #345693 - Flags: review+

Updated

9 years ago
Attachment #345694 - Flags: superreview?(ted.mielczarek)
Attachment #345694 - Flags: superreview+
Attachment #345694 - Flags: review?(ted.mielczarek)
Attachment #345694 - Flags: review+
(Assignee)

Updated

9 years ago
Depends on: 461888
(Assignee)

Comment 10

9 years ago
Created attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

done. r/sr+ as per comment #8.
Attachment #345691 - Attachment is obsolete: true
Attachment #346101 - Flags: superreview+
Attachment #346101 - Flags: review+

Comment 11

9 years ago
(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

Do we have a bug for that removal? I think it would be a good idea to finally go ahead and really do it ;-)
(Assignee)

Comment 12

9 years ago
Created attachment 346105 [details] [diff] [review]
libpref cleanup, v2

(In reply to comment #9)
> (From update of attachment 345692 [details] [diff] [review])
> Please remove the related code: nsIProfileSharingSetup.idl and
> nsSharedPrefHandler.{h,cpp}

Those files are removed in the "build system + removals" patch.
I fixed a "friend" declaration I missed the first time.
Attachment #345692 - Attachment is obsolete: true
Attachment #346105 - Flags: superreview?(benjamin)
Attachment #346105 - Flags: review?(benjamin)
(Assignee)

Comment 13

9 years ago
(In reply to comment #11)
> (In reply to comment #8)
> > (From update of attachment 345691 [details] [diff] [review] [details])
> > Please skip the .pkg changes, they are obsolete files going to be removed
> > anyway.
> 
> Do we have a bug for that removal? I think it would be a good idea to finally
> go ahead and really do it ;-)

Thats bug #461888, I've added it to the dependencies. The patch there got review just today.
(Assignee)

Comment 14

9 years ago
Created attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

updated to tip. This patch also included a .pkg file change.
Attachment #346105 - Attachment is obsolete: true
Attachment #346219 - Flags: superreview?(benjamin)
Attachment #346219 - Flags: review?(benjamin)
Attachment #346105 - Flags: superreview?(benjamin)
Attachment #346105 - Flags: review?(benjamin)
(Assignee)

Comment 15

9 years ago
Created attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

updated to tip. r/sr+ as per attachment #345694 [details] [diff] [review].
Attachment #345694 - Attachment is obsolete: true
Attachment #346221 - Flags: superreview+
Attachment #346221 - Flags: review+

Updated

9 years ago
Attachment #346219 - Flags: superreview?(benjamin)
Attachment #346219 - Flags: superreview+
Attachment #346219 - Flags: review?(benjamin)
Attachment #346219 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed

Updated

9 years ago
Attachment #346221 - Flags: approval1.9.1b2?

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

This can wait until after beta to go in.
Attachment #346221 - Flags: approval1.9.1b2? → approval1.9.1b2-
Attachment #346221 - Flags: approval1.9.1+
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

a191=beltzner
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
Comment on attachment 345695 [details] [diff] [review]
comm-central cleanup
[Checkin: Comment 18]

http://hg.mozilla.org/comm-central/rev/c1438af8484b
Attachment #345695 - Attachment description: comm-central cleanup → comm-central cleanup [Checkin: Comment 18]
Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/mozilla-central/rev/6d544c7476dd
Attachment #345690 - Attachment description: toolkit cleanup → toolkit cleanup [Checkin: Comment 19]
Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/mozilla-central/rev/2f6c27da8df3
Attachment #345693 - Attachment description: profile cleanup → profile cleanup [Checkin: Comment 20]
Attachment #346101 - Attachment description: embedding cleanup, v2 → embedding cleanup, v2 [Checkin: Comment 21]
Comment on attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

http://hg.mozilla.org/mozilla-central/rev/dad669d8d557
Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/mozilla-central/rev/e6091173285a
Attachment #346219 - Attachment description: libpref cleanup, v3 → libpref cleanup, v3 [Checkin: Comment 22]
(In reply to comment #22)
> http://hg.mozilla.org/mozilla-central/rev/e6091173285a

Ftr, this was after fixing "new context" for
{
patching file modules/libpref/src/prefapi.cpp
Hunk #3 FAILED at 760
1 out of 3 hunks FAILED
}
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/mozilla-central/rev/d8759394226c
Attachment #346221 - Attachment description: build system cleanup + removes, v2 → build system cleanup + removes, v2 [Checkin: Comment 24]
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [c-n: baking for m-c 1.9.1 (except c-c patch)]
Target Milestone: --- → mozilla1.9.2a1
Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/53f16cb8dc6d
Attachment #345690 - Attachment description: toolkit cleanup [Checkin: Comment 19] → toolkit cleanup [Checkin: Comment 19 & 25]
Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f86913603e25
Attachment #345693 - Attachment description: profile cleanup [Checkin: Comment 20] → profile cleanup [Checkin: Comment 20 & 26]
Comment on attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9db51756ca48
Attachment #346101 - Attachment description: embedding cleanup, v2 [Checkin: Comment 21] → embedding cleanup, v2 [Checkin: Comment 21 & 27]
Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/56aa85cdead5
Attachment #346219 - Attachment description: libpref cleanup, v3 [Checkin: Comment 22] → libpref cleanup, v3 [Checkin: Comment 22 & 28]
Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/264c64559092
Attachment #346221 - Attachment description: build system cleanup + removes, v2 [Checkin: Comment 24] → build system cleanup + removes, v2 [Checkin: Comment 24 & 29]
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [c-n: baking for m-c 1.9.1 (except c-c patch)]
Target Milestone: mozilla1.9.2a1 → mozilla1.9.1b3
You need to log in before you can comment on or make changes to this bug.