462438 - kill MOZ_PROFILESHARING and MOZ_IPCD

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[Arpad Borsos [:Swatinem]]

I came across MOZ_PROFILESHARING when working on killing MOZ_XUL_APP. It seems that it has been dead for a long time.
As per irc:
<bsmedberg>	moz_profilesharing is now a defunct variable, I'm pretty sure
<bsmedberg>	in any case, profile sharing should now never be one
<bsmedberg>	on
<Swatinem>	so moz_profilesharing is dead now?
<bsmedberg>	I hope so

Comment 1

[Arpad Borsos [:Swatinem]]

MOZ_IPCD is only enabled when MOZ_PROFILESHARING is. So that flag can go too. http://mxr.mozilla.org/comm-central/search?string=MOZ_IPCD&case=on

Comment 2

[Arpad Borsos [:Swatinem]]

Attachment: toolkit cleanup [Checkin: Comment 19 & 25]

Comment 3

[Arpad Borsos [:Swatinem]]

Attachment: embedding cleanup

Comment 4

[Arpad Borsos [:Swatinem]]

Attachment: libpref cleanup

Comment 5

[Arpad Borsos [:Swatinem]]

Attachment: profile cleanup [Checkin: Comment 20 & 26]

Sorry for the review spam benjamin :/
I should have checked first that you are the peer for most of those modules.

Comment 6

[Arpad Borsos [:Swatinem]]

Attachment: build system cleanup + removes

This patch also includes the removes for now unused files/directories.

Comment 7

[Arpad Borsos [:Swatinem]]

Attachment: comm-central cleanup [Checkin: Comment 18]

This patch removes the flags from comm-centrals configure system.

Comment 8

[Benjamin Smedberg]

Comment on attachment 345691 [details] [diff] [review]
embedding cleanup

Please skip the .pkg changes, they are obsolete files going to be removed anyway.

Comment 9

[Benjamin Smedberg]

Comment on attachment 345692 [details] [diff] [review]
libpref cleanup

Please remove the related code: nsIProfileSharingSetup.idl and nsSharedPrefHandler.{h,cpp}

Comment 10

[Arpad Borsos [:Swatinem]]

Attachment: embedding cleanup, v2 [Checkin: Comment 21 & 27]

(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

done. r/sr+ as per comment #8.

Comment 11

[Robert Kaiser]

(In reply to comment #8)
> (From update of attachment 345691 [details] [diff] [review])
> Please skip the .pkg changes, they are obsolete files going to be removed
> anyway.

Do we have a bug for that removal? I think it would be a good idea to finally go ahead and really do it ;-)

Comment 12

[Arpad Borsos [:Swatinem]]

Attachment: libpref cleanup, v2

(In reply to comment #9)
> (From update of attachment 345692 [details] [diff] [review])
> Please remove the related code: nsIProfileSharingSetup.idl and
> nsSharedPrefHandler.{h,cpp}

Those files are removed in the "build system + removals" patch.
I fixed a "friend" declaration I missed the first time.

Comment 13

[Arpad Borsos [:Swatinem]]

(In reply to comment #11)
> (In reply to comment #8)
> > (From update of attachment 345691 [details] [diff] [review] [details])
> > Please skip the .pkg changes, they are obsolete files going to be removed
> > anyway.
> 
> Do we have a bug for that removal? I think it would be a good idea to finally
> go ahead and really do it ;-)

Thats bug #461888, I've added it to the dependencies. The patch there got review just today.

Comment 14

[Arpad Borsos [:Swatinem]]

Attachment: libpref cleanup, v3 [Checkin: Comment 22 & 28]

updated to tip. This patch also included a .pkg file change.

Comment 15

[Arpad Borsos [:Swatinem]]

Attachment: build system cleanup + removes, v2 [Checkin: Comment 24 & 29]

updated to tip. r/sr+ as per attachment #345694 [details] [diff] [review].

Comment 16

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

This can wait until after beta to go in.

Comment 17

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

a191=beltzner

Comment 18

[Serge Gautherie (:sgautherie)]

Comment on attachment 345695 [details] [diff] [review]
comm-central cleanup
[Checkin: Comment 18]

http://hg.mozilla.org/comm-central/rev/c1438af8484b

Comment 19

[Serge Gautherie (:sgautherie)]

Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/mozilla-central/rev/6d544c7476dd

Comment 20

[Serge Gautherie (:sgautherie)]

Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/mozilla-central/rev/2f6c27da8df3

Comment 21

[Serge Gautherie (:sgautherie)]

Comment on attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

http://hg.mozilla.org/mozilla-central/rev/dad669d8d557

Comment 22

[Serge Gautherie (:sgautherie)]

Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/mozilla-central/rev/e6091173285a

Comment 23

[Serge Gautherie (:sgautherie)]

(In reply to comment #22)
> http://hg.mozilla.org/mozilla-central/rev/e6091173285a

Ftr, this was after fixing "new context" for
{
patching file modules/libpref/src/prefapi.cpp
Hunk #3 FAILED at 760
1 out of 3 hunks FAILED
}

Comment 24

[Serge Gautherie (:sgautherie)]

Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/mozilla-central/rev/d8759394226c

Comment 25

[Serge Gautherie (:sgautherie)]

Comment on attachment 345690 [details] [diff] [review]
toolkit cleanup
[Checkin: Comment 19 & 25]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/53f16cb8dc6d

Comment 26

[Serge Gautherie (:sgautherie)]

Comment on attachment 345693 [details] [diff] [review]
profile cleanup
[Checkin: Comment 20 & 26]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/f86913603e25

Comment 27

[Serge Gautherie (:sgautherie)]

Comment on attachment 346101 [details] [diff] [review]
embedding cleanup, v2
[Checkin: Comment 21 & 27]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/9db51756ca48

Comment 28

[Serge Gautherie (:sgautherie)]

Comment on attachment 346219 [details] [diff] [review]
libpref cleanup, v3
[Checkin: Comment 22 & 28]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/56aa85cdead5

Comment 29

[Serge Gautherie (:sgautherie)]

Comment on attachment 346221 [details] [diff] [review]
build system cleanup + removes, v2
[Checkin: Comment 24 & 29]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/264c64559092