461957 - SeaMonkey en-US installer files and check-locales.pl disagree about variable usage

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[Robert Kaiser]

http://hg.mozilla.org/comm-central/rev/0e391b0e5160 for bug 459435 made us run check-locales.pl against installer's L10n files to detect wrong variable usage, but we're not running it against en-US.
This made us end up applying stricter criteria to locales than en-US and our en-US files actually failing the checks.

Either we're using variables wrongly in SeaMonkey en-US installer files or the checker script is wrong.

Comment 1

[Robert Kaiser]

BTW, see e.g. http://tinderbox.mozilla.org/showlog.cgi?tree=Mozilla-l10n-lt&errorparser=unix&logfile=1225192078.1225192343.25122.gz&buildtime=1225192078&buildname=Win2k3%20comm-central%20l10n%20seamonkey&fulltext=1 for what errors show up in an L10n log

Comment 2

[Rimas Kudelis [use needinfo to ping]]

KaiRo has pasted a wrong link. The correct one is: http://tinderbox.mozilla.org/showlog.cgi?log=Mozilla-l10n-lt/1224520913.1224521584.3950.gz

Comment 3

[Robert Kaiser]

I intentionally linked a full log, as the short logs only show some snippet of the error list, while the full one also shows where the error output starts.

Comment 4

[Frank Wein [:mcsmurf]]

Yes, the problem is caused by the installer strings and the changes by Bug 399665. That one is not implemented yet in the SeaMonkey installer. There's no SeaMonkey installer bug yet to port this to the SeaMonkey installer, but I'll file one and mark as blocking this bug.

Comment 5

[Vlado Valastiak [:wladow]]

Guys, pls, comment out lines 164-167 in http://hg.mozilla.org/comm-central/file/0e391b0e5160/suite/locales/Makefile.in so we can get l10n win builds again. There are no builds since 19/10/08

From what I remember this script isn't comparing locale with en-us, just looking for entities obsoleted in Bug 399665 and that's why we fail. There's really no need to have it there until Bug 399665 is ported. It's just blocking us from testing.

Comment 6

[Frank Wein [:mcsmurf]]

Attachment: Patch

Just remove this for now. Not sure if it's worth to port Bug 399665 to SeaMonkey, re-enabling that check is quite easy though.

Comment 7

[Robert Kaiser]

Comment on attachment 345967 [details] [diff] [review]
Patch

r=me as long as it will be re-added once we port bug 399665

Comment 8

[Frank Wein [:mcsmurf]]

Checked in, comm-central rev 21dc49e33c23