TM: debug builds of browser have JIT disabled

RESOLVED FIXED

Status

()

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: dvander, Assigned: timeless)

Tracking

Trunk
x86
Mac OS X
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Follow-up of bug 454561 - xpcjsruntime.cpp:1318 installs a debug handler in an #ifdef DEBUG block.
So this is actually causing some problems when investigating performance issues on websites where the code is hard to port to js shell....
Blocks: 454561

Comment 2

10 years ago
Yeah this is bad. I am running a debug browser by default.
If the debug-keyword handler installed by a debugging build is JIT-safe, we have to find a new way of solving bug 454561 (which is likely since some negative reviews have popped up since then).

If it's not JIT-safe, I'd recommend turning off the debug-keyword handler by default instead. 

This is potentially a bit of a rock-vs-hard-place issue, since some debugging facilities are probably never going to be JIT-safe. For those we have to determine which of the two (debug facility or JIT) to turn off in each configuration.

I'll try to determine which is which here. The short-term / immediate solution if your workday is being held up here is to just locally revert the 4-line patch of bug 454561 in your workspace. But I'll try to put together a more useful permanent solution.
Assignee: general → graydon
(Assignee)

Comment 4

10 years ago
fixed in changeset 429bfa1c5dea
Assignee: graydon → timeless
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
This needs to get fixed in the tracemonkey repo too, since that's where this is being the biggest problem.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 6

10 years ago
um, you already accidentally fixed it in your commit for bug 462184 in the tracemonkey repo in changeset 9994733fb845

whomever merges tracemonkey w/ central will be stuck with the job of removing the code entirely (making my commit win over yours)
Status: REOPENED → RESOLVED
Last Resolved: 10 years ago10 years ago
Resolution: --- → FIXED
Er, that wasn't supposed to happen, and I backed that out on TM.  Please land this patch on TM ASAP.
(Assignee)

Comment 8

10 years ago
pushed to tm in changeset 0a765c5ce37d

Updated

10 years ago
Flags: in-testsuite-
Flags: in-litmus-
You need to log in before you can comment on or make changes to this bug.