462043 - Write a BuildFactory containing all the necessary steps to do a test of bouncer links and compare the releasetest and release channel update snippets.

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

Attachment: [checked in] final verification, scriptified, buildbotified

Put simply, we should run our "Final Verification" test from Buildbot.

One note, when this goes to production I intend to make it runnable by linux and mac slaves (and win32 if I get around to testing on it).

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 345150 [details] [diff] [review]
[checked in] final verification, scriptified, buildbotified

>diff -r 3cfbcb8ac074 release/final-verification.sh

I look forward to the glorious day when all this stuff is in python.

>+cat $configs | grep -v major | sed 's/betatest/releasetest/' > update.cfg

Is the grep a leftover from testing ?

>+linuxUpdateVerifyConfig = 'moz191-firefox-linux.cfg'
>+macUpdateVerifyConfig   = 'moz191-firefox-mac.cfg'
>+win32UpdateVerifyConfig = 'moz191-firefox-win32.cfg'

btw, do we have anything to bump these files in a mercurial world ? See BumpVerifyConfig in Bootstrap/Step/Updates.pm.

Comment 2

[[e-mail] (:bhearsum)]

(In reply to comment #1)
> >+cat $configs | grep -v major | sed 's/betatest/releasetest/' > update.cfg
> 
> Is the grep a leftover from testing ?
> 

I kept it in because we'll want it there at some point going forward (granted, it's pretty far off). Come to think of it, we could probably add a BuildStep for this on 1.8/1.9 if we felt so inclined.

> >+linuxUpdateVerifyConfig = 'moz191-firefox-linux.cfg'
> >+macUpdateVerifyConfig   = 'moz191-firefox-mac.cfg'
> >+win32UpdateVerifyConfig = 'moz191-firefox-win32.cfg'
> 
> btw, do we have anything to bump these files in a mercurial world ? See
> BumpVerifyConfig in Bootstrap/Step/Updates.pm.

Not yet. Gonna pull that logic out RSN.

Comment 3

[[e-mail] (:bhearsum)]

Comment on attachment 345150 [details] [diff] [review]
[checked in] final verification, scriptified, buildbotified

Checking in factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.26; previous revision: 1.25
done
in buildbot-configs: changeset:   470:8e1e42f3be11

in hg-tools: changeset:   15:7477caabfe9e

Comment 4

[[e-mail] (:bhearsum)]

Nick, you're absolutely right about the | grep -v major, of course. I'll get a patch for that up soon.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: remove the | grep -v major

Comment 6

[[e-mail] (:bhearsum)]

Comment on attachment 345720 [details] [diff] [review]
remove the | grep -v major

So, while working on bug 462145 I realized that the update verify script got imported into hg.m.o/build/tools. Once Bootstrap is updated to pull both l10nverify and update verify scripts from there we'll delete them from CVS. I should re-work this to pull from hg.m.o instead.

Comment 7

[[e-mail] (:bhearsum)]

Attachment: [checked in] final verification, out of HG

Alright....this greatly simplifies things. final-verification.sh lives alongside update verification scripts in hg.m.o/build/tools so we don't need to pull it from anywhere. Just create a new config, run it, and grep the log.

I uncovered an error case that wasn't previously handled (empty update.xml). This version handles that, too.

Comment 8

[Nick Thomas [:nthomas] (UTC+12)]

Comment on attachment 345754 [details] [diff] [review]
[checked in] final verification, out of HG

Don't forget to update ReleaseFinalVerification in process/factory.py now that the cvsroot argument isn't needed. Nice catch on the error case.

Comment 9

[[e-mail] (:bhearsum)]

Comment on attachment 345754 [details] [diff] [review]
[checked in] final verification, out of HG

changeset:   16:230fd143b7c1

Comment 10

[[e-mail] (:bhearsum)]

Attachment: [checked in] trivial follow-up to ReleaseFinalVerification

Checking in factory.py;
/cvsroot/mozilla/tools/buildbotcustom/process/factory.py,v  <--  factory.py
new revision: 1.27; previous revision: 1.26
done