462045 - make server.isSecure work for POP/IMAP

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect)

Description

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Following up on bug 316245 comment 20. 
server.isSecure doesn't really work for POP/IMAP. I think this the best of the suggested options is to make it work - that way it's handy to use from js, and the TLS is a bit of a special case anyways...

Comment 1

[[e-mail]]

Comment on attachment 345154 [details] [diff] [review]
proposed fix

This code duplication worries me... maybe it would be better to move the existing code to nsNntpIncomingServer?

I'm also tempted to suggest a followup bug to make NNTP use the socket type throughout (making isSecure readonly), but I imagine that might prove a headache for existing profiles.

Comment 2

[Magnus Melin [:mkmelin]]

Well, that depends on how you look at it. 
Sure, there's a ~10 row code duplication, but at least to me is seem all one ever want to know if it's secure or not. alwaysUseTLS is the odd one out, only applicable for pop and imap so therefore I'd argue checking for it belong in those classes.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 345154 [details] [diff] [review]
proposed fix

Though making isSecure readonly should certainly be a goal, and we even have bug 420262 about nntp starttls...

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Comment 5

[Magnus Melin [:mkmelin]]

Ignore the one space off in nsMsgFolderDataSource...

Comment 6

[Magnus Melin [:mkmelin]]

sr ping

Comment 7

[David :Bienvenu]

Comment on attachment 345793 [details] [diff] [review]
proposed fix, v2

sr=bienvenu, except for a nit - should leave arg name as aIsSecure here:

 NS_IMETHODIMP
-nsMsgIncomingServer::GetIsSecure(PRBool* aIsSecure)
+nsMsgIncomingServer::GetIsSecure(PRBool *isSecure)
 {
-  return GetBoolValue("isSecure", aIsSecure);
+  NS_ENSURE_ARG_POINTER(isSecure);
+  PRInt32 socketType;
+  nsresult rv = GetSocketType(&socketType);
+  NS_ENSURE_SUCCESS(rv,rv);
+  *isSecure = (socketType == nsIMsgIncomingServer::alwaysUseTLS ||
+               socketType == nsIMsgIncomingServer::useSSL);
 }

Comment 8

[Magnus Melin [:mkmelin]]

changeset:   812:e689f497950d
http://hg.mozilla.org/comm-central/rev/e689f497950d

->FIXED

Comment 9

[Magnus Melin [:mkmelin]]

Comment 1 filed as bug 463096.