462050 - load the microsummary service after delayedStartup, w/ other non-essential services

Status: RESOLVED FIXED

(Firefox Graveyard :: Microsummaries, defect)

Description

[Dietrich Ayala (:dietrich)]

Attachment: delay 4 seconds

this patch delays the initialization of the microsummary service until a few seconds after chrome comes up. ryan's trace showed it took 4ms at startup.

loading microsummaries is likely to delay a few seconds, as they're not critical to startup, and are usually refreshed on a delay anyway.

myk, are there any reasons you can think of why this would be a bad idea?

Comment 1

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 345166 [details] [diff] [review]
delay 4 seconds

(In reply to comment #0)
> myk, are there any reasons you can think of why this would be a bad idea?

No, I think this is just fine. r=myk

Comment 2

[Dietrich Ayala (:dietrich)]

http://hg.mozilla.org/mozilla-central/rev/84a9e53373c7

Comment 3

[Shawn Wilsher :sdwilsh]

I backed this out so we can try to get better perf numbers.

http://hg.mozilla.org/mozilla-central/rev/cf6c01973a89
http://hg.mozilla.org/mozilla-central/rev/3bd9b32db894

Comment 4

[Shawn Wilsher :sdwilsh]

relanded this to mozilla-central at 1:53 PM PDT
http://hg.mozilla.org/mozilla-central/rev/040c59e7d039

Comment 5

[Dietrich Ayala (:dietrich)]

vista: 5-6ms win, and one 2ms loss
http://graphs.mozilla.org/#show=787093,787114,787126,1431846&sel=1225556160,1225576884

xp: 7-8ms win, and one 6ms loss
http://graphs.mozilla.org/#show=395006,395018,395046,1431862&sel=1225555347,1225577274

linux: 6-15ms win
http://graphs.mozilla.org/#show=395123,395133,395164,911692,1431030&sel=1225565664,1225582197

Comment 6

[Dietrich Ayala (:dietrich)]

oh, we also had 100ms win on qm-plinux-trunk02, but i didn't include it because that box is just ridiculous.