Closed Bug 462147 Opened 16 years ago Closed 16 years ago

Allow migration from SeaMonkey 2.x profiles

Categories

(Thunderbird :: Migration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b2

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

It looks like SeaMonkey will be releasing its version 2 sometime around when Thunderbird does (at a guess). As we already have a SM 1.x migrator, we should have the same facility for 2.x.

I've got a WIP patch that will detect the SM 2.x profiles. I think it works on Mac (I wrote it quite a while ago), but the Linux & Windows versions need tweaking.

If anyone can help that would be useful. The parts to look at are in nsSeamonkeyProfileMigrator.cpp where all the #ifdefs and #defines are.
Flags: wanted-thunderbird3+
Attached patch WIP Patch (obsolete) — Splinter Review
Opps, forgot to attach the patch first time round.
Attached patch The fixSplinter Review
I've tested this on all three platforms and it detects and imports SM 2.x profiles correctly. I haven't checked all our possible import preferences, IMHO that is a different bug.

This patch basically ports what I implemented in SeaMonkey for bug 383051. We'll try and detect profiles.ini first (for newer builds), if that doesn't work we'll revert to the application registry. I've also updated the strings to include SeaMonkey.
Assignee: nobody → bugzilla
Attachment #345280 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #353009 - Flags: review?(bienvenu)
Comment on attachment 353009 [details] [diff] [review]
The fix

I guess this is what normally breaks us out of the infinite loop? Might be worth a comment.

+    rv = parser.GetString(profileID.get(), "IsRelative", buffer);
+    if (NS_FAILED(rv))
+      break;

technically, you don't need to assign to rv here since we don't return it.
Attachment #353009 - Flags: review?(bienvenu) → review+
Comment on attachment 353009 [details] [diff] [review]
The fix

>+<!ENTITY importFromSeamonkey2.label     "Netscape 6, 7, Mozilla 1.x or SeaMonkey">
>+<!ENTITY importFromSeamonkey2.accesskey "N">

"N" is in a collision with _N_ext button
(In reply to comment #5)
> (From update of attachment 353009 [details] [diff] [review])
> >+<!ENTITY importFromSeamonkey2.label     "Netscape 6, 7, Mozilla 1.x or SeaMonkey">
> >+<!ENTITY importFromSeamonkey2.accesskey "N">
> 
> "N" is in a collision with _N_ext button

Given I didn't actually change that value here please file a separate bug. I'd rather not rush to fix this as its easy to get wrong cross-platform.
Checked in: http://hg.mozilla.org/comm-central/rev/9fd636867a00
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-litmus?
Keywords: helpwanted
Resolution: --- → FIXED
Target Milestone: Thunderbird 3 → Thunderbird 3.0b2
Would cloning https://litmus.mozilla.org/show_test.cgi?id=5441 and making sure people use a 2.x profile would be enough ?
(In reply to comment #8)
> Would cloning https://litmus.mozilla.org/show_test.cgi?id=5441 and making sure
> people use a 2.x profile would be enough ?

Yes.
Depends on: 555134
You need to log in before you can comment on or make changes to this bug.