getZOrderDOMWindowEnumerator broken on Linux and Mac

RESOLVED FIXED in Firefox 3.6

Status

()

Firefox
General
RESOLVED FIXED
9 years ago
2 months ago

People

(Reporter: Ehsan, Assigned: dao, NeedInfo)

Tracking

(Depends on: 1 bug, {dev-doc-needed, fixed1.9.1})

Trunk
Firefox 3.6
dev-doc-needed, fixed1.9.1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.5 -
blocking-firefox3.6 -

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

getZOrderDOMWindowEnumerator seems to be working only on Windows.  We need to adjust the #ifdefs at the following places accordingly:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/browser.js#4267

http://mxr.mozilla.org/mozilla-central/source/browser/components/nsBrowserContentHandler.js#253
Depends on: 450576
Bug 456439 will be adding another copy of this code to nsBrowserGlue.js as well.
Flags: blocking-firefox3.1?
Yeah... we need to fix this.

bug 156333 is the longstanding Linux bustage.
Depends on: 156333
As per comment 2, dunno why he didn't flip the flag himself ;)
Flags: blocking-firefox3.1? → blocking-firefox3.1+
Target Milestone: --- → Firefox 3.1
Assignee: nobody → dtownsend
Priority: -- → P2
Looks like this isn't going to get fixed on Mac anytime soon. Ehsan, do you have a good understanding of the changes we need to handle this?
(Assignee)

Updated

9 years ago
Without the dependencies being fixed, there is nothing to do here.  This bug is mostly about removing the conditional code inside of BROKEN_WM_Z_ORDER blocks, once the dependencies are fixed.

Given that bug 450576 is blocking1.9.1-, and bug 156333 is wanted1.9.1+, I'm not sure how this one ended up being blocking1.9.1+.  Turning the flag to ? for reconsideration.
Flags: blocking-firefox3.1+ → blocking-firefox3.1?
bug 450576 was previously blocking but josh has concluded that it is too risky to take for 1.9.1, so we can't block here either.
Assignee: dtownsend → nobody
Flags: blocking-firefox3.1? → blocking-firefox3.1-
Pretty sure we still have to fix the ifdefs so that we don't assume mac will work...
Flags: blocking-firefox3.1- → blocking-firefox3.1+
(Assignee)

Comment 8

9 years ago
Created attachment 356324 [details] [diff] [review]
don't assume that mac works

this is what nsPrivateBrowsingService.js already does
Attachment #356324 - Flags: review?(mconnor)
The patch in bug 462478 would make this one simpler.
Whiteboard: [has patch][needs review mconnor]
Assignee: nobody → dao
(Assignee)

Comment 10

9 years ago
Created attachment 356633 [details] [diff] [review]
updated (checked in)
Attachment #356324 - Attachment is obsolete: true
Attachment #356633 - Flags: review?(mconnor)
Attachment #356324 - Flags: review?(mconnor)
Comment on attachment 356633 [details] [diff] [review]
updated (checked in)

thanks!
Attachment #356633 - Flags: review?(mconnor)
Attachment #356633 - Flags: review+
Attachment #356633 - Flags: approval1.9.1+
(Assignee)

Updated

9 years ago
Whiteboard: [has patch][needs review mconnor] → [needs landing]
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Comment 12

9 years ago
Comment on attachment 356633 [details] [diff] [review]
updated (checked in)

http://hg.mozilla.org/mozilla-central/rev/d765319f547d

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a05e3e37e030
Attachment #356633 - Attachment description: updated → updated (checked in)
(Assignee)

Updated

9 years ago
Keywords: checkin-needed → fixed1.9.1
Whiteboard: [needs landing]
(Assignee)

Updated

8 years ago
Assignee: dao → nobody
Target Milestone: Firefox 3.1 → ---
This is "fine" for now, but we should stay on top of this for .next
Flags: blocking-firefox3.6+
Flags: blocking-firefox3.5-
Flags: blocking-firefox3.5+
Connor, this is blocking, but there's a checked in patch? I think we want to:

 - close this bug
 - open a new bug with a description of what has to change
 - make that bug blocking, if you believe it needs to be
 - make sure that bug has an assignee

Assigning this to mconnor for now to handle.
Assignee: nobody → mconnor
After further discussion with mconnor - this doesn't block. mconnor does still believe we should fix it, instead of just assuming broken z order everywhere except windows. It may well belong in its own bug instead of here, but either way, marking it blocking-.
Flags: blocking-firefox3.6+ → blocking-firefox3.6-
(Assignee)

Updated

8 years ago
Blocks: 528440
(Assignee)

Updated

8 years ago
Blocks: 530298

Updated

7 years ago
Assignee: mconnor → nobody
Priority: P2 → --
while on Mac it is working it still fails on Linux. Is there anything we can do here to get this enumerator fixed?
Blocks: 689513
Looks like this is working now across platforms. Ehsan, can you verify that?
Flags: needinfo?(ehsan)
The code in question doesn't exist any more.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(ehsan)
Resolution: --- → WORKSFORME
(Assignee)

Comment 19

4 years ago
It still exists. (See the URL field.)
Status: RESOLVED → REOPENED
Resolution: WORKSFORME → ---
Oh, right, it was moved... by me! ;-)
What I wanted to say in comment 17 is that we have a test for Mozmill which makes use of the getZOrderDOMWindowEnumerator and works well across platforms. So I wonder if those remaining ifdef declarations are still necessary.

Updated

4 years ago
Blocks: 874566

Updated

4 years ago
Blocks: 891194
No longer blocks: 874566
Blocks: 874566
According to bug 874566, the ZOrder enumerator now works on Mac, so updating this accordingly.
Summary: getZOrderDOMWindowEnumerator broken on both Linux and Mac → getZOrderDOMWindowEnumerator broken on Linux
(Assignee)

Comment 23

4 years ago
(In reply to Mark Hammond (:markh) from comment #22)
> According to bug 874566, the ZOrder enumerator now works on Mac, so updating
> this accordingly.

Please continue that discussion in bug 450576. Once resolved, we should update this bug, and file a bug on updating our BROKEN_WM_Z_ORDER logic.
Summary: getZOrderDOMWindowEnumerator broken on Linux → getZOrderDOMWindowEnumerator broken on Linux and Mac
This bug doesn't seem useful anymore.
Status: REOPENED → RESOLVED
Last Resolved: 4 years ago4 years ago
Resolution: --- → FIXED
No longer blocks: 891194
I morphed bug 891194 into being about fixing BROKEN_WM_Z_ORDER
Resolution: FIXED → INCOMPLETE
(Assignee)

Updated

4 years ago
Assignee: nobody → dao
Resolution: INCOMPLETE → FIXED
Target Milestone: --- → Firefox 3.6
Dao, so this issue got fixed 4 years ago, right? I ask because MDN still refers to this bug and says that it is broken on Linux and OS X. 

https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XPCOM/Reference/Interface/nsIWindowMediator#getZOrderDOMWindowEnumerator()
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 27

2 months ago
You're misunderstanding what this bug is about. It's not about whether getZOrderDOMWindowEnumerator is broken but where it's broken.
Flags: needinfo?(dao+bmo)
(Assignee)

Comment 28

2 months ago
Somebody should update MDN to say that it's broken on Linux and point to bug 156333 rather than this bug. Unfortunately editing MDN requires a github account these days and I don't have one.
(In reply to Dão Gottwald [::dao] from comment #28)
> Somebody should update MDN to say that it's broken on Linux and point to bug
> 156333 rather than this bug. Unfortunately editing MDN requires a github
> account these days and I don't have one.

Thanks Dao. Sheppy, can you or someone else please update the above referenced page? Thanks.
Flags: needinfo?(eshepherd)
Keywords: dev-doc-needed
You need to log in before you can comment on or make changes to this bug.