Closed
Bug 689513
Opened 13 years ago
Closed 13 years ago
Driver has to fallback to getMostRecentWindow because getZOrderDOMWindowEnumerator is broken
Categories
(Mozilla QA Graveyard :: Mozmill Tests, defect)
Mozilla QA Graveyard
Mozmill Tests
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [lib])
Attachments
(2 files, 1 obsolete file)
|
8.76 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
|
394 bytes,
text/html
|
Details |
Currently we are using the getZOrderDOMWindowEnumerator to enumarate windows from the back to front. That enumerator is broken on Linux and cannot be used at all. Therefore we have to fallback to use getMostRecentWindow to get the topmost window of a given type. Because of that our getWindowsByZOrder method also doesn't work and has to be disabled for now.
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [module-refactor]
|
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #562696 -
Flags: review?(gmealer)
Attachment #562696 -
Flags: feedback?(jhammel)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 562696 [details] [diff] [review]
Patch v1
looks good to me. regrettable there are these upstream bugs :(
Attachment #562696 -
Flags: feedback?(jhammel) → feedback+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Comment on attachment 562696 [details] [diff] [review]
Patch v1
Review process happened over on github. I will upload the final patch right away.
Attachment #562696 -
Flags: review?(gmealer) → review-
|
|
Assignee | |
Comment 4•13 years ago
|
||
As reviewed by Geo. Setting r+.
https://github.com/geoelectric/mozmill-api-refactor/pull/6
Attachment #562696 -
Attachment is obsolete: true
Attachment #563027 -
Flags: review+
|
|
Assignee | |
Comment 5•13 years ago
|
||
Pointer to Github pull-request
|
|
Assignee | |
Comment 6•13 years ago
|
||
Landed as:
https://github.com/geoelectric/mozmill-api-refactor/commit/e05fe3f5bdc668821eb1f993a2e9fe02d0db7fd9
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•13 years ago
|
Component: Mozmill Shared Modules → Mozmill Tests
|
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [module-refactor] → [lib]
|
||
Updated•6 years ago
|
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•