Driver has to fallback to getMostRecentWindow because getZOrderDOMWindowEnumerator is broken

RESOLVED FIXED

Status

Mozilla QA
Mozmill Tests
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [lib])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
Currently we are using the getZOrderDOMWindowEnumerator to enumarate windows from the back to front. That enumerator is broken on Linux and cannot be used at all. Therefore we have to fallback to use getMostRecentWindow to get the topmost window of a given type. Because of that our getWindowsByZOrder method also doesn't work and has to be disabled for now.
(Assignee)

Updated

7 years ago
Whiteboard: [module-refactor]
(Assignee)

Comment 1

7 years ago
Created attachment 562696 [details] [diff] [review]
Patch v1
Attachment #562696 - Flags: review?(gmealer)
Attachment #562696 - Flags: feedback?(jhammel)

Comment 2

7 years ago
Comment on attachment 562696 [details] [diff] [review]
Patch v1

looks good to me. regrettable there are these upstream bugs :(
Attachment #562696 - Flags: feedback?(jhammel) → feedback+
(Assignee)

Comment 3

7 years ago
Comment on attachment 562696 [details] [diff] [review]
Patch v1

Review process happened over on github. I will upload the final patch right away.
Attachment #562696 - Flags: review?(gmealer) → review-
(Assignee)

Comment 4

7 years ago
Created attachment 563027 [details] [diff] [review]
Patch v2

As reviewed by Geo. Setting r+.

https://github.com/geoelectric/mozmill-api-refactor/pull/6
Attachment #562696 - Attachment is obsolete: true
Attachment #563027 - Flags: review+
(Assignee)

Comment 5

7 years ago
Created attachment 563028 [details]
Pointer to Github pull request: https://github.com/geoelectric/mozmill-api-refactor/pull/6

Pointer to Github pull-request
(Assignee)

Comment 6

7 years ago
Landed as:
https://github.com/geoelectric/mozmill-api-refactor/commit/e05fe3f5bdc668821eb1f993a2e9fe02d0db7fd9
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Component: Mozmill Shared Modules → Mozmill Tests
(Assignee)

Updated

6 years ago
Whiteboard: [module-refactor] → [lib]
You need to log in before you can comment on or make changes to this bug.