462278 - Week view should default to being scrolled to the "Day Starts At" time

Status: VERIFIED FIXED

(Calendar :: Calendar Frontend, defect, P3)

Description

[Dan Mosedale (:dmosedale, :dmose)]

Right now, it seems to default to midnight, which looks really weird.

Comment 1

[Stefan Sitter [:ssitter]]

Duplicate of Bug 412663?

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Given dbo's comment in that bug, I assume it makes sense to keep this one open and on the radar.

Comment 3

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Attachment: Fix - v1

This fixes and also consolidates a couple of multiday view methods. May depend on bug 456379's patch. There is a small flicker when starting up unfortunately, since before the view is shown (at least in lightning), the box height is not calculated and therefore the scrollHeight is also not calculated, making any scroll fail silently.

I've removed the global scroll handler since it seems to work fine directly on the binding itself. I'm not sure why this needed to be global since there was no comment and no notice in the original bug. berend, maybe you know better?

Comment 4

[Berend Cornelius]

Comment on attachment 350488 [details] [diff] [review]
Fix - v1

Patch looks good and works as advertised. I especially like that we got rid of the ugly scrollhandler implementation.
>-        this.mScrollHandler = function scrollHandler() { self.onScroll(); };
>-        window.addEventListener("scroll", this.mScrollHandler, true);

While you were dealing with the scrollbox, I would also rename its id to something more self-explaining than "childbox"

>+          if (scrollBoxObject && childbox.scrollHeight > 0) {

I believe that the condition would have to be 
if (scrollBoxObject && childbox.scrollHeight > childbox.clientHeight) {

r=berend

Comment 5

[Berend Cornelius]

Attachment: unbitrotted version of'350488: Fix - v1'

Comment 6

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

(In reply to comment #4)
> I believe that the condition would have to be 
> if (scrollBoxObject && childbox.scrollHeight > childbox.clientHeight) {
Not needed. If the element is not sized (i.e view hasn't been shown), then the scrollHeight is 0.


Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/6ada4b8913e6>

-> FIXED

Comment 7

[Berend Cornelius]

>> I believe that the condition would have to be 
>> if (scrollBoxObject && childbox.scrollHeight > childbox.clientHeight) {
>Not needed. If the element is not sized (i.e view hasn't been shown), then the
>scrollHeight is 0.

But how else do you catch the case of a displayed scrollbox that has not overflown, because 24 hours are displayed in the view, so that no scrollbar is displayed? There is no need to "scrollToMinute" in that case.
Of course, in the "scroll" handler your condition makes sense.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

I guess we can skip scrolling there, although it shouldn't hurt either. Have you tested the patch with your version of the condition?

Comment 9

[Andreas Treumann]

Checked in lightning and sunbird build 20081207 -> VERIFIED.

Comment 11

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

These bugs are likely targeted at Lightning 1.0b1, not Lightning 1.0. If this change was done in error, please adjust the target milestone to its correct value. To filter on this bugspam, you can use "lightning-10-target-move".

Comment 12

[j94305]

This seems to be recurring. I opened https://bugzilla.mozilla.org/show_bug.cgi?id=1617587