462393 - Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory]

Status: VERIFIED FIXED

(Calendar :: Build Config, defect)

Description

[Daniel Boelzle [:dbo]]

Bug 433083 caused the js standalone shell to be built by default which conflicts with calendar extra scripts being deployed into dist/bin/js/.
Besides installing and loading the extra scripts from a new directory, e.g. dist/bin/calendar-js/, this requires changes to calendar/installer/.

Comment 1

[Daniel Boelzle [:dbo]]

Attachment: WIP - v1

- This patch deploys and loads form calendar-js and resolves a lot of loader code.
- Unit tests pass.
- The calendar/installer/ files still need to be fixed, but I think the code ought to be complete.
- Further testing wanted; setting qawanted.

Comment 2

[Daniel Boelzle [:dbo]]

Attachment: patch - v1

This patch should also fix the installer part.

Comment 3

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 345881 [details] [diff] [review]
patch - v1

>+++ b/calendar/installer/removed-files.in
>@@ -366,8 +366,54 @@ res/html/gopher-find.gif
>+# Bug 462393 - Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory]
>+js/calAlarm.js
>+js/calAlarmMonitor.js
...

We need to find out if this really works, i.e if the js provided by mozilla-core is a directory or if it is a file, and if it gets overwritten properly.


r=philipp

Comment 4

[Daniel Boelzle [:dbo]]

(In reply to comment #3)
> (From update of attachment 345881 [details] [diff] [review])
> >+++ b/calendar/installer/removed-files.in
> >@@ -366,8 +366,54 @@ res/html/gopher-find.gif
> >+# Bug 462393 - Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory]
> >+js/calAlarm.js
> >+js/calAlarmMonitor.js
> ...
> 
> We need to find out if this really works, i.e if the js provided by
> mozilla-core is a directory or if it is a file, and if it gets overwritten
> properly.

Yes, we need to check that. It's a file, the js shell.

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/941530458625>

-> FIXED

Comment 5

[Daniel Boelzle [:dbo]]

Attachment: gdata fix

Fixes baseDir; different baseDir used by gdata

Comment 6

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Comment on attachment 346117 [details] [diff] [review]
gdata fix

I fixed this the other way around in my patch to bug 463047, but I like this solution much better.

r=philipp

Comment 7

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/00698db7a052>

-> FIXED (again)