Closed
Bug 462393
Opened 16 years ago
Closed 16 years ago
Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory]
Categories
(Calendar :: Build Config, defect)
Calendar
Build Config
Tracking
(Not tracked)
VERIFIED
FIXED
1.0b1
People
(Reporter: dbo, Assigned: dbo)
References
()
Details
Attachments
(2 files, 1 obsolete file)
43.28 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
1.05 KB,
patch
|
Fallen
:
review+
|
Details | Diff | Splinter Review |
Bug 433083 caused the js standalone shell to be built by default which conflicts with calendar extra scripts being deployed into dist/bin/js/. Besides installing and loading the extra scripts from a new directory, e.g. dist/bin/calendar-js/, this requires changes to calendar/installer/.
Updated•16 years ago
|
Blocks: 433083
Summary: Sunbird tinderboxen busted → Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory]
Assignee | ||
Comment 1•16 years ago
|
||
- This patch deploys and loads form calendar-js and resolves a lot of loader code. - Unit tests pass. - The calendar/installer/ files still need to be fixed, but I think the code ought to be complete. - Further testing wanted; setting qawanted.
Assignee: nobody → daniel.boelzle
Attachment #345752 -
Flags: review?(philipp)
Assignee | ||
Comment 2•16 years ago
|
||
This patch should also fix the installer part.
Attachment #345752 -
Attachment is obsolete: true
Attachment #345881 -
Flags: review?(philipp)
Attachment #345752 -
Flags: review?(philipp)
Updated•16 years ago
|
Attachment #345881 -
Flags: review?(philipp) → review+
Comment 3•16 years ago
|
||
Comment on attachment 345881 [details] [diff] [review] patch - v1 >+++ b/calendar/installer/removed-files.in >@@ -366,8 +366,54 @@ res/html/gopher-find.gif >+# Bug 462393 - Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory] >+js/calAlarm.js >+js/calAlarmMonitor.js ... We need to find out if this really works, i.e if the js provided by mozilla-core is a directory or if it is a file, and if it gets overwritten properly. r=philipp
Assignee | ||
Comment 4•16 years ago
|
||
(In reply to comment #3) > (From update of attachment 345881 [details] [diff] [review]) > >+++ b/calendar/installer/removed-files.in > >@@ -366,8 +366,54 @@ res/html/gopher-find.gif > >+# Bug 462393 - Sunbird tinderboxen busted [Error: mozilla/dist/bin/js: Not a directory] > >+js/calAlarm.js > >+js/calAlarmMonitor.js > ... > > We need to find out if this really works, i.e if the js provided by > mozilla-core is a directory or if it is a file, and if it gets overwritten > properly. Yes, we need to check that. It's a file, the js shell. Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/941530458625> -> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.0
Assignee | ||
Updated•16 years ago
|
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 5•16 years ago
|
||
Fixes baseDir; different baseDir used by gdata
Attachment #346117 -
Flags: review?(philipp)
Comment 6•16 years ago
|
||
Comment on attachment 346117 [details] [diff] [review] gdata fix I fixed this the other way around in my patch to bug 463047, but I like this solution much better. r=philipp
Attachment #346117 -
Flags: review?(philipp) → review+
Comment 7•16 years ago
|
||
Pushed to comm-central <http://hg.mozilla.org/comm-central/rev/00698db7a052> -> FIXED (again)
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → FIXED
Updated•16 years ago
|
Status: RESOLVED → VERIFIED
Updated•14 years ago
|
Target Milestone: 1.0 → 1.0b1
You need to log in
before you can comment on or make changes to this bug.
Description
•