[Small icons] <toolbarbutton type="menu-button"> increases toolbar height

RESOLVED FIXED in Firefox 3.7a2

Status

()

Firefox
Theme
RESOLVED FIXED
10 years ago
8 years ago

People

(Reporter: Wladimir Palant, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 3.7a2
x86
Windows XP
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

10 years ago
Install Adblock Plus in Firefox, customize the toolbar and switch to small icons. Now drag the Adblock Plus icon off the toolbar - note how toolbar height got smaller. Putting it back will increase toolbar height again. Reason is that Adblock Plus icon has a menu, 

  <toolbarbutton id="abp-toolbarbutton" type="menu-button" label="&menuitem.label;"/>

The anonymous content of this button falls under this rule in browser.css:

toolbar[iconsize="large"][mode="icons"] .toolbarbutton-1:-moz-system-metric(windows-default-theme),
.toolbarbutton-menubutton-button:-moz-system-metric(windows-default-theme) {
  padding: 6px; /* uxtheme border drawing fix/hack */
}

Note that usually a toolbar button has 3 pixel padding which is why vertical toolbar size increases here.

Reproduced on Windows XP in both Firefox 3.0.3 and Minefield 20081030 build.
(Reporter)

Updated

10 years ago
Blocks: 467520
fixed by bug 545842
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Depends on: 545842
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a2
You need to log in before you can comment on or make changes to this bug.