462512 - [Small icons] <toolbarbutton type="menu-button"> increases toolbar height

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Wladimir Palant]

Install Adblock Plus in Firefox, customize the toolbar and switch to small icons. Now drag the Adblock Plus icon off the toolbar - note how toolbar height got smaller. Putting it back will increase toolbar height again. Reason is that Adblock Plus icon has a menu, 

  <toolbarbutton id="abp-toolbarbutton" type="menu-button" label="&menuitem.label;"/>

The anonymous content of this button falls under this rule in browser.css:

toolbar[iconsize="large"][mode="icons"] .toolbarbutton-1:-moz-system-metric(windows-default-theme),
.toolbarbutton-menubutton-button:-moz-system-metric(windows-default-theme) {
  padding: 6px; /* uxtheme border drawing fix/hack */
}

Note that usually a toolbar button has 3 pixel padding which is why vertical toolbar size increases here.

Reproduced on Windows XP in both Firefox 3.0.3 and Minefield 20081030 build.

Comment 1

[Dão Gottwald [:dao]]

fixed by bug 545842