545842 - Style menu buttons and impose a standard size on third-party toolbarbutton icons

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Dão Gottwald [:dao]]

menu button example: adblock plus
oversized-icon example: https://addons.mozilla.org/en-US/firefox/addon/60267

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Dão Gottwald [:dao]]

Comment on attachment 426654 [details] [diff] [review]
patch

>+.toolbarbutton-menubutton-button,
>+.toolbarbutton-menubutton-dropmarker,
> .toolbarbutton-1 {
[...]
>   border: 1px solid;
>   border-color: rgba(0,0,0,.1) rgba(0,0,0,.15) rgba(0,0,0,.25);

Note that the dropmarker suffers from bug 482692.

>+:not([open="true"]):not(:active):hover > .toolbarbutton-menubutton-dropmarker:not([disabled="true"]),

I actually wanted .toolbarbutton-menubutton-dropmarker:hover, but this didn't work for some reason.

Comment 3

[AKIHIRO Misaki (a.k.a Kuden)]

Attachment: Screenshot

Does not this patch support toolbarbutton[type="menu"] styleing?

example:
User Agent Switcher
https://addons.mozilla.org/en-US/firefox/addon/59

Comment 4

[Dão Gottwald [:dao]]

(In reply to comment #3)
> Created an attachment (id=426725) [details]
> Screenshot
> 
> Does not this patch support toolbarbutton[type="menu"] styleing?

Currently only with the toolbarbutton-1 class.

Comment 5

[u88484]

Attachment: Screenshot

Dao, my menu-buton looks different from the ABP menu-button and I'm wondering if this patch is going to fix it?  The ABP button doesn't have any type of border on non-hover whilst mine does and even has the animation.  My button just seems to me missing the black border where it is now white.

Here is my code:
https://addons.mozilla.org/en-US/firefox/files/browse/75741

Button code is under chrome -> content -> firefoxOverlay.xul

Style code is under chrome -> skin -> overlay.css

Comment 6

[Dão Gottwald [:dao]]

(In reply to comment #5)
> Created an attachment (id=426845) [details]
> Screenshot
> 
> Dao, my menu-buton looks different from the ABP menu-button and I'm wondering
> if this patch is going to fix it?

https://build.mozilla.org/tryserver-builds/[e-mail]-try-a5f8a24b7ddd/try-a5f8a24b7ddd-win32.zip contains the patch.

Comment 7

[IU]

Attachment: Screenshot (undersized button)

Will this patch also fixed the issue of undresized buttons?

The attached screenshot is for small icons on Windows XP with classic theme.

Note how disproportionately small the Video DownloadHelper button is.

Comment 8

[IU]

Also, notice, as show in the image labeled "Hover over ABP button" in the screenshot of Attachment 426845 [details], that there is an extra few pixels to the right over every button that has a drop-down.  I notice the exact same issue with all such buttons on my toolbar.

Comment 10

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/a05ab26714f6

Comment 11

[u88484]

I have a black border to the right of the menu button portion a menu-button.  Are all icons are now going to forced to be 16px?  I just want to know so I can delete the code is so, plus a dev doc should be created to mention it.

And for some reason with small icons code with icons set to be small, my extensions icon is fuzzy and looks stretched even though the icon is 16px.

Code: 
toolbar[iconsize="small"] #undoclosedtabsbutton-toolbar-button {list-style-image: url ("chrome://undoclosedtabsbutton/skin/toolbar-button-small-passive.png");}

Comment 12

[Dão Gottwald [:dao]]

Icons are currently forced to be 18px, but only with the default theme on Windows...

Comment 13

[Tanner M. Young [:tmyoung]]

Verified Fixed on Trunk using ABP, Video Download Helper, and Minimap.

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.3a2pre) Gecko/20100218 Minefield/3.7a2pre (.NET CLR 3.5.30729) ID:20100218045818