462645 - [classic] messengericons-small.png does not have a transparent background

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Philip Chee]

Attachment: messengericons-small.png with transparent background (I hope)

When I re-sampled down messengericons.png to make messengericons-small.png in Bug 428227 I seem to have forgotten to make the background transparent. I hope I've got it right this time but I don't have the right tools to check.

Comment 1

[[e-mail]]

Comment on attachment 345853 [details]
messengericons-small.png with transparent background (I hope)

Needs 8-bit alpha translucency as discussed on IRC.

Comment 2

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b2pre) Gecko/20081031 SeaMonkey/2.0a2pre - Build ID: 20081031000526

Well, I've "freshened" the file skin/classic/messenger/icons/messengericons-small.png within the archive /usr/local/seamonkey/chrome/classic.jar (whose extension had been temporarily changed to .zip), then I've selected the default theme and restarted. Where should I look for these icons to see if they look OK? If on the toolbar, what should I do to use small (rather than large) icons there?

Comment 3

[Philip Chee]

You'll need to apply this patch <https://bugzilla.mozilla.org/attachment.cgi?id=345878&action=edit> from Bug 428216 (toolbarbutton iconsize/mode control)

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to comment #3)
> You'll need to apply this patch
> <https://bugzilla.mozilla.org/attachment.cgi?id=345878&action=edit> from Bug
> 428216 (toolbarbutton iconsize/mode control)

Ah. Well, I don't have the resources (and the know-how) to compile SeaMonkey. I think I'll wait until bug 428216 lands then. Anyway, the r- associated with comment #1 seems to imply this isn't the right .png yet.

Comment 5

[Robert Kaiser]

Attachment: shrunk messengericons.png

I've just loaded messengericons.png into GIMP and resized it to the size of messengericons-small.png here, also running optipng on the saved image to reduce its size to the optimal mode.

Comment 6

[Philip Chee]

Comment on attachment 347950 [details]
shrunk messengericons.png

I don't think this is a patch actually. Also changed the mime type.

Comment 7

[[e-mail]]

Comment on attachment 347950 [details]
shrunk messengericons.png

Oops, didn't mean to clear the flags.

Comment 8

[Robert Kaiser]

Pushed the new image as http://hg.mozilla.org/comm-central/rev/fd72c8c7ad62