Closed Bug 428227 Opened 16 years ago Closed 16 years ago

spring.gif (modern) and communicatoricons-small.png (classic)

Categories

(SeaMonkey :: Themes, enhancement)

Product:
SeaMonkey
Component:
Themes
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
seamonkey2.0a2

People

(Reporter: philip.chee, Assigned: philip.chee)

References

Details

Attachments

(6 files, 3 obsolete files)

skin/classic/communicator/icons/communicatoricons-small.png (Small communicator icons for Bug 428216)
12.65 KB, image/png
kairo
: review+
Details
/skin/classic/navigator/icons/navigatoricons-small.png
2.31 KB, image/png
kairo
: review+
neil
: superreview+
Details
/toolkit/themes/winstripe/global/toolbar/spring.png
440 bytes, image/png
kairo
: review-
neil
: superreview+
Details
spring.png from the past modern theme.
162 bytes, image/png
kairo
: review+
neil
: superreview+
Details
small icons for messenger.
35.83 KB, image/png
kairo
: review+
neil
: superreview+
Details
Patch 2.0 (comm-central) [Checkin: Comment 25]
74.46 KB, patch
kairo
: review+
neil
: superreview+
Details | Diff | Splinter Review 
Add a couple of graphics needed by classic and/or modern Suite themes
Attached image skin/modern/global/toolbar/spring.gif (obsolete) — 
From Bug 394288 Comment 2 :
This is a copy of skin/classic/global/toolbar/spring.gif which should be added
to skin/modern/global/toolbar/spring.gif
Attachment #314762 - Flags: ui-review?
Attachment #314762 - Flags: superreview?(neil)
Attachment #314762 - Flags: review?(neil)
skin/classic/communicator/icons/communicatoricons-small.png

Classic needs small icons for the (yet to be implemented) small icon mode in Bug 428216

I took the existing communicatoricons.png and use LANCZOS to resize it down to 80x100. If someone has the original vector implementations a better version would be possible.
Attachment #314764 - Flags: review?(neil)
Blocks: CustomToolbars, 428216
Hmm. I need to work up a diff for the theme jar.mn(s) as well.
(In reply to comment #2)
> I took the existing communicatoricons.png and use LANCZOS to resize it down to
> 80x100. If someone has the original vector implementations a better version
> would be possible.
That would be MReimer.

        Attachment #315060 -
        Flags: superreview?(neil)

        Attachment #315060 -
        Flags: review?(neil)

    
  

        Attachment #314762 -
        Flags: ui-review? → ui-review-

    
  

        Attachment #314764 -
        Flags: review?(neil)

    
  

        Attachment #314762 -
        Flags: ui-review-

    
    

    
  


  
Shrinking down |navigatoricons.png| really makes this look bad so not looking for review but might be OK as a temporary placeholder.

    
  
Depends on: 432016
Blocks: 432016
No longer depends on: 432016
Product: Core → SeaMonkey

    
    

    
  
I think those looks good for now, we always can get improved ones from MReimer later on.

    
  
Summary: spring.gif (classic) and communicatoricons-small.png (modern) → spring.gif (classic) and communicatoricons-small.png (classic)

    
  
Summary: spring.gif (classic) and communicatoricons-small.png (classic) → spring.gif (modern) and communicatoricons-small.png (classic)
QA Contact: themes → themes

    
    

    
  


  
Latest trunk toolkit spring image.

        Attachment #314762 -
        Attachment is obsolete: true

        Attachment #314762 -
        Flags: superreview?(neil)

        Attachment #314762 -
        Flags: review?(neil)

    
    

    
  


  

    
    

    
  

      
      
      
      

        Attached image
          
        small icons for messenger.
        — 
      

    


  
Resampled down from the original messengericons.png.

    
    

    
  


  
This patch is against the comm-central tip using the spring.png from the Past Modern theme. Asking for r/sr as KaiRo says that these are good enough for placeholders for the time being.

        Attachment #315060 -
        Attachment is obsolete: true

        Attachment #315063 -
        Attachment is obsolete: true

        Attachment #339205 -
        Flags: superreview?(neil)

        Attachment #339205 -
        Flags: review?(kairo)

        Attachment #315060 -
        Flags: superreview?(neil)

        Attachment #315060 -
        Flags: review?(neil)

    
  

        Attachment #314764 -
        Flags: superreview?(neil)

        Attachment #314764 -
        Flags: review?(kairo)

    
  

        Attachment #315061 -
        Flags: superreview?(neil)

        Attachment #315061 -
        Flags: review?(kairo)

    
  

        Attachment #339202 -
        Flags: superreview?(neil)

        Attachment #339202 -
        Flags: review?(kairo)

    
  

        Attachment #339203 -
        Flags: superreview?(neil)

        Attachment #339203 -
        Flags: review?(kairo)

    
  

        Attachment #339204 -
        Flags: superreview?(neil)

        Attachment #339204 -
        Flags: review?(kairo)

    
    

    
  
I've put up two versions of spring.png for modern. One is from the latest version from toolkit/themes/winstripe/; and the other is from Kuden's Past Modern theme.

    
    

    
  
Comment on attachment 339202 [details]
/toolkit/themes/winstripe/global/toolbar/spring.png

I'm not really fussed either way, really...

        Attachment #339202 -
        Flags: superreview?(neil) → superreview+

    
    

    
  
Comment on attachment 339203 [details]
spring.png from the past modern theme.

Really, I'm not fussed. Not really.

        Attachment #339203 -
        Flags: superreview?(neil) → superreview+

    
  

        Attachment #339204 -
        Flags: superreview?(neil) → superreview+

    
    

    
  
Comment on attachment 339204 [details]
small icons for messenger.

I should really stop now.

    
    

    
  
Comment on attachment 339205 [details] [diff] [review]
Patch 2.0 (comm-central)
[Checkin: Comment 25]

I didn't really see the point of including the images again.

        Attachment #339205 -
        Flags: superreview?(neil) → superreview+

    
  

        Attachment #315061 -
        Flags: superreview?(neil) → superreview+

    
    

    
  
Comment on attachment 314764 [details]
skin/classic/communicator/icons/communicatoricons-small.png (Small communicator icons for Bug 428216)

The last row matches home.png right? Are there some CSS changes to obsolete it?

    
    

    
  
> (From update of attachment 339205 [details] [diff] [review])
> I didn't really see the point of including the images again.

Err that's how hg diff worked. I wasn't expecting the binaries to show up in the diff.

> The last row matches home.png right?
Yes.
> Are there some CSS changes to obsolete it?
??

    
    

    
  
(In reply to comment #19)
> > The last row matches home.png right?
> Yes.
> > Are there some CSS changes to obsolete it?
> ??
Well, the new image makes home.png obsolete...

    
    

    
  
Comment on attachment 314764 [details]
skin/classic/communicator/icons/communicatoricons-small.png (Small communicator icons for Bug 428216)

Sure, let's go with those for now, we can always improve them when MReimer might come up with newly rendered ones.

        Attachment #314764 -
        Flags: review?(kairo) → review+

    
  

        Attachment #315061 -
        Flags: review?(kairo) → review+

    
  

        Attachment #339204 -
        Flags: review?(kairo) → review+

    
  

        Attachment #339203 -
        Flags: review?(kairo) → review+

    
    

    
  
Comment on attachment 339203 [details]
spring.png from the past modern theme.

Ratty says this one is better and Neil and me both have no string preference, so let's go with this one here.

    
    

    
  
Comment on attachment 339202 [details]
/toolkit/themes/winstripe/global/toolbar/spring.png

Minusing on the basis that we can only take one image. :)

        Attachment #339202 -
        Flags: review?(kairo) → review-

    
    

    
  
Comment on attachment 339205 [details] [diff] [review]
Patch 2.0 (comm-central)
[Checkin: Comment 25]

Looks good from inspection, I haven't actually tested it though.

        Attachment #339205 -
        Flags: review?(kairo) → review+

    
  

        Attachment #339202 -
        Attachment description: /toolkit/themes/winstripe/global/toolbar/spring.png → [for check-in] /toolkit/themes/winstripe/global/toolbar/spring.png

    
  

        Attachment #339203 -
        Attachment description: spring.png from the past modern theme. → [for check-in] spring.png from the past modern theme.

    
  

        Attachment #339204 -
        Attachment description: small icons for messenger. → [for check-in] small icons for messenger.

    
  

        Attachment #339205 -
        Attachment description: Patch 2.0 (comm-central) → [for check-in] Patch 2.0 (comm-central)

    
  

        Attachment #339202 -
        Attachment description: [for check-in] /toolkit/themes/winstripe/global/toolbar/spring.png → /toolkit/themes/winstripe/global/toolbar/spring.png

    
  

        Attachment #339203 -
        Attachment description: [for check-in] spring.png from the past modern theme. → spring.png from the past modern theme.

    
  

        Attachment #339204 -
        Attachment description: [for check-in] small icons for messenger. → small icons for messenger.

    
    

    
  
Comment on attachment 339205 [details] [diff] [review]
Patch 2.0 (comm-central)
[Checkin: Comment 25]

http://hg.mozilla.org/comm-central/rev/cd38559a8c61

        Attachment #339205 -
        Attachment description: [for check-in] Patch 2.0 (comm-central) → Patch 2.0 (comm-central)
[Checkin: Comment 25]
Status: NEW → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0a2

    
  

        Attachment #314764 -
        Flags: superreview?(neil)

    
  
Blocks: 459509

    
  
Depends on: 462645
No longer blocks: 432016

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: