Closed Bug 462758 Opened 13 years ago Closed 10 years ago
elements with contenteditable=true and position:absolute can be moved around the page
User-Agent: Mozilla/5.0 (X11; U; Linux i686; fr; rv:18.104.22.168) Gecko/2008101315 Ubuntu/8.10 (intrepid) Firefox/3.0.3 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:22.214.171.124) Gecko/2008101315 Ubuntu/8.10 (intrepid) Firefox/3.0.3 The new contenteditable feature implemented if firefox3 has an unexpected behavior on absolut positionned elements: when enabled (contenteditable="true"), those elements become draggable and resizable on the entire page. Therefore it is not only the content of this element that is editable, but some properties of the element itself (both position and dimensions). This behavior is specific to mozilla's implementation of contenteditable. It is not featured in the original IE's implentation, opera nor webkit implementation. It is not described in the WHATWg draft either: http://www.whatwg.org/specs/web-apps/current-work/#contenteditable This behavior should be removed. Reproducible: Always Steps to Reproduce: 1. open an html document containing an element with position: absolute and contenteditable="true" 2. click on this element Actual Results: you can drag and resize the element in the page Expected Results: You should only be able to edit the _content_ of this element. You should be able to drag and resize absolute positioned element only _inside_ this element. You shouldn't be able to drag and resize the element itself
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Summary: native midas's draggable/resizable features applied to elements with position: absolute and contenteditable= true → elements with contenteditable=true and position:absolute can be moved around the page
This particular feature probably has its roots in Composer's layer implementation. Now that contenteditable has become a part of proposed specification, Mozilla probably should look to make this behaviour Mozilla-specific and disabled by default. Currently, this can be worked around by setting the absolute-positioned element's contenteditable to false, putting the contents of the element into a seperate container element and setting the container's contenteditable to true. It should have no side effect on other browsers.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:126.96.36.199) Gecko/20090824 Firefox/3.5.3 GTB5 Confirmed in Firefox 3.5.3 on Win XP SP 3.
Same as bug 498518?
Component: General → Editor
Product: Firefox → Core
QA Contact: general → editor
Status: UNCONFIRMED → NEW
Ever confirmed: true
Assignee: nobody → kaze
Status: NEW → ASSIGNED
Not ready for review, I still have to write the tests. Ehsan: given the number of such bugs, should I add an optional boolean argument to these two functions (false by default) that would allow to check that the node is a strict descendant of the active editing host?
oops. By these two functions I meant: nsHTMLEditor::IsModifiableNode(nsIDOMNode *aNode) nsHTMLEditor::IsNodeInActiveEditor(nsIDOMNode* aNode)
Attachment #555122 - Attachment is obsolete: true
This patch raises two “unexpected-pass” on crashtest/debug: REFTEST TEST-UNEXPECTED-PASS | file:///[…]/layout/base/crashtests/479360-1.xhtml | assertion count 0 is less than expected 6 assertions REFTEST TEST-UNEXPECTED-PASS | file:///[…]/layout/base/crashtests/481806-1.html | assertion count 0 is less than expected 6 assertions These assertions are related to bug 439258, see layout/base/crashtests/crashtests.list: https://mxr.mozilla.org/mozilla-central/source/layout/base/crashtests/crashtests.list#261 # 479360-1.xhtml will assert 6 times due to bug 439258 and then make the test # after the test after it also assert 6 times. asserts(6) load 479360-1.xhtml # Bug 439258 load 480686-1.html asserts(6) load 481806-1.html # Bug 439258 This patch does not solve bug 439358: it just prevents the table editing widgets to be displayed on an editable <td> (see 479360-1.xhtml), so these `asserts(6)' can be removed now.
Attachment #555675 - Attachment is obsolete: true
Comment on attachment 555692 [details] [diff] [review] patch proposal Review of attachment 555692 [details] [diff] [review]: ----------------------------------------------------------------- ::: layout/reftests/editor/reftest.list @@ +67,5 @@ > == 338427-1.html 338427-1-ref.html > skip-if(Android) == 674212-spellcheck.html 674212-spellcheck-ref.html > skip-if(Android) == 338427-2.html 338427-2-ref.html > skip-if(Android) == 338427-3.html 338427-3-ref.html > +skip-if(Android) == 462758-grabbers-resizers.html 462758-grabbers-resizers-ref.html Why are you skipping the test on Android?
Attachment #555692 - Flags: review?(ehsan) → review+
(In reply to Fabien Cazenave (:kaze) from comment #7) > Created attachment 555122 [details] [diff] [review] > patch proposal > > Not ready for review, I still have to write the tests. > > Ehsan: given the number of such bugs, should I add an optional boolean > argument to these two functions (false by default) that would allow to check > that the node is a strict descendant of the active editing host? How about adding another helper function called IsEditingHost or something?
(In reply to Ehsan Akhgari [:ehsan] from comment #13) > Why are you skipping the test on Android? I thought that these grabbers and resizers wouldn’t show up in Fennec. Here’s an updated version of this patch.
(In reply to Ehsan Akhgari [:ehsan] from comment #14) > How about adding another helper function called IsEditingHost or something? That could be an option as well but I see two main drawbacks: • the code returning the active editing host would be called twice (I don’t know if that would be expensive wrt the perfs); • an attribute of a "contenteditable" element should not be modifiable, so we need a bit more than just `IsEditingHost'. However, bug 677752 has been landed short after I’ve proposed to add an optional boolean param to IsModifiableNode / IsNodeInActiveEditor, and I think most cases where we need to check if the current node is a strict descendant of the editing host should be covered now. At this current point, I think modifying IsModifiableNode / IsNodeInActiveEditor would be mostly a matter of factorizing a few lines of code.
Comment on attachment 558811 [details] [diff] [review] patch proposal Review of attachment 558811 [details] [diff] [review]: ----------------------------------------------------------------- If this is ready to land, I'll land the patch for you when you attach a version which addresses the nit below. Thanks! ::: editor/libeditor/html/nsHTMLAnonymousUtils.cpp @@ +367,5 @@ > NS_ASSERTION(!mInlineEditedCell, "HideInlineTableEditingUI failed"); > } > > // now, let's display all contextual UI for good > + nsCOMPtr<nsIContent> hostContent = GetActiveEditingHost(); Nit: change this to an nsIContent* to avoid an unnecessary QI.
Attachment #558811 - Flags: review?(ehsan) → review+
Forgot to `hg qrefresh' again. *sigh*
Attachment #558823 - Attachment is obsolete: true
Target Milestone: --- → mozilla9
It turns out that the test fails on Android, so I had to mark it as such: http://hg.mozilla.org/integration/mozilla-inbound/rev/b1fbce31b7f2
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
This is happening in FF 29. Is it a regression?
You need to log in before you can comment on or make changes to this bug.