46307 - 3pane context menu: News Server selected should match spec

Status: RESOLVED INVALID

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Ninoschka Baca]

Build 2000-07-21-09M17: NT4, Mac 9.04
Haven't checked Linux yet.

Overview: With the News Server selected, the context menu should appear as:

Subscribe...
Rename News Account
Delete News Account
-------------------
Search Messages...
-------------------
Account Properties

For the product to match the spec the following should happen:

1. Move
a. "Subscribe" should appear on the first line

2. Change
a. "Remove News Account" should be "Delete News Account" and enabled.

3. Enable
a. Search Messages...

4. Remove
a. Rename News Account (Hasn't been implemented as referenced in bug#40861)
b. Account Properties  (Depends on bug# 10877 and bug# 32714/which has been 
futured. Alec is there any chance for this to open the Account Settings dialog?)

Comment 1

[jglick]

4b. If this opens the Account Settings dialogs, this wouldn't be dependent on  
bug# 10877 and bug# 32714.

Comment 2

[Ninoschka Baca]

Assigning to timeless.

Comment 3

[timeless]

ooh goody, bugs!

Comment 4

[lchiang]

per mail triage:  remove nsbeta3 nomination and move to future milestone.  For 
the short term, we will combine items here into three bugs (in 3pane) to address 
for nsbetat3:  1. delete, change text, move menuitems;  2. enable/disable and 
text changes on context (dynamic);  3.  accelerator keys to work (ie. what is 
shown in the menus actually does something)

When this bug gets revisited after the first release, we'll need to see what 
items remaining that need to be addressed.

Comment 5

[lchiang]

my mistake.  Correcting milestone back to previous one set.  Netscape6 doesn't 
need this by nsbeta3 so leaving the nsbeta3 nomination off.  This can be fixed 
at any time designated by timeless for Mozilla.

Comment 6

[[e-mail] (gone - use [e-mail] instead)]

Simon, thanks for taking this, much appreciated!

Comment 7

[Simon Lucy]

Attachment: Implementation of Remove Account on the frame context menu

Comment 8

[Simon Lucy]

There should be another patch shortly with Rename support, though I have a
question.  Is it preferable to implement it in nsNewsFolder or implement it
through the data wrapped in AccountManager?

Comment 9

[(not reading, please use [e-mail] instead)]

rename will change the pretty name for the account right?  (we currently don't
allow a hot swap of server hostname or server username.)

if the selection is a server, you could allow rename, but the result would have
to change the prettyName attribute of the nsIMsgIncomingServer.

I don't think the current rename folder xul / js and widgetglue.js will do the
right thing.  you'll need to tweak it to work for nsIMsgFolders and
nsIMsgIncomingServers.

certain folders (like newsgroups) should not show rename, since you aren't
allowed to rename them. 

nsIMsgFolder has a canRename, so you'll need to check that before showing or
enabling "Rename".

I'd worry about all of this in a seperate bug, since it is non trival.

Comment 10

[(not reading, please use [e-mail] instead)]

back to the submitted patch, you need to worry about canDelete attribute of a
nsIMsgIncomingServer.  not all accounts can be deleted.  specifically, Local
Folders can't.

I'm behind on my patches / reviews.  when I get some more cycles, I'll review
the patch more closely.  I'm behind on my patches / reviews big time, I apologize.

Comment 11

[Simon Lucy]

Yes rename is just the pretty name.  AccountManager does it right now but
nsNewsFolder doesn't have anything like that.  I could do it in js but it may be
ugly.  Agreed on leaving it to a separate bug

Comment 12

[Simon Lucy]

on the checking CanDelete I assumed I think that the UI filter on isServer is
'nntp' would be enough to eliminate the rest, but you're right it should check
CanDelete immediately before it does it.

Comment 13

[(not reading, please use [e-mail] instead)]

link to the spec

Comment 14

[[e-mail] (gone - use [e-mail] instead)]

Simon gave up on Mozilla some time ago.  Punting back to Seth, for now.  Simon,
if this is an incorrect statement, take the bug back ;-)

Comment 15

[Olga]

I remove nsbeta1- keyword - it was for MachV.

Comment 16

[Olga]

Now I add 'nsbeta1' keyword for Buffy. Sorry, it's faster to edit multiple bugs
at once than manually go to each and remove minus.

Comment 17

[:deanis74]

Can we get option 4b working?  It's something that I always look to do first,
then I realize Properties is disabled, then I have to hunt through the Account
Settings dialog.  It would be much quicker if Properties for an account opened
Account Settings with that account selected.

Comment 18

[jglick]

Filed bug 172178 so we can try to get the properities menu item working.

Comment 19

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 20

[Philip Chee]

Spec is out of date.