463172 - js/src/configure needs --disable-jit

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Jason Orendorff [:jorendorff]]

The old Makefile.ref system had a DISABLE_JIT make variable that would turn off -DJS_TRACER and -DFEATURE_NANOJIT.  This was useful to check whether changes will actually build on platforms where the JIT isn't supported (like Mac PPC).

Comment 1

[Jason Orendorff [:jorendorff]]

:-(  I recently checked in code that broke non-JIT platforms; if this feature existed I would compile stuff under --disable-jit before checking in as a matter of habit, as I used to do under Makefile.ref.

Is there a workaround?

Comment 2

[Jason Orendorff [:jorendorff]]

A workaround is to use:  make ENABLE_JIT=

Comment 3

[Benjamin Smedberg]

Attachment: Lightly tested, rev. 1

This is lightly tested locally, and I've submitted it to the tryserver as well.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 356003 [details] [diff] [review]
Lightly tested, rev. 1

As discussed on IRC, I'd like to see the stuff in JIT_DEFINES just get AC_DEFINEd in configure, instead of requiring the makefiles to put it in DEFINES. Otherwise looks good.

Comment 5

[Benjamin Smedberg]

Attachment: --disable-jit in configure, rev. 2

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 356534 [details] [diff] [review]
--disable-jit in configure, rev. 2

+    JIT_DEFINES='-DAVMPLUS_IA32'

Looks like you're no longer using JIT_DEFINES. Just remove those two lines?

Looks good otherwise.

Comment 7

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/87bf34282f13
and a followup, because this block needs to be outside SKIP_COMPILER_CHECKS:
http://hg.mozilla.org/mozilla-central/rev/98e0b6b69e05

Comment 8

[Benjamin Smedberg]

Comment on attachment 356534 [details] [diff] [review]
--disable-jit in configure, rev. 2

need to let this bake briefly, but should take this on 1.9.1

Comment 9

[Peter Weilbacher]

What should we do on OS/2 now? Before the patch here we were covered by AVMPLUS_IA32 and it seemed to work well... Now this breaks us:
   "configure: error: Unrecognized nanojit platform"

Comment 10

[Peter Weilbacher]

Sorry, was too much in a hurry to see that there's already bug 474020. Please ignore comment 9.

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 356534 [details] [diff] [review]
--disable-jit in configure, rev. 2

a191=beltzner

Comment 12

[Benjamin Smedberg]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/6b18f4ef1837 which contains the OS/2 and sparc followups as well as the initial bustage fix.