474020 - OS/2 not recognized as a valid nanojit_arch (after bug463172)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Walter Meinl]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090116 Minefield/3.2a1pre
Build Identifier: 

When configure in js/src runs it stops:
Unrecognized nanojit platform
after checkin of bug463172

until this checkin we could successfully build nanojit with the only define -DAVMPLUS_IA32

Fixing this in configure.in would be easy.
However, Benjamin, Ted are there any objections that OS/2 should build the jit?

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Benjamin Smedberg]

I'm a little surprised that you don't have to define any AVMPLUS_{ARCH} macros, from http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#2513

But if it works, I have no objection to adding an OS/2 case to that switch.

Comment 2

[Peter Weilbacher]

Attachment: fix

Although this macro will be unused so far (am surprised, too, that we don't need more OS/2 specific code in JS, but it works), this gets us building again.

(I see that even the AVMPLUS_WIN32 macro is only used once so far...)

Comment 3

[Peter Weilbacher]

Comment on attachment 359981 [details] [diff] [review]
fix

Ted, you can review this trivial fix just as well as Benjamin. Whoever gets there first...

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 359981 [details] [diff] [review]
fix

While you're in there, can you change the error message:
AC_MSG_ERROR([Unrecognized nanojit platform])

to say something like:
Unrecognized nanojit platform. Use --disable-jit to build without JIT support.

Comment 5

[Peter Weilbacher]

Pushed http://hg.mozilla.org/mozilla-central/rev/060afee65a8e with the change to the error message.