OS/2 not recognized as a valid nanojit_arch (after bug463172)

RESOLVED FIXED

Status

--
major
RESOLVED FIXED
10 years ago
8 months ago

People

(Reporter: wuno, Assigned: mozilla)

Tracking

Trunk
x86
OS/2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.9.2a1pre) Gecko/20090116 Minefield/3.2a1pre
Build Identifier: 

When configure in js/src runs it stops:
Unrecognized nanojit platform
after checkin of bug463172

until this checkin we could successfully build nanojit with the only define -DAVMPLUS_IA32

Fixing this in configure.in would be easy.
However, Benjamin, Ted are there any objections that OS/2 should build the jit?

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
(Reporter)

Updated

10 years ago
Blocks: 463172
Version: unspecified → Trunk

Comment 1

10 years ago
I'm a little surprised that you don't have to define any AVMPLUS_{ARCH} macros, from http://mxr.mozilla.org/mozilla-central/source/js/src/configure.in#2513

But if it works, I have no objection to adding an OS/2 case to that switch.
(Assignee)

Comment 2

10 years ago
Created attachment 359981 [details] [diff] [review]
fix

Although this macro will be unused so far (am surprised, too, that we don't need more OS/2 specific code in JS, but it works), this gets us building again.

(I see that even the AVMPLUS_WIN32 macro is only used once so far...)
Assignee: nobody → mozilla
Status: NEW → ASSIGNED
Attachment #359981 - Flags: review?(benjamin)
(Assignee)

Comment 3

10 years ago
Comment on attachment 359981 [details] [diff] [review]
fix

Ted, you can review this trivial fix just as well as Benjamin. Whoever gets there first...
Attachment #359981 - Flags: review?(ted.mielczarek)
Comment on attachment 359981 [details] [diff] [review]
fix

While you're in there, can you change the error message:
AC_MSG_ERROR([Unrecognized nanojit platform])

to say something like:
Unrecognized nanojit platform. Use --disable-jit to build without JIT support.
Attachment #359981 - Flags: review?(ted.mielczarek)
Attachment #359981 - Flags: review?(benjamin)
Attachment #359981 - Flags: review+
(Assignee)

Comment 5

10 years ago
Pushed http://hg.mozilla.org/mozilla-central/rev/060afee65a8e with the change to the error message.
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED

Updated

8 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.