463202 - Search engine box should be cleared when leaving the private browsing mode

Status: VERIFIED FIXED

(Firefox :: Private Browsing, defect)

Description

[Francesco Lodolo [:flod]]

When you leave "private browsing" mode, the text in the search engine box should be cleared. 

Right now, if you search something using the search engine box in private mode, when the normal session is restored the text is not deleted.

Comment 1

[(no longer active)]

Attachment: Patch (v1)

One liner plus a unit test.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 346666 [details] [diff] [review]
Patch (v1)

You need to null check BrowserSearch.searchBar, since it will be null when the search bar is customized away.

Comment 3

[(no longer active)]

Attachment: Patch (v1.1)

(In reply to comment #2)
> (From update of attachment 346666 [details] [diff] [review])
> You need to null check BrowserSearch.searchBar, since it will be null when the
> search bar is customized away.

Done.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Hmm, I suppose we don't have to worry about search bar history because form history in general is not being not being saved? I think we also want to be clearing undo history as we do in the sanitize case, though:

http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js?mark=227#219

And actually, we can do both in one step by using searchbar.textbox.reset() instead of .value = "" and clear(). I could have sworn I'd fixed that sanitize code already...

Comment 5

[(no longer active)]

Attachment: Patch (v1.2)

(In reply to comment #4)
> Hmm, I suppose we don't have to worry about search bar history because form
> history in general is not being not being saved? I think we also want to be
> clearing undo history as we do in the sanitize case, though:
> 
> http://mxr.mozilla.org/mozilla-central/source/browser/base/content/sanitize.js?mark=227#219
> 
> And actually, we can do both in one step by using searchbar.textbox.reset()
> instead of .value = "" and clear().

Done.

> I could have sworn I'd fixed that sanitize
> code already...

Check out bug 463474  :-)

Comment 6

[(no longer active)]

When bug 418874 is fixed, the comments in the test can be removed.

Comment 7

[Elmar Ludwig]

Comment on attachment 346724 [details] [diff] [review]
Patch (v1.2)

>+  // leave private browsing mode
>+  pb.privateBrowsingEnabled = false;
>+
>+  is(searchBar.value, "",
>+    "leaving the private browsing mode should clear the search bar");
>+  /*
>+    XXXehsan: uncomment this code when bug 418874 is fixed.
>+              can't use todo_is, because it would pass unexpectedly!
>+
>+  is(searchBar.textbox.editor.transactionManager.numberOfUndoItems, 0,
>+    "entering the private browsing mode should not reset the undo list of the searchbar control");

It's just a comment for now, but this should probably read:

>+    "leaving the private browsing mode should not reset the undo list of the searchbar control");

Comment 8

[(no longer active)]

Ah, thanks!  Actually, it should read:

"leaving the private browsing mode should reset the undo list of the searchbar control"

;-)

Fixing upon landing.

Comment 9

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/0865b91dd8a0

Comment 10

[Graeme McCutcheon [:graememcc]]

> I could have sworn I'd fixed that sanitize code already...
Yeah, you asked me to put it in my patch for bug 409624! Not to worry, thanks for fixing Ehsan.

Comment 11

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081119 Minefield/3.1b2pre and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1b2pre) Gecko/20081119 Minefield/3.1b2pre.

Comment 12

[(no longer active)]

Mass moving of all Firefox::General private browsing bugs to Firefox::Private Browsing.